From nobody Wed May 29 23:46:46 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VqQyf1jdQz5LZ9P for ; Wed, 29 May 2024 23:46:50 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Received: from smtp-bc08.mail.infomaniak.ch (smtp-bc08.mail.infomaniak.ch [45.157.188.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "relay.mail.infomaniak.ch", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VqQyd67glz472w for ; Wed, 29 May 2024 23:46:49 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Authentication-Results: mx1.freebsd.org; none Received: from smtp-3-0000.mail.infomaniak.ch (smtp-3-0000.mail.infomaniak.ch [10.4.36.107]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4VqQyb0MNZznpv; Thu, 30 May 2024 01:46:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pyret.net; s=20231006; t=1717026406; bh=SvPfqhRHKhiRG+TLYovxsPStxSlhZ9Xa2xMz8Hxlqoo=; h=Date:Subject:From:Reply-To:To:Cc:References:In-Reply-To:From; b=eIAi01LFRIc3WiPuQ8OBNqElV8VffHcxvWaXhbiimCCNp4L9Y6RgarI0witiBtX4Z ya1e6cBm7u64WYKpEViC0bH0FAAlCmv6FgCNI04CPp+NUiNnvrdxzqPRn2lL2vulUO PPsKX2jLZPYTFUoRVPl5wbrdai8/lUIsNSK1/0WXKoUOwzeuJc2f0Hs2NfV3ZEtyPb fNUjZbVmBqeZ8KByXRUMMzkzh339zZY8hh6/nN90gr3DuAuYMb36iMPbQ/mSQ8KNln fKQY7hx4bcvAGPBOVBDRlQZnE9my3CtTJnNeumdCyrQQNqJo43IF6pY5rjrC22jKAC /9J147Kr7n+Iw== Received: from unknown by smtp-3-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4VqQyZ531WzJYg; Thu, 30 May 2024 01:46:46 +0200 (CEST) Message-ID: <03644695a67503b33997b92c38435a04@mail.infomaniak.com> Date: Thu, 30 May 2024 01:46:46 +0200 Subject: Re: git: 86bff3d95b03 - main - www/xcaddy: add missing RUN_DEPENDS on lang/go. From: Daniel Engberg Reply-To: Daniel Engberg To: Jimmy Olgeni Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="_=_swift_1717026406_e800f9d799b6facc34f83e548c09ca23_=_" X-WS-User-Origin: eyJpdiI6IlBBSnkwK0VmYkdOZ0RNdWEySlRvV1E9PSIsInZhbHVlIjoiSzBkOVBEcHZmNENjN3dCN0FzM2VMQT09IiwibWFjIjoiYzU1YTliN2FhYzJkMTA1OTI4MjRjYjg2MzhjOTRjODA4NTdjNjA1MzM5MWQzNWQ3NzM4ZmY3NmZhNjIwOTRmOCIsInRhZyI6IiJ9 X-WS-User-Mbox: eyJpdiI6IktlV2dmUWMxaG5YSnJYOXM4TkZhYmc9PSIsInZhbHVlIjoiNkF5amdzT2VaQm1SVHBiem5CTUEzQT09IiwibWFjIjoiODRjNmNkNDJkZTgyYzk4NWE4MWQ4Yzc3YjQ5MThjMDdjYTFlMTg3MGUwMzBiMWMzMjFlNWQ1ZDE1ODY3MTljNyIsInRhZyI6IiJ9 X-WS-Location: eJxzKUpMKykGAAfpAmU- X-Mailer: Infomaniak Workspace (1.3.691) References: <202405290824.44T8OILm072213@gitrepo.freebsd.org> In-Reply-To: <202405290824.44T8OILm072213@gitrepo.freebsd.org> X-Infomaniak-Routing: alpha X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:29222, ipnet:45.157.188.0/22, country:CH] X-Rspamd-Queue-Id: 4VqQyd67glz472w --_=_swift_1717026406_e800f9d799b6facc34f83e548c09ca23_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2024-05-29T10:24:18.000+02:00, Jimmy Olgeni wrote= : >=C2=A0The=C2=A0branch=C2=A0main=C2=A0has=C2=A0been=C2=A0updated= =C2=A0by=C2=A0olgeni: >=C2=A0 >=C2=A0URL:=C2=A0https://cgit.FreeBSD.org= /ports/commit/?id=3D86bff3d95b03955a22d181fe064f81db968a1bb6 >=C2=A0 >= =C2=A0commit=C2=A086bff3d95b03955a22d181fe064f81db968a1bb6 >=C2=A0 >= =C2=A0Author:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Jimmy=C2=A0Olgeni=C2=A0 >=C2=A0 >=C2=A0AuthorDate:=C2=A02024-05-29=C2=A008:19:39= =C2=A0+0000 >=C2=A0 >=C2=A0Commit:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Jimmy= =C2=A0Olgeni=C2=A0 >=C2=A0 >=C2=A0CommitDate:=C2= =A02024-05-29=C2=A008:23:58=C2=A0+0000 >=C2=A0 >=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0www/xcaddy:=C2=A0add=C2=A0missing=C2=A0RUN_DEPENDS=C2=A0on= =C2=A0lang/go. >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 >= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0xcaddy=C2=A0uses=C2=A0go=C2=A0to=C2=A0build= =C2=A0custom=C2=A0releases=C2=A0of=C2=A0caddy,=C2=A0so=C2=A0it=C2=A0actuall= y=C2=A0needs >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0it=C2=A0at=C2=A0run= time. >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 >=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0PR:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0279358 >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0Reported=C2=A0by:=C2=A0=C2=A0=C2=A0=C2=A0Robert=C2=A0William=C2= =A0Vesterman=C2=A0 >=C2=A0 >=C2=A0--- >=C2=A0 >= =C2=A0=C2=A0www/xcaddy/Makefile=C2=A0|=C2=A04=C2=A0++++ >=C2=A0 >=C2= =A0=C2=A01=C2=A0file=C2=A0changed,=C2=A04=C2=A0insertions(+) >=C2=A0 >= =C2=A0diff=C2=A0--git=C2=A0a/www/xcaddy/Makefile=C2=A0b/www/xcaddy/Makefile= >=C2=A0 >=C2=A0index=C2=A0d8dbd019679e..0fc20011a2eb=C2=A0100644 >= =C2=A0 >=C2=A0---=C2=A0a/www/xcaddy/Makefile >=C2=A0 >=C2=A0+++=C2= =A0b/www/xcaddy/Makefile >=C2=A0 >=C2=A0@@=C2=A0-1,6=C2=A0+1,7=C2=A0@@= >=C2=A0 >=C2=A0=C2=A0PORTNAME=3D=C2=A0=C2=A0=C2=A0=C2=A0xcaddy >= =C2=A0 >=C2=A0=C2=A0DISTVERSIONPREFIX=3D=C2=A0=C2=A0=C2=A0=C2=A0v >= =C2=A0 >=C2=A0=C2=A0DISTVERSION=3D=C2=A0=C2=A0=C2=A0=C2=A00.4.1 >=C2= =A0 >=C2=A0+PORTREVISION=3D=C2=A0=C2=A0=C2=A0=C2=A01 >=C2=A0 >=C2= =A0=C2=A0CATEGORIES=3D=C2=A0=C2=A0=C2=A0=C2=A0www >=C2=A0 >=C2=A0=C2= =A0DIST_SUBDIR=3D=C2=A0=C2=A0=C2=A0=C2=A0xcaddy >=C2=A0 >=C2=A0=C2= =A0 >=C2=A0 >=C2=A0@@=C2=A0-11,6=C2=A0+12,9=C2=A0@@=C2=A0WWW=3D=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0https://github.com/caddyserver= /xcaddy >=C2=A0 >=C2=A0=C2=A0LICENSE=3D=C2=A0=C2=A0=C2=A0=C2=A0APACHE20= >=C2=A0 >=C2=A0=C2=A0LICENSE_FILE=3D=C2=A0=C2=A0=C2=A0=C2=A0${WRKSRC}/= LICENSE >=C2=A0 >=C2=A0=C2=A0 >=C2=A0 >=C2=A0+#=C2=A0xcaddy=C2= =A0actually=C2=A0needs=C2=A0to=C2=A0run=C2=A0the=C2=A0go=C2=A0command=C2= =A0to=C2=A0perform=C2=A0builds >=C2=A0 >=C2=A0+RUN_DEPENDS=3D=C2=A0= =C2=A0=C2=A0=C2=A0go:lang/go >=C2=A0 >=C2=A0+ >=C2=A0 >=C2=A0=C2= =A0USES=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0go:modules >= =C2=A0 >=C2=A0=C2=A0 >=C2=A0 >=C2=A0=C2=A0USE_GITHUB=3D=C2=A0=C2= =A0=C2=A0=C2=A0yes Hi, Please use the helper instead of RUN_DEPEN= DS https://cgit.freebsd.org/ports/tree/Mk/Uses/go.mk#n16 Best reg= ards, Daniel --_=_swift_1717026406_e800f9d799b6facc34f83e548c09ca23_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
On 2024-05-29T10:24:18.000+02:00, Jimmy Olgeni <olgeni@= FreeBSD.org> wrote:


<= div class=3D"ik_mail_quote answerContentMessage">
The branch main has been u=
pdated by olgeni:


commit 86bff3d=
95b03955a22d181fe064f81db968a1bb6
Author:     Jimmy Olgeni &l=
t;olgeni@Fr=
eeBSD.org>
AuthorDate: 2024-05-29 08:19:39 +0000
Commit:     Jimmy Olgeni <olgeni@FreeBSD.org>
CommitD=
ate: 2024-05-29 08:23:58 +0000

    www/xcaddy:=
 add missing RUN_DEPENDS on lang/go.
    
    x=
caddy uses go to build custom releases of caddy, so it actually needs
    it at runtime.
    
    PR:       =
      279358
    Reported by:    Robert William Vesterman <=
;bob@vesterm=
an.com>
---
 www/xcaddy/Makefile | 4 +++=
+
 1 file changed, 4 insertions(+)

diff --git a/www/xcaddy/Makefile b/www/xcaddy/Makefile
ind=
ex d8dbd019679e..0fc20011a2eb 100644
--- a/www/xcaddy/Makefil=
e
+++ b/www/xcaddy/Makefile
@@ -1,6 +1,7 @@
=

 PORTNAME=3D=09xcaddy
 DISTVERSIONPREFIX=3D=09v
 DISTVERSION=3D=090.4.1
+PORTREVISION=3D=091
<=
/div>
 CATEGORIES=3D=09www
 DIST_SUBDIR=3D=09xcaddy
 
@@ -11,6 +12,9 @@ WWW=3D=09=09https://github.com/caddyse=
rver/xcaddy
 LICENSE=3D=09APACHE20
 LICENSE=
_FILE=3D=09${WRKSRC}/LICENSE
 
+# xcaddy actual=
ly needs to run the go command to perform builds
+RUN_DEPENDS=
=3D=09go:lang/go
+
 USES=3D=09=09go:modules
=

 
 USE_GITHUB=3D=09yes
Hi,

Please use the helper instead = of RUN_DEPENDS

Best regards,
Daniel
--_=_swift_1717026406_e800f9d799b6facc34f83e548c09ca23_=_--