Re: git: 28472e9722d8 - main - Revert "x11-fonts/noto*: Restructure and update"

On Fri, Apr 19, 2024 at 7:05 PM Tijl Coosemans <tijl@freebsd.org> wrote:

> On Tue, 9 Apr 2024 05:08:10 +0800 Po-Chuan Hsieh wrote:
> > On Mon, Apr 1, 2024 at 5:46 AM Tijl Coosemans <tijl@freebsd.org> wrote:
> >> On Mon, 1 Apr 2024 04:17:09 +0800 Po-Chuan Hsieh wrote:
> >>> On Mon, Mar 25, 2024 at 3:27 AM Tijl Coosemans <tijl@freebsd.org>
> wrote:
> >>>> - Some fonts have been split into x11-fonts/<font>-basic providing
> Bold,
> >>>>   BoldItalic, Italic, and Regular, and x11-fonts/<font>-extra
> providing
> >>>>   additional styles.  Only some of these have x11-fonts/<font> as a
> >>>>   metaport currently.  This needs to be made consistent.  I think it
> >>>>   would be best to drop the metaports and move x11-fonts/<font>-basic
> to
> >>>>   x11-fonts/<font>.  That way pkg install <font> installs the common
> >>>>   styles for all fonts.  I think that this would be the most
> >>>>   intuitive/convenient.
> >>>>   (I was hoping to use subpackages for this instead of extra ports.)
> >>>
> >>> The -basic/-extra structure was kept for minimal change.
> >>> I agree with you that it would be better to be consistent with all
> other
> >>> noto ports.
> >>> I could merge the following ports:
> >>> - noto-sans-basic/-extra
> >>> - noto-sans-mono-basic/-extra
> >>> - noto-sans-symbols-basic/-extra
> >>> - noto-serif-basic/-extra
> >>> However, what should be noto-basic's dependencies after the merge?
> >>
> >> It's okay to keep the -extra ports.  What I meant was to rename the
> >> -basic ports so noto-sans-basic becomes noto-sans for example.
> >
> > I've prepared a patch [1] for the following changes:
> > - Merge x11-fonts/noto-sans-{basic,extra} to x11-fonts/noto-sans
> > - Merge x11-fonts/noto-sans-mono-{basic,extra} to
> x11-fonts/noto-sans-mono
> > - Merge x11-fonts/noto-sans-symbols-{basic,extra} to
> > x11-fonts/noto-sans-symbols
> > - Merge x11-fonts/noto-serif-{basic,extra} to x11-fonts/noto-serif
> > - Update x11-fonts/noto-basic to depend on the 4 merged ports
> > - Update x11-fonts/noto-extra by removing the 4 -extra ports from
> > RUN_DEPENDS
> >
> > [1]  https://people.freebsd.org/~sunpoet/patch/noto.txt
>
> Changes to x11-fonts/noto-sans and x11-fonts/noto-serif seem to be missing.
>

I've put x11-fonts/noto-sans and x11-fonts/noto-serif patch in
https://people.freebsd.org/~sunpoet/patch/noto-part2.txt
Not sure why it is missing in the previous patch.