From nobody Fri May 03 09:56:41 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VW5nX4s0Bz5JjQM for ; Fri, 3 May 2024 09:57:20 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VW5nX4Kf5z4Wm7 for ; Fri, 3 May 2024 09:57:20 +0000 (UTC) (envelope-from sunpoet@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714730240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oBVgv3dByKjmNulmbzhP++L8H8IN6DhztlaC1onogMY=; b=tA+Ed7f2FGqfdF2Hctic5StJVjnyf5jsidYL6FtBbNp2pfvUFIPNOSOsQskYXR/Zwl/Htm TG7aVJW4lBOsUbsUY16ffblBZfgvi6SOUdDR6AcvMuVgKCnFLPqhbtZhIJzByyVpvWkW/W DS0YoGucsdpb2B2QFAAXCcJBBHuI8XVviIetBQK2MDLeGOgTGNqWzJNlXOKTCvPiZrvKgY 4QtuU3sO4H1bWllJ8l6+hSMSfOD2u0VKylEBhmZfZPgGMKpe97S+HLJjnjw5Fj5DGXBxa+ 4rKDpUuAjknIuzHra2U9Wnuz3td955zWutfy8lxFKvRONZcr/wBlT+WrRvKPLg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1714730240; a=rsa-sha256; cv=none; b=Bhl8fXB57IFldOZxKmEEeiutKJOmdPCd4OuNey47lgbMq8w/OwpOxLyhLVpDkZgSST4rjA 1lJt2wO6u9VMqB0cGEoZi4Q+ReDo4fqT/h4tL7D+jvvmyEbw8KUspC6Yn1YtPQYC+TTlRJ g0dfeKcedxoAzPBnRKRp2zurGXu7Nfhpr/Ol7UHogPKhc5vUhqHcYgTdy/rFw3Mi6zTpv8 D64LK8kp7LwlWpdYCnQioauKyBEk/QWw+Cdxz/ovU0j+H+uuvaPSVM5JzWBy4EmB3cMHAg IDNQ3h8O25wPSHeO+XdV2WZMIWrdCITZxsruV3E+zx7up3q5ZH2xha6+lTuY2w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714730240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oBVgv3dByKjmNulmbzhP++L8H8IN6DhztlaC1onogMY=; b=sLEPbH7MvaD7gFUvQBbKLdoSr4hnvY5qrUmvGgOaoBdeSGez/zt5RqxbaXPSGZJS5x9j0m 5wna1qDdOj6ApeJto5qu04oKynzMp5AkPjGw7STh0ytW4tKRnwraXK0KEZOqsfRurxHAdX aPE2NWfOwmayiiWzHWg27X06swIeEa36tXPOxbG9l7eaS65pkCOGMohTtBGG1W4QZbW3pA VbwvFZvwBF1IalUQba9JYGwq2EN9rx4FcnWFIod4LSSpTCq/3TQn+Sml8f7Em4LgzBhnTO Ek9RlqcwXp93EJurFibKreGfvPbycD+Fe1myaqQYsJtRcFXebYshWNtrSnhWjw== Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VW5nX3wJnzQXv for ; Fri, 3 May 2024 09:57:20 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a519e1b0e2dso1288071166b.2 for ; Fri, 03 May 2024 02:57:20 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWh+S6G+8l+laOUAqdgCXKp+IEkPBePGjWtsQk8x7Si3KG86v6HbbPyrUcd6lq3IpJv3cCivZ4zaJw/3b1CTR/N++bxjY1oSPBg860Ypf4HqoW6 X-Gm-Message-State: AOJu0YxtphDWF6aHDrhiSv3GX2em9pThw0bbe8FJR9sy8QjCUM0UMUmg 2H0x/2Jz6ytAS/4UWwgNDlQLFqWNrDsFNNJZXQlsPJv/dO1LU9HqUJjQtp4N0dbcpPzV1BwRGDG tmkHqLs+MxMKihZSx5sBDoS9SqXPaF68V1P/4bA== X-Google-Smtp-Source: AGHT+IGcCGWGM7j1Bb/coNslgIp6l+TD6PmnuDegHqDaOfurkAAo04KZ+HCNjFRbMpodNCNJbEU4j0E3e7ceUC26Jhg= X-Received: by 2002:a50:d698:0:b0:572:72fc:df54 with SMTP id r24-20020a50d698000000b0057272fcdf54mr1530930edi.22.1714730239042; Fri, 03 May 2024 02:57:19 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 References: <202403231404.42NE4baU095633@gitrepo.freebsd.org> <2567403.0dHE6SNnxz@angua.firefly> <20240324202715.5d18838d@hal.tijl.coosemans.org> <20240331234553.1793b816@hal.tijl.coosemans.org> <20240419130529.6068bc4b@hal.tijl.coosemans.org> In-Reply-To: <20240419130529.6068bc4b@hal.tijl.coosemans.org> From: Po-Chuan Hsieh Date: Fri, 3 May 2024 17:56:41 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 28472e9722d8 - main - Revert "x11-fonts/noto*: Restructure and update" To: =?UTF-8?Q?T=C4=B3l_Coosemans?= Cc: "Tobias C. Berner" , Gleb Popov , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000c8d018061789bed0" --000000000000c8d018061789bed0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Apr 19, 2024 at 7:05=E2=80=AFPM T=C4=B3l Coosemans wrote: > On Tue, 9 Apr 2024 05:08:10 +0800 Po-Chuan Hsieh wrote: > > On Mon, Apr 1, 2024 at 5:46=E2=80=AFAM T=C4=B3l Coosemans wrote: > >> On Mon, 1 Apr 2024 04:17:09 +0800 Po-Chuan Hsieh wrote: > >>> On Mon, Mar 25, 2024 at 3:27=E2=80=AFAM T=C4=B3l Coosemans > wrote: > >>>> - Some fonts have been split into x11-fonts/-basic providing > Bold, > >>>> BoldItalic, Italic, and Regular, and x11-fonts/-extra > providing > >>>> additional styles. Only some of these have x11-fonts/ as a > >>>> metaport currently. This needs to be made consistent. I think it > >>>> would be best to drop the metaports and move x11-fonts/-basi= c > to > >>>> x11-fonts/. That way pkg install installs the common > >>>> styles for all fonts. I think that this would be the most > >>>> intuitive/convenient. > >>>> (I was hoping to use subpackages for this instead of extra ports.) > >>> > >>> The -basic/-extra structure was kept for minimal change. > >>> I agree with you that it would be better to be consistent with all > other > >>> noto ports. > >>> I could merge the following ports: > >>> - noto-sans-basic/-extra > >>> - noto-sans-mono-basic/-extra > >>> - noto-sans-symbols-basic/-extra > >>> - noto-serif-basic/-extra > >>> However, what should be noto-basic's dependencies after the merge? > >> > >> It's okay to keep the -extra ports. What I meant was to rename the > >> -basic ports so noto-sans-basic becomes noto-sans for example. > > > > I've prepared a patch [1] for the following changes: > > - Merge x11-fonts/noto-sans-{basic,extra} to x11-fonts/noto-sans > > - Merge x11-fonts/noto-sans-mono-{basic,extra} to > x11-fonts/noto-sans-mono > > - Merge x11-fonts/noto-sans-symbols-{basic,extra} to > > x11-fonts/noto-sans-symbols > > - Merge x11-fonts/noto-serif-{basic,extra} to x11-fonts/noto-serif > > - Update x11-fonts/noto-basic to depend on the 4 merged ports > > - Update x11-fonts/noto-extra by removing the 4 -extra ports from > > RUN_DEPENDS > > > > [1] https://people.freebsd.org/~sunpoet/patch/noto.txt > > Changes to x11-fonts/noto-sans and x11-fonts/noto-serif seem to be missin= g. > I've put x11-fonts/noto-sans and x11-fonts/noto-serif patch in https://people.freebsd.org/~sunpoet/patch/noto-part2.txt Not sure why it is missing in the previous patch. --000000000000c8d018061789bed0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Apr 19, 2024 at 7:05=E2=80=AFPM T= =C4=B3l Coosemans <tijl@freebsd.org> wrote:
On Tue, 9 Apr 2024 05:08:10 +08= 00 Po-Chuan Hsieh wrote:
> On Mon, Apr 1, 2024 at 5:46=E2=80=AFAM T=C4=B3l Coosemans <tijl@freebsd.org> wro= te:
>> On Mon, 1 Apr 2024 04:17:09 +0800 Po-Chuan Hsieh wrote:
>>> On Mon, Mar 25, 2024 at 3:27=E2=80=AFAM T=C4=B3l Coosemans <= ;tijl@freebsd.org= > wrote:
>>>> - Some fonts have been split into x11-fonts/<font>-b= asic providing Bold,
>>>>=C2=A0 =C2=A0BoldItalic, Italic, and Regular, and x11-fonts= /<font>-extra providing
>>>>=C2=A0 =C2=A0additional styles.=C2=A0 Only some of these ha= ve x11-fonts/<font> as a
>>>>=C2=A0 =C2=A0metaport currently.=C2=A0 This needs to be mad= e consistent.=C2=A0 I think it
>>>>=C2=A0 =C2=A0would be best to drop the metaports and move x= 11-fonts/<font>-basic to
>>>>=C2=A0 =C2=A0x11-fonts/<font>.=C2=A0 That way pkg ins= tall <font> installs the common
>>>>=C2=A0 =C2=A0styles for all fonts.=C2=A0 I think that this = would be the most
>>>>=C2=A0 =C2=A0intuitive/convenient.
>>>>=C2=A0 =C2=A0(I was hoping to use subpackages for this inst= ead of extra ports.)
>>>
>>> The -basic/-extra structure was kept for minimal change.
>>> I agree with you that it would be better to be consistent with= all other
>>> noto ports.
>>> I could merge the following ports:
>>> - noto-sans-basic/-extra
>>> - noto-sans-mono-basic/-extra
>>> - noto-sans-symbols-basic/-extra
>>> - noto-serif-basic/-extra
>>> However, what should be noto-basic's dependencies after th= e merge?
>>
>> It's okay to keep the -extra ports.=C2=A0 What I meant was to = rename the
>> -basic ports so noto-sans-basic becomes noto-sans for example.
>
> I've prepared a patch [1] for the following changes:
> - Merge x11-fonts/noto-sans-{basic,extra} to x11-fonts/noto-sans
> - Merge x11-fonts/noto-sans-mono-{basic,extra} to x11-fonts/noto-sans-= mono
> - Merge x11-fonts/noto-sans-symbols-{basic,extra} to
> x11-fonts/noto-sans-symbols
> - Merge x11-fonts/noto-serif-{basic,extra} to x11-fonts/noto-serif
> - Update x11-fonts/noto-basic to depend on the 4 merged ports
> - Update x11-fonts/noto-extra by removing the 4 -extra ports from
> RUN_DEPENDS
>
> [1]=C2=A0 https://people.freebsd.org/~sunpoet= /patch/noto.txt

Changes to x11-fonts/noto-sans and x11-fonts/noto-serif seem to be missing.=

I've put=C2=A0x11-fonts/noto-sans = and x11-fonts/noto-serif patch in https://people.freebsd.org/~s= unpoet/patch/noto-part2.txt
Not sure why it is missing in the= previous patch.
--000000000000c8d018061789bed0--