Re: git: 28472e9722d8 - main - Revert "x11-fonts/noto*: Restructure and update"

From: Tobias C. Berner <tcberner_at_gmail.com>
Date: Sat, 23 Mar 2024 15:38:03 UTC 
Am Samstag, 23. März 2024, 15:14:01 CET schrieb Gleb Popov:
> On Sat, Mar 23, 2024 at 5:04 PM Po-Chuan Hsieh <sunpoet@freebsd.org> wrote:
> > The branch main has been updated by sunpoet:
> > 
> > URL:
> > https://cgit.FreeBSD.org/ports/commit/?id=28472e9722d808739a4d690f6d803a2
> > b1b8f5f98
> > 
> > commit 28472e9722d808739a4d690f6d803a2b1b8f5f98
> > Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> > AuthorDate: 2024-03-23 14:01:07 +0000
> > Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> > CommitDate: 2024-03-23 14:01:07 +0000
> > 
> >     Revert "x11-fonts/noto*: Restructure and update"
> >     
> >     This reverts commit 3b128ff9f74b28ada2f475f0b816480b1550e5b8.
> 
> It is good manners to explain the reason for reverting when doing it.
> Even better to first talk to the original committer and ask him to the
> revert.

Moin moin 

I completely agree. Given that there has been a phabricator review open for 
two months, with you, sunpoet@ as reviewer, this is looking like poor 
judgement on your side. 

As arrowd@ points out, you should have commented on the reverted commit first, 
and elaborate your reasoning for a revert. 

Simply reverting the work of others may lead to fewer contributions. Please 
take this into consideration in the future.


mfg Tobias