Re: git: 450aafcba559 - main - textproc/tinyxml2: Update to 10.0.0

On Fri, Feb 23, 2024 at 5:27 AM <jbo@insane.engineer> wrote:

> On Wednesday, February 21st, 2024 at 16:20, Po-Chuan Hsieh
> <sunpoet@FreeBSD.org> wrote:
> > The branch main has been updated by sunpoet:
> >
> > URL:
> https://cgit.FreeBSD.org/ports/commit/?id=450aafcba559f95c94c5f195d83b5fe4fdc3748a
> >
> > commit 450aafcba559f95c94c5f195d83b5fe4fdc3748a
> > Author: Po-Chuan Hsieh sunpoet@FreeBSD.org
> >
> > AuthorDate: 2024-02-21 14:29:27 +0000
> > Commit: Po-Chuan Hsieh sunpoet@FreeBSD.org
> >
> > CommitDate: 2024-02-21 15:06:47 +0000
> >
> > textproc/tinyxml2: Update to 10.0.0
> >
> > - Convert to meson
> > - Fix 0c022f0fc854184d95ff3303049a063a39b1f551
> > - Bump PORTREVISION for package change
> > - Bump PORTREVISION of dependent ports for shlib change
> > - Remove duplicate PORTREVISION from math/linbox
> >
> > Changes: https://github.com/leethomason/tinyxml2/releases
> > https://github.com/leethomason/tinyxml2/commits/master
> > ---
>
> Hi,
>
> This commit is in my opinion problematic.
> The change in build system is causing consumers to no longer being able to
> use CMake's find_package() and
> the workaround that was put into place for some consumers is hacky at best
> and unacceptable at worst.
> find_package() is doing a lot more under the hood than just setting an
> LDFLAG.
>
> At least one consumer is still broken now (devel/gpds).


> See PR #277227
>
> Also, the commit message suggests that there was an update to 10.0.0 but
> the port was already at 10.0.0.


>
> Best regards,
> ~ jbo
>

Hello,

If you find anything missing in the patch, I could add it.
In my opinion, pkgconfig file is better than cmake script.
At least it is build system independent.

Speaking of devel/gpds, it just not on the radar when I checked the
dependent ports.
I prepared the 10.0.0 update last Dec and later I was unavailable until mid
Feb.
When I'm back, I checked again and there's no devel/gpds then.
Then it took me days to build and fix the ports.
ATM you added tinyxml2 dependence to devel/gpds.
Anyway, I'll check the list of dependent ports again before I commit .

Back to the fix, the answer is just 1 line
after GPDS_DEPENDENCY_TINYXML2_FINDPACKAGE which you added to Makefile on
Feb 18.
I'll commit the fix later.

from CMakeLists.txt:
option(GPDS_DEPENDENCY_TINYXML2_FINDPACKAGE "Whether to use find_package()
for the tinyxml2 dependency" OFF)
option(GPDS_DEPENDENCY_TINYXML2_PKGCONFIG   "Whether to use
find_package(PkgConfig) for the tinyxml2 dependency" OFF)

Regards,
sunpoet