From nobody Sat Mar 09 12:55:12 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TsNLv2Xhgz5D6xN for ; Sat, 9 Mar 2024 12:55:51 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TsNLv0HvGz4fMK for ; Sat, 9 Mar 2024 12:55:51 +0000 (UTC) (envelope-from sunpoet@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1709988951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FEMWbgbCX84nUzmWB1DcLwdOH4MMTa63Z6jojDhYJNA=; b=TZWmuV5Tswn48ROGAtdgnUlYghqEh+UWJWJrCPn7quSRvkWT8trKOK/VQMNn5HYH++OKiY PVFNh1b6GKe8vrCTOoEdBVeYjNekgfLtmYsxY5xAsavKqoLOocMwOPw5+mPLa08j1EJzu+ DTjW95IAEQa7ty6Eu6FtIfmRVUgba2waiGsm/MTdcNKGqtxOHfTKvDY9McRHiuEISj4ZnC DXDrPnIqHaVJySajqBvuOrKgMA1/MYnb9Uky/zDt0Zw6b438/ofqnM6k0DVFJg+W7aJ0vu IKDEZS/3+N+c2prCQLYLwQT7ilE7F1pIqofpLm5EogmtWsqJjS1Dqx9egoQRPQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1709988951; a=rsa-sha256; cv=none; b=Mu42hDRliB+e/LeLqDUwAcxalCp0DjlsubskEFnyCVVIPbXuviDAWHYHC/sdENkTqEvoYd 6/2xf/NFFak1Y+LjLqgfNjAzbnX+y4GfOMgXmLoXWt4zhgzl7SMMNSa4Ku1q3j4X9hb9vy xJ3WUkdiW0RYgko3pc1CTfUFV6FuCk3tPtfsz2BNsIFDh/wzmGxUIPmCVDkvWKW3fMg1y/ W0CkfROZWJQQapM6czczRyl2xrP3Vc628x/X7bpwzqFul5ldeRztgWkarAIT8QpASpk+3B GnAPaEtXseGM2089Jnuu11Z8tIbRwxFgD+TNClbWsS92mCoCDAzWhUSbRn9HFQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1709988951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FEMWbgbCX84nUzmWB1DcLwdOH4MMTa63Z6jojDhYJNA=; b=l8rE2eJ7gUyLVaGi3P3LzjXgH2notHSJJHslLAYPPTKe1qkvpmk6aeWppeGde4aywagzsD r7SpOT4nCJkYBHGIqKz+QctI+1gs6cmpmJnm/IiYeFWCCzuy1xFOCnF6/f3udHGxz1AHOe ylz6Y0bO/Oza1eyIZJ5pgC1bMz789plQ6iJXrFWMDIsx0AOmB06xCx2c+wkQJZKcwOddvf 2X+FQ9FyXIFczhxaQYgXUkA4NA2/z0BLVnRyDG202GKNHJtLlxizsV7+1jMButEl+hBeHT pPvxKh1Pf2RksUrmr85gVUNUDVCD5AyvJwaaYyuKVqBFuBLNF1V40xSW5EmWnA== Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id 4TsNLt6ty6z13V7 for ; Sat, 9 Mar 2024 12:55:50 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-56847d9b002so41631a12.1 for ; Sat, 09 Mar 2024 04:55:50 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUmPYaRnVSgOAk4vfFVLYlk6w6vDCe+AqSfpxQw/eswcoEFtM/VPdZtjYfvIlatKnl57zIvtpcmXAjkRMtIrL3Y3nMUWH0j/32nsMFpk0xF87kL X-Gm-Message-State: AOJu0YwNV0UtKjTIgPn4qMLN3XqwnW0yHkGpJdrd7bdJbiHqcTkfiwE6 tmPDHx0fvj9JRHJjPl3k9NKR0ulx0NCuvas4V3JThiw7qhV7T8f7491lRbe/6lX6alWGRcxcrRo 3sXa9B3i2YG6J1KaVVrVLeDFwBHsRkZ/HdlavFA== X-Google-Smtp-Source: AGHT+IFhtUbO0mJF4xrpfZJ3ijumhTwnjF+gFFMunvnurRb/ytJz2mKSgR7ShqKOfB4uMypJ+6t12tr/CvTNcnnF+S4= X-Received: by 2002:a50:9b41:0:b0:568:3362:ccdc with SMTP id a1-20020a509b41000000b005683362ccdcmr1259091edj.16.1709988949752; Sat, 09 Mar 2024 04:55:49 -0800 (PST) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202402211520.41LFK8mS022399@gitrepo.freebsd.org> In-Reply-To: From: Po-Chuan Hsieh Date: Sat, 9 Mar 2024 20:55:12 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 450aafcba559 - main - textproc/tinyxml2: Update to 10.0.0 To: jbo@insane.engineer Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000eba1dc061339d316" --000000000000eba1dc061339d316 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Feb 23, 2024 at 5:27=E2=80=AFAM wrote: > On Wednesday, February 21st, 2024 at 16:20, Po-Chuan Hsieh > wrote: > > The branch main has been updated by sunpoet: > > > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=3D450aafcba559f95c94c5f195d83b5= fe4fdc3748a > > > > commit 450aafcba559f95c94c5f195d83b5fe4fdc3748a > > Author: Po-Chuan Hsieh sunpoet@FreeBSD.org > > > > AuthorDate: 2024-02-21 14:29:27 +0000 > > Commit: Po-Chuan Hsieh sunpoet@FreeBSD.org > > > > CommitDate: 2024-02-21 15:06:47 +0000 > > > > textproc/tinyxml2: Update to 10.0.0 > > > > - Convert to meson > > - Fix 0c022f0fc854184d95ff3303049a063a39b1f551 > > - Bump PORTREVISION for package change > > - Bump PORTREVISION of dependent ports for shlib change > > - Remove duplicate PORTREVISION from math/linbox > > > > Changes: https://github.com/leethomason/tinyxml2/releases > > https://github.com/leethomason/tinyxml2/commits/master > > --- > > Hi, > > This commit is in my opinion problematic. > The change in build system is causing consumers to no longer being able t= o > use CMake's find_package() and > the workaround that was put into place for some consumers is hacky at bes= t > and unacceptable at worst. > find_package() is doing a lot more under the hood than just setting an > LDFLAG. > > At least one consumer is still broken now (devel/gpds). > See PR #277227 > > Also, the commit message suggests that there was an update to 10.0.0 but > the port was already at 10.0.0. > > Best regards, > ~ jbo > Hello, If you find anything missing in the patch, I could add it. In my opinion, pkgconfig file is better than cmake script. At least it is build system independent. Speaking of devel/gpds, it just not on the radar when I checked the dependent ports. I prepared the 10.0.0 update last Dec and later I was unavailable until mid Feb. When I'm back, I checked again and there's no devel/gpds then. Then it took me days to build and fix the ports. ATM you added tinyxml2 dependence to devel/gpds. Anyway, I'll check the list of dependent ports again before I commit . Back to the fix, the answer is just 1 line after GPDS_DEPENDENCY_TINYXML2_FINDPACKAGE which you added to Makefile on Feb 18. I'll commit the fix later. from CMakeLists.txt: option(GPDS_DEPENDENCY_TINYXML2_FINDPACKAGE "Whether to use find_package() for the tinyxml2 dependency" OFF) option(GPDS_DEPENDENCY_TINYXML2_PKGCONFIG "Whether to use find_package(PkgConfig) for the tinyxml2 dependency" OFF) Regards, sunpoet --000000000000eba1dc061339d316 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Feb 23, 2024 at 5:27=E2=80=AFAM &= lt;jbo@insane.engineer> wrote:
On Wednesday, February 21st, 2= 024 at 16:20, Po-Chuan Hsieh <sunpoet@FreeBSD.org> wrote:
> The branch main has been updated by sunpoet:
>
> URL: https:= //cgit.FreeBSD.org/ports/commit/?id=3D450aafcba559f95c94c5f195d83b5fe4fdc37= 48a
>
> commit 450aafcba559f95c94c5f195d83b5fe4fdc3748a
> Author: Po-Chuan Hsieh sunpoet@FreeBSD.org
>
> AuthorDate: 2024-02-21 14:29:27 +0000
> Commit: Po-Chuan Hsieh sunpoet@FreeBSD.org
>
> CommitDate: 2024-02-21 15:06:47 +0000
>
> textproc/tinyxml2: Update to 10.0.0
>
> - Convert to meson
> - Fix 0c022f0fc854184d95ff3303049a063a39b1f551
> - Bump PORTREVISION for package change
> - Bump PORTREVISION of dependent ports for shlib change
> - Remove duplicate PORTREVISION from math/linbox
>
> Changes: https://github.com/leethomason/tinyxml= 2/releases
> https://github.com/leethomason/tinyxml2/c= ommits/master
> ---

Hi,

This commit is in my opinion problematic.
The change in build system is causing consumers to no longer being able to = use CMake's find_package() and
the workaround that was put into place for some consumers is hacky at best = and unacceptable at worst.
find_package() is doing a lot more under the hood than just setting an LDFL= AG.

At least one consumer is still broken now (devel/gpds).=C2=A0<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">
See PR #277227

Also, the commit message suggests that there was an update to 10.0.0 but th= e port was already at 10.0.0.=C2=A0


Best regards,
~ jbo

Hello,

I= f you find anything missing in the patch, I could add it.
In my o= pinion, pkgconfig file=C2=A0is better than cmake script.
At least= it is build system independent.

Speaking of devel= /gpds, it just not on the radar when I checked the dependent ports.
I prepared the 10.0.0 update last Dec and later I was unavailable until = mid Feb.
When I'm back, I checked again and there's no de= vel/gpds then.
Then it took me days to build and fix the ports.
ATM you added tinyxml2 dependence to devel/gpds.
Anyway,= I'll check the list of dependent ports again before I commit .

Back to the fix, the answer is just 1 line after=C2=A0GPD= S_DEPENDENCY_TINYXML2_FINDPACKAGE which you added to Makefile on Feb 18.
I'll commit the fix later.

=
from CMakeLists.txt:
option(GPDS_DEPENDENCY_TINYXML2_F= INDPACKAGE "Whether to use find_package() for the tinyxml2 dependency&= quot; OFF)
option(GPDS_DEPENDENCY_TINYXML2_PKGCONFIG =C2=A0 "Whethe= r to use find_package(PkgConfig) for the tinyxml2 dependency" OFF)

Regards,
sunpoet
--000000000000eba1dc061339d316--