Re: git: b430a140c818 - main - net-im/purple-gowhatsapp: add WhatsApp plugin for libpurple

From: Mikhail T. <mi+t_at_virtual-estates.net>
Date: Sun, 21 Jan 2024 19:16:19 UTC
21.01.24 13:47, Daniel Engberg:
> While we all do mistakes I'm asking because it's broken and it's 
> likely not going to be fixed any time soon.
I wonder, how you estimate this likelihood...
> In reality it adds noise (which we already have enough of) on lists, 
> Poudriere builds (because by default we build all ports) takes more 
> time producing nothing, more time for people to review error logs and 
> so on.
All of this could be silenced with BROKEN, no?
> It boils down to my time > your time which usually don't translate 
> well in team efforts.

No, I don't see it boiling down to that. To me it seems like a simple 
overreaction. So, a newly-added port is broken -- what's the big deal? 
You'd be right expecting the committer to  examine the error-log 
himself... It is just computers working -- so the humans, present 
company included, can do fun things.

> Instead of doing the same thing again use Poudriere as you're by know 
> well aware that it "should" be used and you have been "warned".
On the contrary -- as long as the "should" remains quoted, I intend to 
do the same thing: /commit, what I sincerely believe is working code/. 
Mat is already convinced, I *must* follow, what you acknowledge is just 
a recommendation -- on the strength of his creating a rule out of void. 
Rights not exercised are rights lost, and all that :-)
> I would also say that you'd be better off in general asking for 
> suggestions by creating a PR and or use Phab(ricator) due to quality 
> reasons (to mention it again, team effort).

Believe it or not, I did ask for suggestions before committing -- 
sending the shar of the would be port to the committers of <go.mk> 
(because go@FreeBSD.mk is blocked to non-subscribers). Having received 
no immediate replies, I figured, I'll see, what Poudriere would say -- 
still don't understand the scale of the blowback...

    -mi