Re: git: 981929d361d7 - main - audio/pulseaudio-module-sndio: Fix an error on loading

On Thu, 29 Aug 2024 22:29:59 +0200 Nicola Vitale wrote:
> I don't see the point of hard-coding those values. If pulseaudio is 
> updated, you still have to change those values in any case and bump 
> PORTREVISION as well, right?

Inverse the logic. You have to bump PORTREVISION and rebuild
pulseaudio-module-sndio when pulseaudio is updated anyway,
so you may amend these values along with PORTREVISION.

Better solution, as suggested by Gleb, is to use common variables from
the master port. This is a common practice when plugins are installed from
separate ports.

Cheers,
Max



> 
> On 29/08/24 17:18, Max Brazhnikov wrote:
> > On Thu, 29 Aug 2024 16:47:43 +0300 Gleb Popov wrote:
> >> On Thu, Aug 29, 2024 at 4:00 PM Nicola Vitale <nivit@freebsd.org> wrote:
> >>>
> >>> +PULSE_MODDIR!= ${LOCALBASE}/bin/pkg-config --variable=modlibexecdir libpulse
> >>> +PULSE_VERSION!=        ${LOCALBASE}/bin/pkg-config --modversion libpulse
> >> [...]
> > It seems the port has to be rebuilt whenever pulseaudio is updated. In this case
> > I'd just fixed PULSE_MODDIR and PULSE_VERSION to the required values.
> 
> --
> Nicola Vitale
>