From nobody Fri Aug 30 09:05:26 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WwC0r4kBkz52Qpd; Fri, 30 Aug 2024 09:05:32 +0000 (UTC) (envelope-from makc.freebsd@gmail.com) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WwC0q6rT0z4W3B; Fri, 30 Aug 2024 09:05:31 +0000 (UTC) (envelope-from makc.freebsd@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of makc.freebsd@gmail.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=makc.freebsd@gmail.com Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-5334b0e1a8eso2045125e87.0; Fri, 30 Aug 2024 02:05:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725008730; x=1725613530; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=80x3+mjwrayecc0N1l3/tUri8zMiXl4TpVays9T2gJY=; b=j2yH/Y0kwlSrX6xc/9Kjlh/Oj2FBSTkoPoawKwmvKvZdCSZFaQXUaplOqlhAwsjfSR 317o9E4VL3ko0nrxFw7pZgD3YymSN7JcNFH18D+vMg+G29o5kr+E6imfyTc8yNLXx0kP tbcjtfKld03KMPs/TOvWlNwtjOwxbCbvGevfbtJqUirknUbg1W0ALFs6xj9I8M4uwFiP 7NIPqKKOUlb0TledfPQRP22XHTezzxpKwTfB6Q5r+GiSyfh4wa2qWqA5vhCPnH7IOST6 r+xYVyueSGalecFOUUXCkWywob/xorclmz33uAT6vOdjO5yC6yCIWD8Py1H/qW1t+EY6 qsvw== X-Forwarded-Encrypted: i=1; AJvYcCVFI9w3cEYVCI/xDnf99t7OtDn75Za3faBEPiTDpa5ANrbM7RQoPFImOuy5HycGDoKI+1SGB2c=@freebsd.org, AJvYcCWrvtQXDl8w4ExN7+wjRZ3b1d5YsYej667uFzQ+vYZhuIo+phn7KamepBjXghxiuORNSeQbLib6m3kZ3zNLqgsOuqBMttO0@freebsd.org, AJvYcCXNtACTi426LqEhlD4IHs2jPiVPCd14IwebCAoJrl+23o3xB0Hc3x9yN3Lm8zymFRVqVyuMlEIUBavnmr/+EubgiTYrPXmWkA==@freebsd.org X-Gm-Message-State: AOJu0YxwrSCR75b5L21nnJvVoS/IdFz1S19VXMjwfm/M4jnxKRfFqGQQ 0mPOI2m5H69U0l7PRDEVhTsgOgif54qKYuLPzCj1BnnxQc/mJT1jRdW5NBzg X-Google-Smtp-Source: AGHT+IGusgNMQRFlxeLyrvAA0Neue4xQboKHGyKHx6dxKRRhEULOgDS8EQi+bAoR8pf3sEwa5hs9MA== X-Received: by 2002:a05:6512:3e02:b0:533:45b5:6609 with SMTP id 2adb3069b0e04-53546b05552mr1103456e87.17.1725008729301; Fri, 30 Aug 2024 02:05:29 -0700 (PDT) Received: from mercury.localnet ([83.149.244.82]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5354079babdsm496626e87.50.2024.08.30.02.05.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Aug 2024 02:05:28 -0700 (PDT) From: Max Brazhnikov To: Nicola Vitale , Gleb Popov , Nicola Vitale Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 981929d361d7 - main - audio/pulseaudio-module-sndio: Fix an error on loading Date: Fri, 30 Aug 2024 12:05:26 +0300 Message-ID: <2816150.iL6vRArjjl@mercury> In-Reply-To: References: <202408291300.47TD0MLL067590@gitrepo.freebsd.org> <2397939.bDOn7JOVgO@mercury> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.31 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-0.99)[-0.985]; NEURAL_HAM_SHORT(-0.92)[-0.922]; MID_RHS_NOT_FQDN(0.50)[]; FORGED_SENDER(0.30)[makc@freebsd.org,makcfreebsd@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_TO(0.00)[freebsd.org,gmail.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TAGGED_FROM(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; RCVD_IN_DNSWL_NONE(0.00)[209.85.167.45:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[makc@freebsd.org,makcfreebsd@gmail.com]; MISSING_XM_UA(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-ports-all@freebsd.org,dev-commits-ports-main@freebsd.org]; TAGGED_RCPT(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.167.45:from]; RCPT_COUNT_FIVE(0.00)[6] X-Rspamd-Queue-Id: 4WwC0q6rT0z4W3B On Thu, 29 Aug 2024 22:29:59 +0200 Nicola Vitale wrote: > I don't see the point of hard-coding those values. If pulseaudio is=20 > updated, you still have to change those values in any case and bump=20 > PORTREVISION as well, right? Inverse the logic. You have to bump PORTREVISION and rebuild pulseaudio-module-sndio when pulseaudio is updated anyway, so you may amend these values along with PORTREVISION. Better solution, as suggested by Gleb, is to use common variables from the master port. This is a common practice when plugins are installed from separate ports. Cheers, Max >=20 > On 29/08/24 17:18, Max Brazhnikov wrote: > > On Thu, 29 Aug 2024 16:47:43 +0300 Gleb Popov wrote: > >> On Thu, Aug 29, 2024 at 4:00=E2=80=AFPM Nicola Vitale wrote: > >>> > >>> +PULSE_MODDIR!=3D ${LOCALBASE}/bin/pkg-config --variable=3Dmodlibexec= dir libpulse > >>> +PULSE_VERSION!=3D ${LOCALBASE}/bin/pkg-config --modversion li= bpulse > >> [...] > > It seems the port has to be rebuilt whenever pulseaudio is updated. In = this case > > I'd just fixed PULSE_MODDIR and PULSE_VERSION to the required values. >=20 > -- > Nicola Vitale >=20