Re: git: ccc21de09381 - main - devel/binutils: Add devel/elfutils dependency options

In message <86o75bpf9y.fsf@phe.ftfl.ca>, Joseph Mingrone writes:
> --=-=-=
> Content-Type: text/plain
>
> On Thu, 2024-08-29 at 05:42, Cy Schubert <Cy.Schubert@cschubert.com> wrote:
>
> > In message <2ypgfpzxn7m4jzzbacyvrlw7htj5iyg7zwdb7mjcbknfjr3ee4@ipqdfyay3s4m
> >
> > , M
> > athieu Arnold writes:
>
>
> >> --t2cwj7kshsfy5exo
> >> Content-Type: text/plain; charset=us-ascii
> >> Content-Disposition: inline
> >> Content-Transfer-Encoding: quoted-printable
>
> >> On Wed, Aug 28, 2024 at 11:04:39AM GMT, Cy Schubert wrote:
> >> > In message <CALH631nFVYyks4DB+T8+C8r5Y6GHT4Su8mzhDaJ8BQ1=3DPMVZPA@mail.g
> m=
> >> ail.c
> >> > om>
> >> > , Gleb Popov writes:
> >> > > On Wed, Aug 28, 2024 at 7:03=3DE2=3D80=3DAFPM Cy Schubert <cy@freebsd.
> o=
> >> rg> wrote:
>
> >> > > > +# In case devel/elfutils has been previously installed.
> >> > > > +.if ${PORT_OPTIONS:MELFU_AUTO} && exists(${LOCALBASE}/lib/libdebugi
> n=
> >> fod.=3D
> >> > > so)
> >> > > > +LIB_DEPENDS+=3D3D  libdebuginfod.so:devel/elfutils
> >> > > > +.endif
>
> >> > > Hmm, this looks strange to me. LIB_DEPENDS is used to pull in
> >> > > libraries that are missing, but then the "exists" condition will
> >> > > always be false.
> >> >=20
> >> > Correct. The condition will always be false when building with poudriere
> =
> >> =20
> >> > but for those building the port by hand, and have manually installed=20
> >> > devel/elfutils prior to building and installing manually the condition w
> i=
> >> ll=20
> >> > then be true.
> >> >=20
> >> > Much committers' dismay some users don't use binary packages, you and I 
> a=
> >> s=20
> >> > committers prefer people use binary packages. But unfortunately this is 
> n=
> >> ot=20
> >> > always the case. The PR was submitted by a person who builds his ports b
> y=
> >> =20
> >> > hand.
>
> >> It would be better to disable the finding of libdebuginfod in LOCALBASE,
> >> so that everyone has the same binutils, and nobody gets a possibly
> >> different behavior.
>
> > In other words, just let it auto-detect?
>
> Hi Cy,
>
> It looks like there is a --with-debuginfod configure option.  Could we
> remove the OPTIONS_RADIO and make it a single ELFU knob?  Something like
> below would make detection of the library and the dependency on
> devel/elfutils deterministic.
>
> ELFU_DESC=		Depend on devel/elfutils
> ELFU_CONFIGURE_WITH=	debuginfod
> ELFU_LIB_DEPENDS=	libdebuginfod.so:devel/elfutils

I suppose but this would mean users who have depended upon the old behavior 
would need to actually specify it. I was trying to avoid changing any 
implied behavior.

This of course would necessitate a PORTREVISION bump because even though 
this change doesn't affect poudriere builds it will affect users who build 
binutils manually.

Consider it done.


-- 
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  https://FreeBSD.org
NTP:           <cy@nwtime.org>    Web:  https://nwtime.org

			e^(i*pi)+1=0