From nobody Thu Aug 29 14:44:34 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvkZY2zydz5PYM4; Thu, 29 Aug 2024 14:44:37 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta001.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvkZY0b3Xz4lfH; Thu, 29 Aug 2024 14:44:37 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4003a.ext.cloudfilter.net ([10.228.9.183]) by cmsmtp with ESMTPS id jdA0sLtxV9TOUjgO4sMyYx; Thu, 29 Aug 2024 14:44:36 +0000 Received: from spqr.komquats.com ([70.66.152.170]) by cmsmtp with ESMTPSA id jgO2sONepE0IVjgO3scPsR; Thu, 29 Aug 2024 14:44:36 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=cI9DsUeN c=1 sm=1 tr=0 ts=66d08954 a=y8EK/9tc/U6QY+pUhnbtgQ==:117 a=y8EK/9tc/U6QY+pUhnbtgQ==:17 a=kj9zAlcOel0A:10 a=yoJbH4e0A30A:10 a=jaa8EuXyAAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=-0Gt3xalBlSaANVXLxMA:9 a=CjuIK1q_8ugA:10 a=PL_DULBQHCqb1WPX_gWP:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 41D24F1A; Thu, 29 Aug 2024 07:44:34 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 0F9053BB; Thu, 29 Aug 2024 07:44:34 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Joseph Mingrone cc: Cy Schubert , Mathieu Arnold , Gleb Popov , Cy Schubert , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: ccc21de09381 - main - devel/binutils: Add devel/elfutils dependency options In-reply-to: <86o75bpf9y.fsf@phe.ftfl.ca> References: <202408281603.47SG35Q9035605@gitrepo.freebsd.org> <20240828180439.22B0730E@slippy.cwsent.com> <2ypgfpzxn7m4jzzbacyvrlw7htj5iyg7zwdb7mjcbknfjr3ee4@ipqdfyay3s4m> <20240829124237.6E277483@slippy.cwsent.com> <86o75bpf9y.fsf@phe.ftfl.ca> Comments: In-reply-to Joseph Mingrone message dated "Thu, 29 Aug 2024 11:36:25 -0300." List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 29 Aug 2024 07:44:34 -0700 Message-Id: <20240829144434.0F9053BB@slippy.cwsent.com> X-CMAE-Envelope: MS4xfMe5fI/f3VL0k3GKPjjp9E5j7xj5wDgoQHoqyAXzZs5Fn0vpm3dq5CD2I3OhimvJ2kRbblrW8UCpiimZ2zgby4iI8JO6BA+APT2ticYTMKiSVLlha8q/ lqRL+3RZlLJLxIlxZ3ajgZ3VmPwGiCfXsR4srG4zQ4s727bI5SJI+JENttTP4DOtPtIFZ8dAxmp6euMKGytg3u58WBqv0XVbaqHUc2D6clf3uYlWLJYYZ3HQ mR+NcZNGqyWN28OY5/sGqOEmugbSVXqun6U1eskruiuRP/JIP3qLrO0NX1L7/0CuEt4J/hxcpH8kEfEwds8ydnY3DCmukiEhKXwRrkac8tAN9Q2rDtnD1C/q GdkibGTVHKlOyKFembzl/FomU82Wi2aI90gjcEAXP85GPwAekqq2D9RMy9nvcsOxhf0xu1Ko X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Queue-Id: 4WvkZY0b3Xz4lfH In message <86o75bpf9y.fsf@phe.ftfl.ca>, Joseph Mingrone writes: > --=-=-= > Content-Type: text/plain > > On Thu, 2024-08-29 at 05:42, Cy Schubert wrote: > > > In message <2ypgfpzxn7m4jzzbacyvrlw7htj5iyg7zwdb7mjcbknfjr3ee4@ipqdfyay3s4m > > > > , M > > athieu Arnold writes: > > > >> --t2cwj7kshsfy5exo > >> Content-Type: text/plain; charset=us-ascii > >> Content-Disposition: inline > >> Content-Transfer-Encoding: quoted-printable > > >> On Wed, Aug 28, 2024 at 11:04:39AM GMT, Cy Schubert wrote: > >> > In message m= > >> ail.c > >> > om> > >> > , Gleb Popov writes: > >> > > On Wed, Aug 28, 2024 at 7:03=3DE2=3D80=3DAFPM Cy Schubert o= > >> rg> wrote: > > >> > > > +# In case devel/elfutils has been previously installed. > >> > > > +.if ${PORT_OPTIONS:MELFU_AUTO} && exists(${LOCALBASE}/lib/libdebugi > n= > >> fod.=3D > >> > > so) > >> > > > +LIB_DEPENDS+=3D3D libdebuginfod.so:devel/elfutils > >> > > > +.endif > > >> > > Hmm, this looks strange to me. LIB_DEPENDS is used to pull in > >> > > libraries that are missing, but then the "exists" condition will > >> > > always be false. > >> >=20 > >> > Correct. The condition will always be false when building with poudriere > = > >> =20 > >> > but for those building the port by hand, and have manually installed=20 > >> > devel/elfutils prior to building and installing manually the condition w > i= > >> ll=20 > >> > then be true. > >> >=20 > >> > Much committers' dismay some users don't use binary packages, you and I > a= > >> s=20 > >> > committers prefer people use binary packages. But unfortunately this is > n= > >> ot=20 > >> > always the case. The PR was submitted by a person who builds his ports b > y= > >> =20 > >> > hand. > > >> It would be better to disable the finding of libdebuginfod in LOCALBASE, > >> so that everyone has the same binutils, and nobody gets a possibly > >> different behavior. > > > In other words, just let it auto-detect? > > Hi Cy, > > It looks like there is a --with-debuginfod configure option. Could we > remove the OPTIONS_RADIO and make it a single ELFU knob? Something like > below would make detection of the library and the dependency on > devel/elfutils deterministic. > > ELFU_DESC= Depend on devel/elfutils > ELFU_CONFIGURE_WITH= debuginfod > ELFU_LIB_DEPENDS= libdebuginfod.so:devel/elfutils I suppose but this would mean users who have depended upon the old behavior would need to actually specify it. I was trying to avoid changing any implied behavior. This of course would necessitate a PORTREVISION bump because even though this change doesn't affect poudriere builds it will affect users who build binutils manually. Consider it done. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0