Re: git: d69b20995dec - main - security/softether5: add DEBUG option

On Tue, Mar 07, 2023 at 09:16:06AM +0900, Koichiro Iwao wrote:
> On Mon, Mar 06, 2023 at 08:55:01PM +0100, Mathieu Arnold wrote:
> > > ...
> > > WITH_DEBUG is a global user facing knob, it must never be activated
> > > via options.
> > 
> > Sorry, bad wording, it must never be set in any Makefile, wether
> > options, flavor, or whatever.  It is not a port setting, that one sets
> > in a Makefile, it is a user setting that one sets in make.conf.
> 
> Understood. Other ports which have DEBUG option mostly don't set
> WITH_DEBUG but just add something like --enable-debug to *_ARGS. This
> kind of DEBUG options are allowed, right (ex. lang/php8[012])?

No, it's not, PHP ports do it wrong.  Correct way is:

  .if defined(WITH_DEBUG)
  CONFIGURE_ARGS+=	--enable-debug
  .endif

./danfe