From nobody Tue Mar 07 06:33:06 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PW5H71qF8z3wyd1; Tue, 7 Mar 2023 06:33:07 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PW5H71L5vz4J0r; Tue, 7 Mar 2023 06:33:07 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678170787; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0F7lTlWxZuLP96nx1hJyFEIqZZeZfipWPINvAnwFIAU=; b=B8jhEk/FoaAV0IKwQPhrw939LcmyIpJ6QxgPZTEmHrySOXTTk4QTM+rYmdk4tN6ZUiYCoh z6rujPqUY4gKd4lta6E+HVoUntxLSWOeSyEXyRHhxOIW/UDcyL275vuk4YSxS5ykMS7SjD iLT+58bv51Ol5ghy074HHvs1eM8vLn4ofJelYbEdLaJIb5L8LfahzqFfvkr6c7bn7LGT20 Oq4/sqpnoPx7675/DpQXuHEaIBYN1vQ7Su5solOhVKJ6BeAKH6jm/WENnC7tO5z4bw7Cks l2dsVvgdwGFtHJTBJ6A7ioBJhmUUGVIZ0ZQY7KZ4lq6b/SOYGuBwXkQsQEUZQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678170787; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0F7lTlWxZuLP96nx1hJyFEIqZZeZfipWPINvAnwFIAU=; b=y4UEBk9n9KNdqecGV/L5PQL0+K+/hND9V5f7YknsDapPnuZPVS4Gzd4jGRknasWq11nrVO PyuUgEJ+7mq1ehlZZP1kkHAi/yWx+9Ij4H8ENHWbzzyqlKE4Tw+iGZLuP1ivQh7rNqMeNM 7uA3E2h6zxMdql57oiqhhd95hLdGlmBX2LpSf08E1Hso1ttirq6HG3VkzApGOhrD3+/W6q XQPwihfUdjBTN7iHO4eOS8G6YmZNZCCY7sEz3oNfcm5TK+SsK8UcAgMRUZqsM4awexB839 bhxoPAyoZlbyEGOph0J4TMAM44nC2ZKqMjc1wCzs6HJTm82N19sUGoQQH1PLkA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1678170787; a=rsa-sha256; cv=none; b=y0gol4XO4Zcy2S2BKY3BPaH1/UDk2x2qgmeGnP7Utc9I00gacQ7cgaOA8r/Q7AD85RJ9Ho kZVI89hqiFIoEZP/wYyyed8kThrjsDdMpRsD5XdGLL5R6ATOxoLpzz2SHj5afMd/CqHOiT F45HGuM4ixAAMC5dswrrKpLLMZutzHVM/mnbM+6XIyUbu6NuF1NJ4fL5CSsdfJQ1vJz2L6 mFdLtIlFiW4rLuAfBdkI3cK14D344W7nf63/JjLkWMOkKzK1kYE9faLlIhL/Bwrd68dGXs a3dWT//TesjK1PMb0s6QhHfOWVr7QYWOaDSJ78FW3TpdJ0gPtpd7iw5nmarKjQ== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 011511B08F; Tue, 7 Mar 2023 06:33:06 +0000 (UTC) Date: Tue, 7 Mar 2023 06:33:06 +0000 From: Alexey Dokuchaev To: Koichiro Iwao Cc: Mathieu Arnold , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: d69b20995dec - main - security/softether5: add DEBUG option Message-ID: References: <202303060432.3264Wbtc041269@gitrepo.freebsd.org> <20230306142506.kckwmjxqgyv6usry@icepick.vmeta.jp> <20230306195254.n3gxqbchj5voyypw@aching.in.mat.cc> <20230306195501.ithqt45oxm2z2mgn@aching.in.mat.cc> <20230307001606.j7vhypsfrohkz62s@icepick.vmeta.jp> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230307001606.j7vhypsfrohkz62s@icepick.vmeta.jp> X-ThisMailContainsUnwantedMimeParts: N On Tue, Mar 07, 2023 at 09:16:06AM +0900, Koichiro Iwao wrote: > On Mon, Mar 06, 2023 at 08:55:01PM +0100, Mathieu Arnold wrote: > > > ... > > > WITH_DEBUG is a global user facing knob, it must never be activated > > > via options. > > > > Sorry, bad wording, it must never be set in any Makefile, wether > > options, flavor, or whatever. It is not a port setting, that one sets > > in a Makefile, it is a user setting that one sets in make.conf. > > Understood. Other ports which have DEBUG option mostly don't set > WITH_DEBUG but just add something like --enable-debug to *_ARGS. This > kind of DEBUG options are allowed, right (ex. lang/php8[012])? No, it's not, PHP ports do it wrong. Correct way is: .if defined(WITH_DEBUG) CONFIGURE_ARGS+= --enable-debug .endif ./danfe