Re: git: 9c24afe97b74 - main - sysutils/sispmctl: New port to manage EnerGenie and Gembird USB controlled power strips
Date: Sat, 29 Jul 2023 22:35:13 UTC
Hi Daniel, Sorry for this terrible commit. On 29/07/23 22:25, Daniel Engberg wrote: > Hi, > > There seems to be some issues as it fails to build, patches don't apply. > ===> FAILED to apply cleanly FreeBSD patch(es) patch-src_web2_index.html I disable the webserver capability of the tool so all patches related to www can be removed just like plist entries. dos2unix is also not required anymore. > A few other things that I noticed, > Why is USES= autoreconf needed? Agree. removed > COMMENT should be fixed Fixed > Consider using DISTVERSION instead of PORTVERSION as recommended by > Porters Handbook > Do we really need to install a static library? Not really, so I disable the static libraries build > Consider using framework variables for pkg-plist, %%PORTDOCS%%%%DOCSDIR%% > Missing rc.d script for webserver component (disable it)? I disable the webserver capability... > > Best regards, > Daniel Regards Rodrigo