From nobody Sat Jul 29 22:35:13 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RCzrP23nzz4pkFk; Sat, 29 Jul 2023 22:36:37 +0000 (UTC) (envelope-from rodrigo@FreeBSD.org) Received: from smtp.osorio.me (mvd.osorio.me [5.196.94.126]) by mx1.freebsd.org (Postfix) with ESMTP id 4RCzrN4ZwRz4QJ3; Sat, 29 Jul 2023 22:36:36 +0000 (UTC) (envelope-from rodrigo@FreeBSD.org) Authentication-Results: mx1.freebsd.org; none Received: from [192.168.1.56] (lfbn-idf1-1-505-131.w86-242.abo.wanadoo.fr [86.242.206.131]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by smtp.osorio.me (Postfix) with ESMTPSA id C8DE81B2888; Sat, 29 Jul 2023 22:36:28 +0000 (UTC) Message-ID: <80629414-93ef-96c4-0742-df87795ecbda@FreeBSD.org> Date: Sun, 30 Jul 2023 00:35:13 +0200 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Reply-To: rodrigo@FreeBSD.org Subject: Re: git: 9c24afe97b74 - main - sysutils/sispmctl: New port to manage EnerGenie and Gembird USB controlled power strips Content-Language: en-US, fr, es-AR To: Daniel Engberg Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <202307291947.36TJlX9a006964@gitrepo.freebsd.org> <2841fe66cdc354b102b25e168bc81f96@pyret.net> From: Rodrigo Osorio In-Reply-To: <2841fe66cdc354b102b25e168bc81f96@pyret.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4RCzrN4ZwRz4QJ3 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16276, ipnet:5.196.0.0/16, country:FR] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated Hi Daniel, Sorry for this terrible commit. On 29/07/23 22:25, Daniel Engberg wrote: > Hi, > > There seems to be some issues as it fails to build, patches don't apply. > ===> FAILED to apply cleanly FreeBSD patch(es) patch-src_web2_index.html I disable the webserver capability of the tool so all patches related to www can be removed just like plist entries. dos2unix is also not required anymore. > A few other things that I noticed, > Why is USES= autoreconf needed? Agree. removed > COMMENT should be fixed Fixed > Consider using DISTVERSION instead of PORTVERSION as recommended by > Porters Handbook > Do we really need to install a static library? Not really, so I disable the static libraries build > Consider using framework variables for pkg-plist, %%PORTDOCS%%%%DOCSDIR%% > Missing rc.d script for webserver component (disable it)? I disable the webserver capability... > > Best regards, > Daniel Regards Rodrigo