Re: git: b56d0bc41af7 - main - devel/libcutl: Explain why USE_CXXSTD=c++11 is used
Date: Thu, 06 Jul 2023 12:58:12 UTC
On Thu, Jul 06, 2023 at 10:34:57AM +0200, Raphael Kubo da Costa wrote: > ... > * net-p2p/amule uses the `register` keyword in a bunch of places > (including some autogenerated flex/bison ones that are part of the > tree), and it has been removed/deprecated in C++17. In this case, I'd advise to fix the code instead (i.e. patch out the keyword itself) rather than pinning the port to some particular C++ standard, because C++ ABI is rather fragile and this might cause linking issues in the future when some dependencies would be built in C++17 (20, 23, etc.) mode (by-that-time default) while the port is still forcing C++11. In general, it's always better to fix the code, not mask the bugs out (even though sometimes we kind of have to do this for some obscure codebases). ./danfe