From nobody Thu Jul 06 12:58:12 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qxc5c5w25z4lBKv; Thu, 6 Jul 2023 12:58:12 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Qxc5c5Q3yz4D6W; Thu, 6 Jul 2023 12:58:12 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1688648292; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xYkFG5oUqo/zwE6L1EpoNN1UmniwMhmxdhqFSW830Kc=; b=BqJ08vEAe2vvBKSAqBxqwO5g0Lk3B2Q4jESbLQslZUxcwTtZxUZt9azRHWaGaXNcn2HDtk eL43axEp9wpHfUohJLMzucUNe8Dkob5ymAT4JJoVSsMu6MIApKDOe56OCWAivOCiCAnolr mxzemxoXcWLoLcqgSeKwXk6vvo/SXCn3IaG8aZKo+25yOrBfQkKTleXiSrlFmYSf27KYs5 2DZ5JD4P17K57n6dHOUoBM5xGpox1gj4ZJRRUacni2cku096BQLCSy9agk0tNrW+8MGF94 MiBqCOhmFjej2U3l9QJiZY/0QuTucfJdtTQvIlujvQGaBkC2fwP2y8Mmj6gr/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1688648292; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xYkFG5oUqo/zwE6L1EpoNN1UmniwMhmxdhqFSW830Kc=; b=MyTsm8wCmvy5YQndbsB7cv0gJPfOlpZpK9Md5OSvz0E3ZseXtO/dkA0V5zFUjTdQeZQ3BL 3JvhU/zHbXTc44BpB/h170wrYdoEhTD0bU6l5V/IRLUb7HG7L3uRAzPKDUCbm7hppPOdCJ Nthcy1TEHNl4udVXNfBKYWMd7yiVaJrQhhlDyPfTYXNY/F1oR1csZzaZa53ztvUIR8M8Zb xR8TngIku76bIfVio3WfCZS/xHqerCKfxMEjyYRgyE/VWQg+jbtAqjBAGhQneJBN4IGbcf G4zKnFrReZOAxIqAMxbBJMi3Va0ATlBw42drinSF3IZ98idh7k1K1GbPjs4r9g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1688648292; a=rsa-sha256; cv=none; b=nnFUKe90HFQtCxJC7LL9P7FZjzeQB5ZSa6KBWUdDC89biBn/jd6uOMMPQjdoLq0iM//T9A HadBKXl26RIEJDZ8DUUhQVM8hAfvrfzL5/gBJbhrzI4yGeKo+KpSqGvbJ6Zd4lu37FMy+n 4k5pfzzWGK0ffszM5Ww4CgjOMiD9+F4maq5a/iUxZj5UP1XGbvF92UBs5f+Yd/XOf62tQT eTdJwsJfXPCs3Lzaf3VKChB35/ixVCjeRbo62xNO8IJedE70+LYyuQaRh8v9F4YhvAVCBV dh66JTedXPZ2BzGTJIhK81oany1Va/ZnLQhRPTIjJ5ryUhDfLGqQFHz9KWKGDg== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 714651A93C; Thu, 6 Jul 2023 12:58:12 +0000 (UTC) Date: Thu, 6 Jul 2023 12:58:12 +0000 From: Alexey Dokuchaev To: Raphael Kubo da Costa Cc: "Hurling, Rainer" , eduardo@freebsd.org, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: b56d0bc41af7 - main - devel/libcutl: Explain why USE_CXXSTD=c++11 is used Message-ID: References: <202307050850.3658oPOA049562@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ThisMailContainsUnwantedMimeParts: N On Thu, Jul 06, 2023 at 10:34:57AM +0200, Raphael Kubo da Costa wrote: > ... > * net-p2p/amule uses the `register` keyword in a bunch of places > (including some autogenerated flex/bison ones that are part of the > tree), and it has been removed/deprecated in C++17. In this case, I'd advise to fix the code instead (i.e. patch out the keyword itself) rather than pinning the port to some particular C++ standard, because C++ ABI is rather fragile and this might cause linking issues in the future when some dependencies would be built in C++17 (20, 23, etc.) mode (by-that-time default) while the port is still forcing C++11. In general, it's always better to fix the code, not mask the bugs out (even though sometimes we kind of have to do this for some obscure codebases). ./danfe