Re: git: 76772c2b0759 - main - www/websh: Unbreak, undeprecate, unexpire. Add LICENSE.

On Mon, Dec 25, 2023 at 12:39 AM Mikhail T. <mi+t@virtual-estates.net> wrote:
>
> 24.12.23 16:07, Gleb Popov:
>
> Porter Handbook suggests defining TEST_TARGET:
>
> TEST_TARGET identifies the make-target in the upstream's Makefile, does not it? Not in the port's Makefile, which, as you can see upon closer examination, is different...
>
> The problem with the upstream's test-target is that it always succeeds -- even if a test fails. So I have a little awk-script, which parses the results.

Then the correct thing to do is to patch upstream's Makefile and then
hook it into Ports infrastructure. Anyways, if you decide to override
test target, shouldn't you name it `do-test` instead?

> https://docs.freebsd.org/en/books/porters-handbook/book/#make-test
>
> I don't see, where that text prohibits -- or even discourages -- what I am doing. Do you?
>
> -mi

Did you have a bad day? There is no need for such a tone. I'm just
sharing my thoughts on how to do this better.