From nobody Mon Dec 25 05:53:10 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Sz6XQ09Dqz55SQX; Mon, 25 Dec 2023 05:53:42 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Sz6XN6XwPz3CK5; Mon, 25 Dec 2023 05:53:40 +0000 (UTC) (envelope-from 6yearold@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of 6yearold@gmail.com designates 209.85.219.43 as permitted sender) smtp.mailfrom=6yearold@gmail.com; dmarc=none Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-67ff310622eso6767906d6.2; Sun, 24 Dec 2023 21:53:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703483619; x=1704088419; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mN4yL1JjXflhG8QIuiNEdUDlrpSuLNw0OL5ZM+6ues0=; b=ikhypT4l89JdC6ojBUDUjxh4QJ8EwklSS8ztouNX07Ih7kbh+l/FgxkHj8yhK3Fck1 obBVlxVzGA/z6FiOO8ChVdwcjiynttsU9goKCAeKtEiGkEQXhpfrcUNOu0jtUmyrPYmG K2yGIFUjJCGWTmpSsBwK2AExfQbJt+qi8O+DWYdKfBBLQvEWi3qN5aZcCJJ0J0/HpV6F B7B+5DZMSDsjuZk+7OZ992DAn2yaz4D3jpEez3EaPivKGL7sMp6fQTGyWYY/KRd8xgIP gEJ61PH6jVrM/x5rNVgqP81RczGyTCYDcEVm5w+TwIkFLFVGXUE2w2zxPHr9KTQYu/ue vc7A== X-Gm-Message-State: AOJu0YyKFvOUrDNS0JLi6RsfcI0RWIj5Hm/JXiUFkZVVgj2TrmS3kmJO oU6+tHysJCntnY5YQwbDC+ieY/1JSI2lSE4Z X-Google-Smtp-Source: AGHT+IFyZgfCwww7+WWIDvSLPFXQfBZ7wAIIgjqVCRZ37mEXvCQcvtXSSWsOhARATL0SuRBAuElhVA== X-Received: by 2002:a05:6214:20e5:b0:67e:f56c:b6c0 with SMTP id 5-20020a05621420e500b0067ef56cb6c0mr10515947qvk.60.1703483619450; Sun, 24 Dec 2023 21:53:39 -0800 (PST) Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com. [209.85.222.179]) by smtp.gmail.com with ESMTPSA id qh10-20020a0562144c0a00b0067fc73eebe4sm1657394qvb.31.2023.12.24.21.53.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Dec 2023 21:53:39 -0800 (PST) Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-77f8308616eso312573385a.2; Sun, 24 Dec 2023 21:53:39 -0800 (PST) X-Received: by 2002:ae9:c00a:0:b0:781:bb4:ab6c with SMTP id u10-20020ae9c00a000000b007810bb4ab6cmr5953270qkk.92.1703483618875; Sun, 24 Dec 2023 21:53:38 -0800 (PST) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202312242103.3BOL3Ea7060148@gitrepo.freebsd.org> <22e32001-b097-47d8-8866-083727424152@virtual-estates.net> In-Reply-To: <22e32001-b097-47d8-8866-083727424152@virtual-estates.net> From: Gleb Popov Date: Mon, 25 Dec 2023 08:53:10 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 76772c2b0759 - main - www/websh: Unbreak, undeprecate, unexpire. Add LICENSE. To: "Mikhail T." Cc: Mikhail Teterin , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-2.99 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.991]; FORGED_SENDER(0.30)[arrowd@freebsd.org,6yearold@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MLMMJ_DEST(0.00)[dev-commits-ports-all@freebsd.org,dev-commits-ports-main@freebsd.org]; MIME_TRACE(0.00)[0:+]; RCVD_IN_DNSWL_NONE(0.00)[209.85.219.43:from,209.85.222.179:received]; R_DKIM_NA(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.219.43:from]; RCVD_TLS_LAST(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_SOME(0.00)[]; DMARC_NA(0.00)[freebsd.org]; TAGGED_RCPT(0.00)[t]; RCPT_COUNT_FIVE(0.00)[5]; FROM_NEQ_ENVFROM(0.00)[arrowd@freebsd.org,6yearold@gmail.com] X-Rspamd-Queue-Id: 4Sz6XN6XwPz3CK5 X-Spamd-Bar: -- On Mon, Dec 25, 2023 at 12:39=E2=80=AFAM Mikhail T. wrote: > > 24.12.23 16:07, Gleb Popov: > > Porter Handbook suggests defining TEST_TARGET: > > TEST_TARGET identifies the make-target in the upstream's Makefile, does n= ot it? Not in the port's Makefile, which, as you can see upon closer examin= ation, is different... > > The problem with the upstream's test-target is that it always succeeds --= even if a test fails. So I have a little awk-script, which parses the resu= lts. Then the correct thing to do is to patch upstream's Makefile and then hook it into Ports infrastructure. Anyways, if you decide to override test target, shouldn't you name it `do-test` instead? > https://docs.freebsd.org/en/books/porters-handbook/book/#make-test > > I don't see, where that text prohibits -- or even discourages -- what I a= m doing. Do you? > > -mi Did you have a bad day? There is no need for such a tone. I'm just sharing my thoughts on how to do this better.