Re: git: 38be56a530a0 - main - textproc/p5-excel2csv: new port had been added (+)

On Thu, Aug 10, 2023 at 9:09 AM Alexey Dokuchaev <danfe@freebsd.org> wrote:

> On Thu, Aug 10, 2023 at 08:53:19AM +0200, Fernando Apestegu??a wrote:
> > On Thu, Aug 10, 2023 at 8:20???AM Alexey Dokuchaev wrote:
> > > commit 38be56a530a004de92b36d35bbd8e85cd9a0fd32
> > >
> > >   textproc/p5-excel2csv: new port had been added (+)
> > >
> > >   Provides two scripts for converting Microsoft Excel
> > >   spreadsheet formats (both XLS and XLSX) to CSV.
> >
> > This project has seen only 4 commits since 2014
> > It's never had issues or pull request
>
> This often is an indication of a good, finished program. :)
>

Oh, in that case thank you for bringing the very first *perfect* piece of
software to the ports tree.

Wait... the last commit was on Jun 23rd 2021 and it was a fix... and the
previous commit was in 2017.
So it looks like the --file option was broken for at least 4 years.
Maybe the lack of user interaction is not an indication of the perfection
of the software after all.


> > This smells suspicious as in "nobody uses this software".
>
> It could be valid observation, but then you should've asked Henrik
> these questions, not closed PR as "fixed" when it's really not.
>

Should have been "Overcome by events", sorry.


>
> I've just used it to convert several *.xls and *.xlsx files created
> with recent version of Excel and LibreOffice and it works fine, making
> it useful at least for the original submitter and myself.
>

I didn't know "it is useful for the submitter" was an enough condition to
add a new port.
Thanks for the info.


>
> > The "parent" project in CPAN has only 3 issues. All of them unresolved
> > for the last 7, 9 and 12 years
>
> The author mentions that CPAN version is behind GitHub's in the README
> and so does the port in the description.
>

The critical issue is reported for version 1.07, the exact same version you
just imported: https://rt.cpan.org/Public/Bug/Display.html?id=93327
Although maybe not. The port uses commit 49386af, yet 1.07 (the latest and
only tag) is in 9c49bc6

Anyway thank you for the clarifications.
I won't bother you with this anymore.


>
> ./danfe
>