From nobody Thu Aug 10 07:28:58 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RLz7v4VBXz4Tjg5; Thu, 10 Aug 2023 07:29:15 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RLz7v42h2z4PNv; Thu, 10 Aug 2023 07:29:15 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2b962535808so9307861fa.0; Thu, 10 Aug 2023 00:29:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691652553; x=1692257353; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=r/VkMhxXyGCptqlpiW2E/yfDl26OuPNMOYF9VCZ37r4=; b=RagWQUkB2opVRETq0UL6SwDUpCl+HosRurgBS+8X7/EjpMa3gY7kO4m1XDUQMflF7S tg+XBkUEUGLSV2k05Xlers1IoXZyHguhQByCEEDE7lDmNk8j9PRBKCFKgjP12awYpODc UgXYBz9HQwIpuryHadDwPLXFwPJiflkDQIYqsv5DXi7HCCivMnJKZ6jS+eI94D/SIphd bdEndBOGiD2JnqolTWXdqA74/Wunh4ipEfmYjUo28rOlK5P1ixFMLugDAdG/JWbZBUBS R/qa83UTh/hR4nG2HP+8RxxTuwx7t+dg7Xb/E9u7Yixt4EcSQxZfCdA00rvVIwGO6TCX u4YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691652553; x=1692257353; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=r/VkMhxXyGCptqlpiW2E/yfDl26OuPNMOYF9VCZ37r4=; b=hpZUTRF6qCibBFkvOP7vfhmcszwUyF9OwYIpVTVPxPrRIOGH8jX3oRMm7fXDT2BTmF H+9APUhGLI1V+J3i5pfEkIMS7OzERGo4UWaF0UAOcEJUByzWH5moE7wplbghjDMeN7ry v/fh7KAROz5s3e4gl7fYX9UKcki3+Yfthou5yos4xvOGms6BiwST9DWJvvHbR1ZcIKyz GbpajNAoQuILRrGpkIVi1nubiCdrR/obPkaSFS5CJSlEf7SDp3qE8pyMl4RtCpy7WiDN iUBKepJ5zhBE86woq2fXd2YPhacSFaQ2HAFCWuQZj+mT9P92MejB0IYlm0nIqfFnK+H9 YwAw== X-Gm-Message-State: AOJu0YybuhuqKVtbaErBYz/Xztjy268cV9ewUSbK/ES5QElLE5p5HQBs zlZ9uqAJvk/iLAyUvGbUM/u0KZMd+AFR7j3lAIvwaTYgrLlzVg== X-Google-Smtp-Source: AGHT+IFzo3LDl9sv9nmrZK9d9bKUgRPbYW470qK+ZBxg9noh1FefXoFb+4ISI+WWMFJcGQkr6fahhN3IWpx981/kPP8= X-Received: by 2002:a2e:97d6:0:b0:2b6:fa8d:ff91 with SMTP id m22-20020a2e97d6000000b002b6fa8dff91mr1255685ljj.3.1691652552703; Thu, 10 Aug 2023 00:29:12 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202308100620.37A6KIqg017783@gitrepo.freebsd.org> In-Reply-To: From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Date: Thu, 10 Aug 2023 09:28:58 +0200 Message-ID: Subject: Re: git: 38be56a530a0 - main - textproc/p5-excel2csv: new port had been added (+) To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000007cc44406028c8db6" X-Rspamd-Queue-Id: 4RLz7v42h2z4PNv X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; TAGGED_FROM(0.00)[] --0000000000007cc44406028c8db6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Aug 10, 2023 at 9:09=E2=80=AFAM Alexey Dokuchaev wrote: > On Thu, Aug 10, 2023 at 08:53:19AM +0200, Fernando Apestegu??a wrote: > > On Thu, Aug 10, 2023 at 8:20???AM Alexey Dokuchaev wrote: > > > commit 38be56a530a004de92b36d35bbd8e85cd9a0fd32 > > > > > > textproc/p5-excel2csv: new port had been added (+) > > > > > > Provides two scripts for converting Microsoft Excel > > > spreadsheet formats (both XLS and XLSX) to CSV. > > > > This project has seen only 4 commits since 2014 > > It's never had issues or pull request > > This often is an indication of a good, finished program. :) > Oh, in that case thank you for bringing the very first *perfect* piece of software to the ports tree. Wait... the last commit was on Jun 23rd 2021 and it was a fix... and the previous commit was in 2017. So it looks like the --file option was broken for at least 4 years. Maybe the lack of user interaction is not an indication of the perfection of the software after all. > > This smells suspicious as in "nobody uses this software". > > It could be valid observation, but then you should've asked Henrik > these questions, not closed PR as "fixed" when it's really not. > Should have been "Overcome by events", sorry. > > I've just used it to convert several *.xls and *.xlsx files created > with recent version of Excel and LibreOffice and it works fine, making > it useful at least for the original submitter and myself. > I didn't know "it is useful for the submitter" was an enough condition to add a new port. Thanks for the info. > > > The "parent" project in CPAN has only 3 issues. All of them unresolved > > for the last 7, 9 and 12 years > > The author mentions that CPAN version is behind GitHub's in the README > and so does the port in the description. > The critical issue is reported for version 1.07, the exact same version you just imported: https://rt.cpan.org/Public/Bug/Display.html?id=3D93327 Although maybe not. The port uses commit 49386af, yet 1.07 (the latest and only tag) is in 9c49bc6 Anyway thank you for the clarifications. I won't bother you with this anymore. > > ./danfe > --0000000000007cc44406028c8db6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Aug 10, 2023 at 9:09=E2=80=AF= AM Alexey Dokuchaev <danfe@freebsd.= org> wrote:
On Thu, Aug 10, 2023 at 08:53:19AM +0200, Fernando Apestegu??a wrote: > On Thu, Aug 10, 2023 at 8:20???AM Alexey Dokuchaev wrote:
> > commit 38be56a530a004de92b36d35bbd8e85cd9a0fd32
> >
> >=C2=A0 =C2=A0textproc/p5-excel2csv: new port had been added (+) > >
> >=C2=A0 =C2=A0Provides two scripts for converting Microsoft Excel > >=C2=A0 =C2=A0spreadsheet formats (both XLS and XLSX) to CSV.
>
> This project has seen only 4 commits since 2014
> It's never had issues or pull request

This often is an indication of a good, finished program. :)

Oh, in that case thank you for bringi= ng the very first *perfect* piece of software to the ports tree.

Wait... the last= commit was on Jun 23rd 2021 and it was a fix... and the previous commit wa= s in 2017.
So it looks like the --file opti= on was broken for at least 4 years.
May= be the lack of user interaction is not an indication of the perfection of t= he software after all.

<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">
> This smells suspicious as in "nobody uses this software".
It could be valid observation, but then you should've asked Henrik
these questions, not closed PR as "fixed" when it's really no= t.

Should have been "Overcome by e= vents", sorry.
=C2=A0

I've just used it to convert several *.xls and *.xlsx files created
with recent version of Excel and LibreOffice and it works fine, making
it useful at least for the original submitter and myself.
<= div>
I didn't know "it is useful for the submitter&q= uot; was an enough condition to add a new port.
Thanks for the in= fo.
=C2=A0

> The "parent" project in CPAN has only 3 issues. All of them = unresolved
> for the last 7, 9 and 12 years

The author mentions that CPAN version is behind GitHub's in the README<= br> and so does the port in the description.

The critical issue is reported for version 1.07, the exact same version y= ou just imported: https://rt.cpan.org/Public/Bug/Display.html?id=3D93327
<= div>Although maybe not. The port uses commit 49386af, yet 1.07 (the latest = and only tag) is in 9c49bc6

Anyway thank you for t= he clarifications.
I won't bother you with this anymore.
<= /div>
=C2=A0

./danfe
--0000000000007cc44406028c8db6--