Re: git: 38be56a530a0 - main - textproc/p5-excel2csv: new port had been added (+)

On Thu, Aug 10, 2023 at 8:20 AM Alexey Dokuchaev <danfe@freebsd.org> wrote:

> The branch main has been updated by danfe:
>
> URL:
> https://cgit.FreeBSD.org/ports/commit/?id=38be56a530a004de92b36d35bbd8e85cd9a0fd32
>
> commit 38be56a530a004de92b36d35bbd8e85cd9a0fd32
> Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
> AuthorDate: 2023-08-10 06:19:16 +0000
> Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
> CommitDate: 2023-08-10 06:19:16 +0000
>
>     textproc/p5-excel2csv: new port had been added (+)
>
>     Provides two scripts for converting Microsoft Excel
>     spreadsheet formats (both XLS and XLSX) to CSV.
>

This project has seen only 4 commits since 2014 (
https://github.com/xevo/xls2csv/commits/master)
It's never had issues (https://github.com/xevo/xls2csv/issues?q=is%3Aissue)
or pull request (https://github.com/xevo/xls2csv/pulls?q=is%3Apr)
This smells suspicious as in "nobody uses this software".
The "parent" project in CPAN has only 3 issues. All of them unresolved for
the last 7, 9 and 12 years (
https://rt.cpan.org/Public/Dist/Display.html?Name=xls2csv).
One of them is marked as critical.

Is this really something we want to have in the tree?


>
>     PR:             254499
>     Submitted by:   Henrik Rosenke
> ---
>  textproc/Makefile               |  1 +
>  textproc/p5-excel2csv/Makefile  | 28 ++++++++++++++++++++++++++++
>  textproc/p5-excel2csv/distinfo  |  3 +++
>  textproc/p5-excel2csv/pkg-descr |  6 ++++++
>  textproc/p5-excel2csv/pkg-plist |  4 ++++
>  5 files changed, 42 insertions(+)
>
> diff --git a/textproc/Makefile b/textproc/Makefile
> index edaeabaa11f9..77e2a36a5153 100644
> --- a/textproc/Makefile
> +++ b/textproc/Makefile
> @@ -1192,6 +1192,7 @@
>      SUBDIR += p5-ack
>      SUBDIR += p5-dTemplate
>      SUBDIR += p5-docx2txt
> +    SUBDIR += p5-excel2csv
>      SUBDIR += p5-libsoldout
>      SUBDIR += p5-libxml
>      SUBDIR += p5-pod2pdf
> diff --git a/textproc/p5-excel2csv/Makefile
> b/textproc/p5-excel2csv/Makefile
> new file mode 100644
> index 000000000000..74d252723474
> --- /dev/null
> +++ b/textproc/p5-excel2csv/Makefile
> @@ -0,0 +1,28 @@
> +PORTNAME=      excel2csv
> +PORTVERSION=   1.07
> +CATEGORIES=    textproc perl5
> +PKGNAMEPREFIX= p5-
> +
> +MAINTAINER=    rosenke@dssgmbh.de
> +COMMENT=       Convert Microsoft Excel spreadsheets to CSV format
> +WWW=           https://github.com/xevo/xls2csv
> +
> +LICENSE=       GPLv2
> +
> +RUN_DEPENDS=   p5-Locale-libintl>0:devel/p5-Locale-libintl \
> +
>  p5-Spreadsheet-ParseExcel>0:textproc/p5-Spreadsheet-ParseExcel \
> +               p5-Spreadsheet-XLSX>0:textproc/p5-Spreadsheet-XLSX \
> +               p5-Text-CSV_XS>0:textproc/p5-Text-CSV_XS \
> +               p5-Text-Iconv>0:converters/p5-Text-Iconv \
> +               p5-Unicode-Map>0:converters/p5-Unicode-Map
> +
> +USES=          perl5
> +USE_PERL5=     configure
> +USE_GITHUB=    yes
> +GH_ACCOUNT=    xevo
> +GH_PROJECT=    xls2csv
> +GH_TAGNAME=    49386af
> +
> +NO_ARCH=       yes
> +
> +.include <bsd.port.mk>
> diff --git a/textproc/p5-excel2csv/distinfo
> b/textproc/p5-excel2csv/distinfo
> new file mode 100644
> index 000000000000..e1b95d608961
> --- /dev/null
> +++ b/textproc/p5-excel2csv/distinfo
> @@ -0,0 +1,3 @@
> +TIMESTAMP = 1624458591
> +SHA256 (xevo-xls2csv-1.07-49386af_GH0.tar.gz) =
> 32444583fce3cda5314df691d675dd4fa148d7da840053d4fa1a9a4ec15ca92b
> +SIZE (xevo-xls2csv-1.07-49386af_GH0.tar.gz) = 15454
> diff --git a/textproc/p5-excel2csv/pkg-descr
> b/textproc/p5-excel2csv/pkg-descr
> new file mode 100644
> index 000000000000..6d46b5bbc313
> --- /dev/null
> +++ b/textproc/p5-excel2csv/pkg-descr
> @@ -0,0 +1,6 @@
> +excel2csv provides two scripts for converting Microsoft Excel spreadsheet
> +formats XLS and XLSX to CSV.  Improvements compared to the CPAN version:
> +
> +  - Supports XLSX files
> +  - Handles character encodings much better
> +  - The options make more sense
> diff --git a/textproc/p5-excel2csv/pkg-plist
> b/textproc/p5-excel2csv/pkg-plist
> new file mode 100644
> index 000000000000..b8518ed2dade
> --- /dev/null
> +++ b/textproc/p5-excel2csv/pkg-plist
> @@ -0,0 +1,4 @@
> +bin/excel2csv
> +bin/xls2csv
> +%%PERL5_MAN1%%/excel2csv.1.gz
> +%%PERL5_MAN1%%/xls2csv.1.gz
>