From nobody Thu Aug 10 06:53:19 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RLyLn6g7Wz4qDHW; Thu, 10 Aug 2023 06:53:37 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RLyLn116Hz4JJw; Thu, 10 Aug 2023 06:53:37 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2b9b6e943ebso19774511fa.1; Wed, 09 Aug 2023 23:53:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691650412; x=1692255212; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=XTpdApj46ESA8xR/NggjyGlKG2ud90oViQZkV1IFiiw=; b=o3QUmRkd0k+zR9w3YqSSiH5q7zcCXeoyaveC7d/EAiToz9xFLHGsJyjdtULfWitovy uXalweRxy49QvmhZN8p+NocjeSTes2coQ/+Kw5d+havLBTYAIZ3tZL0jILTHUHc2ZPY/ ag64ww0MJN40YRWMFVWYIzIxjd/fZTD8G3MXFxa3Pff4j5tck9rU3a3zBsCHsf+BymeP 71J/6j5Aacg+vyULTt60MOyQHNxOUKWJqV+GIubJ4VBcFmCrmblTiZElSCzyK8N0KcLX lahVWsceHF7t1sbD7txazMwv4XcvtS4tfV/5NMvnHcWtZb5ECVkqH3oEeR1wExeNA+tO YvGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691650412; x=1692255212; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XTpdApj46ESA8xR/NggjyGlKG2ud90oViQZkV1IFiiw=; b=Q52zFYbWNVaW09fU8xD4507xvpeusiIzbTyeTyQ4TQfBLcXuXMlavp3s/p18NxA0LF 8ugfFTjQNE3Ir/jpuf09UmuYyzLvlpNzeA/cvmvgDi5qmuWf+BHcX6X6rccapbPThznr QTaE7HQKvEUUNg0GAHgqaTJlPZV9nJnypsNSWKS6gy6bPnWGIdKCTpwfBIVm4mZzrDQ/ KU94vYapMdSqBGuYHIsH4OJ6eyM6OVb2OAsAOi2pM1ZtgjGkCFPoGXhQO9O9r594AW2C wAc4hTTud9REG+4gOotYms3YVjgZHZbkn7XksvGYFka+vzl2Tx/75SDIM2g+OZPFJOVE TneA== X-Gm-Message-State: AOJu0YweVll86QAhmL46uyYm5E0M+VSBhIj1g63oG/9jatdUifqtT8JW bFDOpvLk1rxZnqsaaOQzKVTJqRXBief9QgSuq4vwlFLPgfgSzw== X-Google-Smtp-Source: AGHT+IHV7ukaO1fimOd2BBhGR2D1wbzwmL0Dk59/LOs44+Y33VLh1mEninMmyGYYRzKm1FfB0n+rMlyxh9clnNAxYW8= X-Received: by 2002:a2e:b7d5:0:b0:2b6:b30f:5bf with SMTP id p21-20020a2eb7d5000000b002b6b30f05bfmr537264ljo.13.1691650411969; Wed, 09 Aug 2023 23:53:31 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202308100620.37A6KIqg017783@gitrepo.freebsd.org> In-Reply-To: <202308100620.37A6KIqg017783@gitrepo.freebsd.org> From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Date: Thu, 10 Aug 2023 08:53:19 +0200 Message-ID: Subject: Re: git: 38be56a530a0 - main - textproc/p5-excel2csv: new port had been added (+) To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000e3c0ab06028c0d3e" X-Rspamd-Queue-Id: 4RLyLn116Hz4JJw X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; TAGGED_FROM(0.00)[] --000000000000e3c0ab06028c0d3e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Aug 10, 2023 at 8:20=E2=80=AFAM Alexey Dokuchaev wrote: > The branch main has been updated by danfe: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=3D38be56a530a004de92b36d35bbd8e= 85cd9a0fd32 > > commit 38be56a530a004de92b36d35bbd8e85cd9a0fd32 > Author: Alexey Dokuchaev > AuthorDate: 2023-08-10 06:19:16 +0000 > Commit: Alexey Dokuchaev > CommitDate: 2023-08-10 06:19:16 +0000 > > textproc/p5-excel2csv: new port had been added (+) > > Provides two scripts for converting Microsoft Excel > spreadsheet formats (both XLS and XLSX) to CSV. > This project has seen only 4 commits since 2014 ( https://github.com/xevo/xls2csv/commits/master) It's never had issues (https://github.com/xevo/xls2csv/issues?q=3Dis%3Aissu= e) or pull request (https://github.com/xevo/xls2csv/pulls?q=3Dis%3Apr) This smells suspicious as in "nobody uses this software". The "parent" project in CPAN has only 3 issues. All of them unresolved for the last 7, 9 and 12 years ( https://rt.cpan.org/Public/Dist/Display.html?Name=3Dxls2csv). One of them is marked as critical. Is this really something we want to have in the tree? > > PR: 254499 > Submitted by: Henrik Rosenke > --- > textproc/Makefile | 1 + > textproc/p5-excel2csv/Makefile | 28 ++++++++++++++++++++++++++++ > textproc/p5-excel2csv/distinfo | 3 +++ > textproc/p5-excel2csv/pkg-descr | 6 ++++++ > textproc/p5-excel2csv/pkg-plist | 4 ++++ > 5 files changed, 42 insertions(+) > > diff --git a/textproc/Makefile b/textproc/Makefile > index edaeabaa11f9..77e2a36a5153 100644 > --- a/textproc/Makefile > +++ b/textproc/Makefile > @@ -1192,6 +1192,7 @@ > SUBDIR +=3D p5-ack > SUBDIR +=3D p5-dTemplate > SUBDIR +=3D p5-docx2txt > + SUBDIR +=3D p5-excel2csv > SUBDIR +=3D p5-libsoldout > SUBDIR +=3D p5-libxml > SUBDIR +=3D p5-pod2pdf > diff --git a/textproc/p5-excel2csv/Makefile > b/textproc/p5-excel2csv/Makefile > new file mode 100644 > index 000000000000..74d252723474 > --- /dev/null > +++ b/textproc/p5-excel2csv/Makefile > @@ -0,0 +1,28 @@ > +PORTNAME=3D excel2csv > +PORTVERSION=3D 1.07 > +CATEGORIES=3D textproc perl5 > +PKGNAMEPREFIX=3D p5- > + > +MAINTAINER=3D rosenke@dssgmbh.de > +COMMENT=3D Convert Microsoft Excel spreadsheets to CSV format > +WWW=3D https://github.com/xevo/xls2csv > + > +LICENSE=3D GPLv2 > + > +RUN_DEPENDS=3D p5-Locale-libintl>0:devel/p5-Locale-libintl \ > + > p5-Spreadsheet-ParseExcel>0:textproc/p5-Spreadsheet-ParseExcel \ > + p5-Spreadsheet-XLSX>0:textproc/p5-Spreadsheet-XLSX \ > + p5-Text-CSV_XS>0:textproc/p5-Text-CSV_XS \ > + p5-Text-Iconv>0:converters/p5-Text-Iconv \ > + p5-Unicode-Map>0:converters/p5-Unicode-Map > + > +USES=3D perl5 > +USE_PERL5=3D configure > +USE_GITHUB=3D yes > +GH_ACCOUNT=3D xevo > +GH_PROJECT=3D xls2csv > +GH_TAGNAME=3D 49386af > + > +NO_ARCH=3D yes > + > +.include > diff --git a/textproc/p5-excel2csv/distinfo > b/textproc/p5-excel2csv/distinfo > new file mode 100644 > index 000000000000..e1b95d608961 > --- /dev/null > +++ b/textproc/p5-excel2csv/distinfo > @@ -0,0 +1,3 @@ > +TIMESTAMP =3D 1624458591 > +SHA256 (xevo-xls2csv-1.07-49386af_GH0.tar.gz) =3D > 32444583fce3cda5314df691d675dd4fa148d7da840053d4fa1a9a4ec15ca92b > +SIZE (xevo-xls2csv-1.07-49386af_GH0.tar.gz) =3D 15454 > diff --git a/textproc/p5-excel2csv/pkg-descr > b/textproc/p5-excel2csv/pkg-descr > new file mode 100644 > index 000000000000..6d46b5bbc313 > --- /dev/null > +++ b/textproc/p5-excel2csv/pkg-descr > @@ -0,0 +1,6 @@ > +excel2csv provides two scripts for converting Microsoft Excel spreadshee= t > +formats XLS and XLSX to CSV. Improvements compared to the CPAN version: > + > + - Supports XLSX files > + - Handles character encodings much better > + - The options make more sense > diff --git a/textproc/p5-excel2csv/pkg-plist > b/textproc/p5-excel2csv/pkg-plist > new file mode 100644 > index 000000000000..b8518ed2dade > --- /dev/null > +++ b/textproc/p5-excel2csv/pkg-plist > @@ -0,0 +1,4 @@ > +bin/excel2csv > +bin/xls2csv > +%%PERL5_MAN1%%/excel2csv.1.gz > +%%PERL5_MAN1%%/xls2csv.1.gz > --000000000000e3c0ab06028c0d3e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Aug 10, 2023 at 8:20=E2=80=AF= AM Alexey Dokuchaev <danfe@freebsd.= org> wrote:
The branch main has been updated by danfe:

URL: https://cgi= t.FreeBSD.org/ports/commit/?id=3D38be56a530a004de92b36d35bbd8e85cd9a0fd32

commit 38be56a530a004de92b36d35bbd8e85cd9a0fd32
Author:=C2=A0 =C2=A0 =C2=A0Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2023-08-10 06:19:16 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2023-08-10 06:19:16 +0000

=C2=A0 =C2=A0 textproc/p5-excel2csv: new port had been added (+)

=C2=A0 =C2=A0 Provides two scripts for converting Microsoft Excel
=C2=A0 =C2=A0 spreadsheet formats (both XLS and XLSX) to CSV.

This smells suspicious as in "n= obody uses this software".
The "parent" projec= t in CPAN has only 3 issues. All of them unresolved for the last 7, 9 and 1= 2 years (https://rt.cpan.org/Public/Dist/Display.html?Name=3Dxls2csv).
One of them is marked as critical.

Is this = really something we want to have in the tree?
=C2=A0

=C2=A0 =C2=A0 PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0254499
=C2=A0 =C2=A0 Submitted by:=C2=A0 =C2=A0Henrik Rosenke
---
=C2=A0textproc/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0|=C2=A0 1 +
=C2=A0textproc/p5-excel2csv/Makefile=C2=A0 | 28 +++++++++++++++++++++++++++= +
=C2=A0textproc/p5-excel2csv/distinfo=C2=A0 |=C2=A0 3 +++
=C2=A0textproc/p5-excel2csv/pkg-descr |=C2=A0 6 ++++++
=C2=A0textproc/p5-excel2csv/pkg-plist |=C2=A0 4 ++++
=C2=A05 files changed, 42 insertions(+)

diff --git a/textproc/Makefile b/textproc/Makefile
index edaeabaa11f9..77e2a36a5153 100644
--- a/textproc/Makefile
+++ b/textproc/Makefile
@@ -1192,6 +1192,7 @@
=C2=A0 =C2=A0 =C2=A0SUBDIR +=3D p5-ack
=C2=A0 =C2=A0 =C2=A0SUBDIR +=3D p5-dTemplate
=C2=A0 =C2=A0 =C2=A0SUBDIR +=3D p5-docx2txt
+=C2=A0 =C2=A0 SUBDIR +=3D p5-excel2csv
=C2=A0 =C2=A0 =C2=A0SUBDIR +=3D p5-libsoldout
=C2=A0 =C2=A0 =C2=A0SUBDIR +=3D p5-libxml
=C2=A0 =C2=A0 =C2=A0SUBDIR +=3D p5-pod2pdf
diff --git a/textproc/p5-excel2csv/Makefile b/textproc/p5-excel2csv/Makefil= e
new file mode 100644
index 000000000000..74d252723474
--- /dev/null
+++ b/textproc/p5-excel2csv/Makefile
@@ -0,0 +1,28 @@
+PORTNAME=3D=C2=A0 =C2=A0 =C2=A0 excel2csv
+PORTVERSION=3D=C2=A0 =C2=A01.07
+CATEGORIES=3D=C2=A0 =C2=A0 textproc perl5
+PKGNAMEPREFIX=3D p5-
+
+MAINTAINER=3D=C2=A0 =C2=A0 rosenke@dssgmbh.de
+COMMENT=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0Convert Microsoft Excel spreadsheets = to CSV format
+WWW=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0https://github.com/xe= vo/xls2csv
+
+LICENSE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0GPLv2
+
+RUN_DEPENDS=3D=C2=A0 =C2=A0p5-Locale-libintl>0:devel/p5-Locale-libintl = \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0p5-Spreadsheet-Pars= eExcel>0:textproc/p5-Spreadsheet-ParseExcel \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0p5-Spreadsheet-XLSX= >0:textproc/p5-Spreadsheet-XLSX \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0p5-Text-CSV_XS>0= :textproc/p5-Text-CSV_XS \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0p5-Text-Iconv>0:= converters/p5-Text-Iconv \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0p5-Unicode-Map>0= :converters/p5-Unicode-Map
+
+USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 perl5
+USE_PERL5=3D=C2=A0 =C2=A0 =C2=A0configure
+USE_GITHUB=3D=C2=A0 =C2=A0 yes
+GH_ACCOUNT=3D=C2=A0 =C2=A0 xevo
+GH_PROJECT=3D=C2=A0 =C2=A0 xls2csv
+GH_TAGNAME=3D=C2=A0 =C2=A0 49386af
+
+NO_ARCH=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0yes
+
+.include <bsd.port.mk>
diff --git a/textproc/p5-excel2csv/distinfo b/textproc/p5-excel2csv/distinf= o
new file mode 100644
index 000000000000..e1b95d608961
--- /dev/null
+++ b/textproc/p5-excel2csv/distinfo
@@ -0,0 +1,3 @@
+TIMESTAMP =3D 1624458591
+SHA256 (xevo-xls2csv-1.07-49386af_GH0.tar.gz) =3D 32444583fce3cda5314df691= d675dd4fa148d7da840053d4fa1a9a4ec15ca92b
+SIZE (xevo-xls2csv-1.07-49386af_GH0.tar.gz) =3D 15454
diff --git a/textproc/p5-excel2csv/pkg-descr b/textproc/p5-excel2csv/pkg-de= scr
new file mode 100644
index 000000000000..6d46b5bbc313
--- /dev/null
+++ b/textproc/p5-excel2csv/pkg-descr
@@ -0,0 +1,6 @@
+excel2csv provides two scripts for converting Microsoft Excel spreadsheet<= br> +formats XLS and XLSX to CSV.=C2=A0 Improvements compared to the CPAN versi= on:
+
+=C2=A0 - Supports XLSX files
+=C2=A0 - Handles character encodings much better
+=C2=A0 - The options make more sense
diff --git a/textproc/p5-excel2csv/pkg-plist b/textproc/p5-excel2csv/pkg-pl= ist
new file mode 100644
index 000000000000..b8518ed2dade
--- /dev/null
+++ b/textproc/p5-excel2csv/pkg-plist
@@ -0,0 +1,4 @@
+bin/excel2csv
+bin/xls2csv
+%%PERL5_MAN1%%/excel2csv.1.gz
+%%PERL5_MAN1%%/xls2csv.1.gz
--000000000000e3c0ab06028c0d3e--