Re: git: 3082cab3f868 - main - net/wifi-firmware-*: add framework and firmware for various WiFi chipsets

From: Rene Ladan <rene_at_freebsd.org>
Date: Sat, 22 Apr 2023 20:19:13 UTC
On Sat, Apr 22, 2023 at 08:02:07PM +0000, Bjoern A. Zeeb wrote:
> On Sat, 22 Apr 2023, Rene Ladan wrote:
> 
> >> For immediate help (before connecting them to the build):
> >>
> >> I also got a report from dvl/freshports that the base port (which should
> >> never be built) doesn't have a pkg-descr.  Do I need to add that too?
> >>
> > Hmm, I think it is cleaner that way, a placeholder text might do.
> >
> > <musings>
> > The internal `make generate-plist` target in bsd.port.mk assumes a pkg-descr
> > here, and having a pkg-descr avoids a /dev/null entry in INDEX in its place.
> >
> > The current -base port is not a meta-port in the traditional sense, see
> > Mk/Uses/metaport.mk and e.g. x11/kde5/Makefile for an example. Personally
> > it more feels like an extension of USES=kmod.
> > </musings>
> 
> It's probably  similar to u-boot-master ...
> 
Ah, didn't think of that port yet.

> So here we go?  That ok?
> 
Can you connnect wifi-firmware-base to the build too? Even though the port is
IGNOREd, the same is done for sysutils/u-boot-master.

Looks fine otherwise.

René

> diff --git a/net/Makefile b/net/Makefile
> index 4c2b20321014..b4dcdb7d90f4 100644
> --- a/net/Makefile
> +++ b/net/Makefile
> @@ -1580,6 +1580,11 @@
>       SUBDIR += webalizer-geodb
>       SUBDIR += whois
>       SUBDIR += widentd
> +    SUBDIR += wifi-firmware-ath10k-kmod
> +    SUBDIR += wifi-firmware-ath11k-kmod
> +    SUBDIR += wifi-firmware-mt76-kmod
> +    SUBDIR += wifi-firmware-rtw88-kmod
> +    SUBDIR += wifi-firmware-rtw89-kmod
>       SUBDIR += wifibox
>       SUBDIR += wifibox-alpine
>       SUBDIR += wifibox-core
> diff --git a/net/wifi-firmware-base/pkg-descr b/net/wifi-firmware-base/pkg-descr
> new file mode 100644
> index 000000000000..0825791ccf13
> --- /dev/null
> +++ b/net/wifi-firmware-base/pkg-descr
> @@ -0,0 +1 @@
> +WiFi firmware build master port.
> 
> 
> -- 
> Bjoern A. Zeeb                                                     r15:7