From nobody Sat Apr 22 20:19:13 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q3jR55kDpz46FdP; Sat, 22 Apr 2023 20:19:13 +0000 (UTC) (envelope-from rene@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q3jR54lwRz3Py3; Sat, 22 Apr 2023 20:19:13 +0000 (UTC) (envelope-from rene@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682194753; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oygCLhwGAY7JNjlmpaHf7eveteOk9Ecm2oK3gfFOdSY=; b=wHUj8oaO8sP39ctStpoaGefer9DqaYb9RtlE3rcaEVdPsQ9Jm/tHBEsQdjU4t/SldSrXcv yf72UvXzmpFcrtD9G4FZY4XOCTI1SfD/fjP8IZglkGPw6gA4wZGPwgpemkK0+9SkHdBXMd RdFfmii6f4VjFpC9gOiB9jVLTqhU2UIfjWvgkNkPc9hOUkOjKG1on1V/oSFBx2l0TRmv+4 3K33I2sxYYpF3FEZ8Yx6cQC4x3nsp5dVnM0qUdsnQu6IWoSyBB6rdH1+ty209Y9aKbyahf TL0HPjMH/iNxuHegfvdcy7WXzKpHy2tsOcx2LMevk0pKvn3uv4mzlZsXnNoVjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682194753; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oygCLhwGAY7JNjlmpaHf7eveteOk9Ecm2oK3gfFOdSY=; b=bx79jqt4lfvsloY9kWMgJRB/c8yFaYxkZ52lv1GwBJtge3ApZJ2sbEqV7ukg//ZEgpEZr1 9cn5GR0Y9ON30xLct8WpLAKvN58vF35IBcrRaDSj1MXTB1GjmSPfKqPVBUotj9aODTt/Sh 3EK8hAhusVxjOWO50Z1iZiK09dSGW+o9m6y3bOv8ZDDZjeFOYP15RMG/TBtmSKUicuWFDm I5AvHAtMJUhYeq0vPYKnumdIblcVb26axVuNMHg6/mKe3/Ju7z++PVAngrFO6FqxouFNjw mASr1PfRkZ25bCJ0JDB7zeWDhzWBsjMk2tQsTzJ3f5qlHGslPtS5uDawhPDHxw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1682194753; a=rsa-sha256; cv=none; b=ufu6K0yyM1PgtPBs9eaWIGSr2cquBJO8hUc8sF196wEwj5BfP6FhWOmronAi7lp42heI4/ JJJLnggIvUDftidDFnXJG5wjluWLosGWT+b/Ed9mmoRsYSnuxRDzbvp+r/XBpdGYaoPEPy um55MllmT0Eetvbl/5k0dfWqgz8UxdwazZIsghI2akGykrBqlrJyQ9+e3NC6m1Y0TMfbHm aMtykogNn66YUuSUOMT5NHzl7bC1WhlEW9JzG1+E5yY4tsE3HCBfbr7yyRr/HyWv8UnUsq 3U9kY2lIOpCIJ6rDBWGYvdCljVHGKNQUSaj6UHdjOqIg2j5j9hCChmmfmBxhlA== Received: by freefall.freebsd.org (Postfix, from userid 1185) id 86AD4141D3; Sat, 22 Apr 2023 20:19:13 +0000 (UTC) Date: Sat, 22 Apr 2023 20:19:13 +0000 From: Rene Ladan To: "Bjoern A. Zeeb" Cc: Emmanuel Vadot , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 3082cab3f868 - main - net/wifi-firmware-*: add framework and firmware for various WiFi chipsets Message-ID: References: <202304221526.33MFQ8Ah006135@gitrepo.freebsd.org> <20230422200746.f5de9ba748783b3c49ad6ffb@bidouilliste.com> <558rpr26-q19s-n3o3-7q47-011549so044s@serrofq.bet> <0n0q0qp2-95o0-q70o-487s-1s9p699nr7rs@serrofq.bet> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0n0q0qp2-95o0-q70o-487s-1s9p699nr7rs@serrofq.bet> X-ThisMailContainsUnwantedMimeParts: N On Sat, Apr 22, 2023 at 08:02:07PM +0000, Bjoern A. Zeeb wrote: > On Sat, 22 Apr 2023, Rene Ladan wrote: > > >> For immediate help (before connecting them to the build): > >> > >> I also got a report from dvl/freshports that the base port (which should > >> never be built) doesn't have a pkg-descr. Do I need to add that too? > >> > > Hmm, I think it is cleaner that way, a placeholder text might do. > > > > > > The internal `make generate-plist` target in bsd.port.mk assumes a pkg-descr > > here, and having a pkg-descr avoids a /dev/null entry in INDEX in its place. > > > > The current -base port is not a meta-port in the traditional sense, see > > Mk/Uses/metaport.mk and e.g. x11/kde5/Makefile for an example. Personally > > it more feels like an extension of USES=kmod. > > > > It's probably similar to u-boot-master ... > Ah, didn't think of that port yet. > So here we go? That ok? > Can you connnect wifi-firmware-base to the build too? Even though the port is IGNOREd, the same is done for sysutils/u-boot-master. Looks fine otherwise. René > diff --git a/net/Makefile b/net/Makefile > index 4c2b20321014..b4dcdb7d90f4 100644 > --- a/net/Makefile > +++ b/net/Makefile > @@ -1580,6 +1580,11 @@ > SUBDIR += webalizer-geodb > SUBDIR += whois > SUBDIR += widentd > + SUBDIR += wifi-firmware-ath10k-kmod > + SUBDIR += wifi-firmware-ath11k-kmod > + SUBDIR += wifi-firmware-mt76-kmod > + SUBDIR += wifi-firmware-rtw88-kmod > + SUBDIR += wifi-firmware-rtw89-kmod > SUBDIR += wifibox > SUBDIR += wifibox-alpine > SUBDIR += wifibox-core > diff --git a/net/wifi-firmware-base/pkg-descr b/net/wifi-firmware-base/pkg-descr > new file mode 100644 > index 000000000000..0825791ccf13 > --- /dev/null > +++ b/net/wifi-firmware-base/pkg-descr > @@ -0,0 +1 @@ > +WiFi firmware build master port. > > > -- > Bjoern A. Zeeb r15:7