Re: git: c89b6f279989 - main - lang/php8[12]: Fix build on aarch64 with ZTS

Reply: Alexey Dokuchaev : "Re: git: c89b6f279989 - main - lang/php8[12]: Fix build on aarch64 with ZTS"
In reply to: Alexey Dokuchaev : "Re: git: c89b6f279989 - main - lang/php8[12]: Fix build on aarch64 with ZTS"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Mathieu Arnold <mat_at_freebsd.org>
Date: Wed, 12 Apr 2023 13:55:00 UTC

On Wed, Apr 12, 2023 at 01:43:43PM +0000, Alexey Dokuchaev wrote:
> On Wed, Apr 12, 2023 at 05:39:24AM +0000, Muhammad Moinur Rahman wrote:
> > commit c89b6f2799891129e89d1b4fedf8e25865241060
> > 
> >   lang/php8[12]: Fix build on aarch64 with ZTS
> > 
> >   - Refresh patches
> 
> What good did it bring other than cloaking the actual fix with tons
> of needless, unrelated changes?  You've poured a glass of honey into
> a bucket of tar. :(

Because that is something you have to do everytime a port is updated,
refresh the patches so that the line offsets are correct wrt current
sources, to make sure patch(1) can just apply the patches and not resort
to guesswork.

-- 
Mathieu Arnold