Re: git: 4671249405c0 - main - net/rubygem-omniauth-auth0: Fix build failure
Date: Mon, 11 Jul 2022 22:37:57 UTC
On Wed, Jul 6, 2022 at 11:31 PM Matthias Fechner <mfechner@freebsd.org> wrote: > Dear Sunpoet, > > Am 06.07.2022 um 16:35 schrieb Po-Chuan Hsieh: > > On Thu, Jun 30, 2022 at 10:32 PM Matthias Fechner <mfechner@freebsd.org> > wrote: > >> The branch main has been updated by mfechner: >> >> URL: >> https://cgit.FreeBSD.org/ports/commit/?id=4671249405c05bb65dfec261eb645081ea72fdf5 >> >> commit 4671249405c05bb65dfec261eb645081ea72fdf5 >> Author: Matthias Fechner <mfechner@FreeBSD.org> >> <mfechner@FreeBSD.org> >> AuthorDate: 2022-06-30 14:28:33 +0000 >> Commit: Matthias Fechner <mfechner@FreeBSD.org> >> <mfechner@FreeBSD.org> >> CommitDate: 2022-06-30 14:32:13 +0000 >> >> net/rubygem-omniauth-auth0: Fix build failure > > >> Fixes a build regression after: >> 56e085ca55a831ab56e2e6b417bf230c827fd2e5 >> > > I think this commit is incorrect. > I could build this port successfully with rubygem-omniauth-oauth2 (1.8.0) > Please provide the error message. > > Furthermore, the only difference between omniauth-oauth2 1.7.3 and 1.8.0 > [1] is the change of omniauth from ">=1.9<3" to ">=2<3" > where security/rubygem-omniauth is 2.1.0 already. > I don't know how it can fix build failure. > > [1] https://github.com/omniauth/omniauth-oauth2/compare/v1.7.3...v1.8.0 > > And this change caused a race in the dependency tree. > > I suggest you build www/gitlab-ce, then you will see the error. > Or you can also search here to find the correct log file: > https://pkg.fechner.net/jail.html?mastername=131amd64-default > > Here the direct link to the log: > > https://pkg.fechner.net/build.html?mastername=131amd64-default&build=2022-06-30_10h05m29s > > Resolving dependencies... > Bundler could not find compatible versions for gem "omniauth": > In Gemfile: > omniauth-azure-oauth2 (~> 0.0.9) was resolved to 0.0.10, which depends on > omniauth (~> 1.0) > > omniauth-azure-oauth2 (~> 0.0.9) was resolved to 0.0.10, which depends on > omniauth-oauth2 (~> 1.4) was resolved to 1.8.0, which depends on > omniauth (~> 2.0) > *** Error code 6 > > This modification was the minimal fix I figured out without the need to > rollback a commit. > OK, the failure is about gitlab-ce but the commit message looks like it causes the build failure of net/rubygem-omniauth-auth0. Anyway, you could try this patch [1]. Then we could drop confusing net/rubygem-omniauth-oauth2-v1. [1] https://people.freebsd.org/~sunpoet/patch/gitlab-ce.txt > >> -RUN_DEPENDS= rubygem-omniauth-oauth2>=1.1:net/rubygem-omniauth-oauth2 >> > > That should be >=1.4<2 to match upstream (~> 1.4). > And net/rubygem-omniauth-oauth2 (1.8.0) fits the range. > > +RUN_DEPENDS= >> rubygem-omniauth-oauth2-v1>=1.4<2:net/rubygem-omniauth-oauth2-v1 >> >> yes and that is what I changed here. > > > Gruß > Matthias > > -- > > "Programming today is a race between software engineers striving to > build bigger and better idiot-proof programs, and the universe trying to > produce bigger and better idiots. So far, the universe is winning." -- > Rich Cook > >