From nobody Mon Jul 11 22:37:57 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id AB8411D0C287 for ; Mon, 11 Jul 2022 22:38:34 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Lhf1Q4Y1cz49y0 for ; Mon, 11 Jul 2022 22:38:34 +0000 (UTC) (envelope-from sunpoet@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1657579114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZCtPyn3On4zmlwiLb8i47vavme1NvaePzDAPxN4FIGo=; b=EzdhPay3NKzgeXoYLbz4//IXEjAK3R5gJFKwov8RFH5ZlvCMahVel9XjraioQAdHJaguUE hBXqGg5wx1BlqZDuGbjd6XUJ+g2hsQaUmEp0gedvVvB0RXqeI11ocW13pvwykm+HwPbYwW sRuKkAqkVlpIEt+3PyGz3P+N1yki0Fwi3pYxT4NTpNQUjioSQiAQ0odAVnwLemeVyng7z9 UYNgqPqFd99hE54As6H/aNURkeIV/1iP0TM95iw2hkc1VOpX3Q9s9xZHAuE3ME3slphAQQ MF6FCzvN+AcxpSHuHJax7oEt80VPyJmo7DZeiANxKImJQ7r+n05LFc7RD2vHJQ== Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Lhf1Q3fctzXsc for ; Mon, 11 Jul 2022 22:38:34 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-qk1-f169.google.com with SMTP id x17so4995707qkh.11 for ; Mon, 11 Jul 2022 15:38:34 -0700 (PDT) X-Gm-Message-State: AJIora/ymCTzoCBYiIfq0CGcec1XDZVKQ1QGZlAYC0kT3qBewKoMty81 GVXoJXyH4K+w/gPB4sN5zmevtN5LdHRvnd+IlwoOUA== X-Google-Smtp-Source: AGRyM1shwr8MbCdxIzrJ3uUsNsI7nOKiQ3xUeIwDv6lJAHNU4KU+YyqX9EsBDH9zWAqi+Z4WqACFgu1m6vTpQBfgS6k= X-Received: by 2002:a05:620a:248b:b0:6af:504d:c1e0 with SMTP id i11-20020a05620a248b00b006af504dc1e0mr13313346qkn.750.1657579113926; Mon, 11 Jul 2022 15:38:33 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202206301432.25UEWIi4077084@gitrepo.freebsd.org> In-Reply-To: From: Po-Chuan Hsieh Date: Tue, 12 Jul 2022 06:37:57 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 4671249405c0 - main - net/rubygem-omniauth-auth0: Fix build failure To: Matthias Fechner Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="00000000000045e9fc05e38f369c" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1657579114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZCtPyn3On4zmlwiLb8i47vavme1NvaePzDAPxN4FIGo=; b=V2idkxUu7OiDmOySCkbSdclZW59HHGVqWvil1aVryq0NMA/N/c4RnIiOEB9nvvjpN/rdZb 7CMRLVzk50tbcByR1df4Ti0mWzxajTnW0bP79bb+TNpXO5lGG7LdMjA1szDcLjOHNNlHEW kiyAPXZ92Q24fF+8HEijbP7+4iqx12sVgY0vkTb9R8mr6q3gOVcrImbbRMuUAz1boygEau 419dvV+Sk12L1ePWGpM5rNIfZbEH7tnZL0CDugy1njF/scFE1kK56BvqFuh7ZFxQCZeZzf zIaHouvGT0kfz46q39XXEn9qShsd813AHQOwj6N4mHS4WldbaRV/OEK9ZDntfA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1657579114; a=rsa-sha256; cv=none; b=RiiWrOsSFUH942ANOUIMhbyfQRgr6hgxaIO6GJqpFa2SsZXWJuEi0VhqszypzfhQeh7mRT DBcp8zGWJ8HOCNnNPCzoSnuR5YpFo+TF6W90MG9ISNrIS5NR1NO3ADCUhq0tGfIivEbcpq 0nQFanc+VCN3vM2tC6SXK7FAWdbkgp1i7WyboRRsRPL6VLX/bnHWUh6ARiO6IypXzbZvVr T4cwOXFEshKhzKRTgEOi6puu7oB1A6YcfTlThBo7USKYbvZOQ27R/XKlYyxzE0B1XE7qN8 wQE3cQM7faDpkGBWbGbyDigb2r2rCglkU5TpERfTFcz0QuQLsteSgNQG7iyVKA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N --00000000000045e9fc05e38f369c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jul 6, 2022 at 11:31 PM Matthias Fechner wrote: > Dear Sunpoet, > > Am 06.07.2022 um 16:35 schrieb Po-Chuan Hsieh: > > On Thu, Jun 30, 2022 at 10:32 PM Matthias Fechner > wrote: > >> The branch main has been updated by mfechner: >> >> URL: >> https://cgit.FreeBSD.org/ports/commit/?id=3D4671249405c05bb65dfec261eb64= 5081ea72fdf5 >> >> commit 4671249405c05bb65dfec261eb645081ea72fdf5 >> Author: Matthias Fechner >> >> AuthorDate: 2022-06-30 14:28:33 +0000 >> Commit: Matthias Fechner >> >> CommitDate: 2022-06-30 14:32:13 +0000 >> >> net/rubygem-omniauth-auth0: Fix build failure > > >> Fixes a build regression after: >> 56e085ca55a831ab56e2e6b417bf230c827fd2e5 >> > > I think this commit is incorrect. > I could build this port successfully with rubygem-omniauth-oauth2 (1.8.0) > Please provide the error message. > > Furthermore, the only difference between omniauth-oauth2 1.7.3 and 1.8.0 > [1] is the change of omniauth from ">=3D1.9<3" to ">=3D2<3" > where security/rubygem-omniauth is 2.1.0 already. > I don't know how it can fix build failure. > > [1] https://github.com/omniauth/omniauth-oauth2/compare/v1.7.3...v1.8.0 > > And this change caused a race in the dependency tree. > > I suggest you build www/gitlab-ce, then you will see the error. > Or you can also search here to find the correct log file: > https://pkg.fechner.net/jail.html?mastername=3D131amd64-default > > Here the direct link to the log: > > https://pkg.fechner.net/build.html?mastername=3D131amd64-default&build=3D= 2022-06-30_10h05m29s > > Resolving dependencies... > Bundler could not find compatible versions for gem "omniauth": > In Gemfile: > omniauth-azure-oauth2 (~> 0.0.9) was resolved to 0.0.10, which depend= s on > omniauth (~> 1.0) > > omniauth-azure-oauth2 (~> 0.0.9) was resolved to 0.0.10, which depend= s on > omniauth-oauth2 (~> 1.4) was resolved to 1.8.0, which depends on > omniauth (~> 2.0) > *** Error code 6 > > This modification was the minimal fix I figured out without the need to > rollback a commit. > OK, the failure is about gitlab-ce but the commit message looks like it causes the build failure of net/rubygem-omniauth-auth0. Anyway, you could try this patch [1]. Then we could drop confusing net/rubygem-omniauth-oauth2-v1. [1] https://people.freebsd.org/~sunpoet/patch/gitlab-ce.txt > >> -RUN_DEPENDS=3D rubygem-omniauth-oauth2>=3D1.1:net/rubygem-omniauth-oa= uth2 >> > > That should be >=3D1.4<2 to match upstream (~> 1.4). > And net/rubygem-omniauth-oauth2 (1.8.0) fits the range. > > +RUN_DEPENDS=3D >> rubygem-omniauth-oauth2-v1>=3D1.4<2:net/rubygem-omniauth-oauth2-v1 >> >> yes and that is what I changed here. > > > Gru=C3=9F > Matthias > > -- > > "Programming today is a race between software engineers striving to > build bigger and better idiot-proof programs, and the universe trying to > produce bigger and better idiots. So far, the universe is winning." -- > Rich Cook > > --00000000000045e9fc05e38f369c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Jul 6, 2022 at 11:31 PM Matthias = Fechner <mfech= ner@freebsd.org> wrote:
=20 =20 =20
Dear Sunpoet,

Am 06.07.2022 um 16:35 schrieb Po-Chuan Hsieh:
=20
On Thu, Jun 30, 2022 at 10:32 PM Matthias Fechner <mfe= chner@freebsd.org> wrote:
The branch main= has been updated by mfechner:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3D4671249405c05bb65dfec261eb6450= 81ea72fdf5

commit 4671249405c05bb65dfec261eb645081ea72fdf5
Author:=C2=A0 =C2=A0 =C2=A0Matthias Fechner <mfechner@FreeBSD.org>
AuthorDate: 2022-06-30 14:28:33 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Matthias Fechner <mfechner@FreeBSD.org>
CommitDate: 2022-06-30 14:32:13 +0000

=C2=A0 =C2=A0 net/rubygem-omniauth-auth0: Fix build failure

=C2=A0 =C2=A0 Fixes a build regression after:
=C2=A0 =C2=A0 56e085ca55a831ab56e2e6b417bf230c827fd2e5

I think this commit is incorrect.
I could build this port successfully=C2=A0with=C2=A0rubygem-omniauth-oauth2 (1.8.0)
Please provide the error=C2=A0message.

Furthermore, the only difference between omniauth-oauth2 1.7.3 and 1.8.0 [1] is the change of=C2=A0omniauth from ">=3D1.9<3" to "&g= t;=3D2<3" where=C2=A0security/rubygem-omniauth is 2.1.0 already.
I don't know how it can fix build failure.

And this change caused a race in the dependency tree.

I suggest you build www/gitlab-ce, then you will see the error.
Or you can also search here to find the correct log file:
https://pkg.fechner.net/jail.html?mastername=3D131= amd64-default

Here the direct link to the log:
https://pkg.fechner.ne= t/build.html?mastername=3D131amd64-default&build=3D2022-06-30_10h05m29s= 

Resolving dependencies...
Bundler could not find compatible versions for gem "omniauth":
  In Gemfile:
    omniauth-azure-oauth2 (~> 0.0.9) was resolved to 0.0.10, which depen=
ds on
      omniauth (~> 1.0)

    omniauth-azure-oauth2 (~> 0.0.9) was resolved to 0.0.10, which depen=
ds on
      omniauth-oauth2 (~> 1.4) was resolved to 1.8.0, which depends on
        omniauth (~> 2.0)
*** Error code 6

This modification was the minimal fix I figured out without the need to rollback a commit.


<= div>OK, the failure is about gitlab-ce but the commit message looks like it= causes the build failure of net/rubygem-omniauth-auth0.

Anyway, you could try this patch [1]. Then we could drop confusing= =C2=A0net/rubygem-omniauth-oauth2-v1.




-RUN_DEPENDS=3D=C2=A0 =C2=A0rubygem-omniauth-oauth2>=3D1.1:net/rubygem-omniauth-oa= uth2

That should be >=3D1.4<2 to match upstream (~> 1.4).
And net/rubygem-omniauth-oauth2 (1.8.0) fits the range.

+RUN_DEPENDS=3D=C2=A0 =C2=A0rubygem-omniauth-oauth2-v1>=3D1.4<2:net/rubygem-omn= iauth-oauth2-v1

yes and that is what I changed here.


Gru=C3=9F
Matthias

--=20

"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs, and the universe trying to
produce bigger and better idiots. So far, the universe is winning." --
Rich Cook
--00000000000045e9fc05e38f369c--