Re: git: 50324bba317c - main - x11/cde: Fix build under 14-CURRENT

From: Alexey Dokuchaev <danfe_at_freebsd.org>
Date: Sun, 13 Feb 2022 05:50:12 UTC
On Sun, Feb 13, 2022 at 01:15:25AM +0000, Cy Schubert wrote:
> commit 50324bba317cf1f58e8c434e0e2ed129cded3887
> 
>  x11/cde: Fix build under 14-CURRENT
>  
>  Under 14-CURRENT MALLOC_PRODUCTION is not set which puts malloc() into
>  debug mode. In debug mode malloc() enables opt.junk to write junk to
>  newly malloc()ed heap in order to help developers discover memory
>  allocation bugs. Unfortunately CDE's dtinfogen assumes newly malloc()ed
>  memory is zero filled (i.e. not filled with junk), resulting in
>  "flex scanner jammed".

Neat investigation, it gives a new angle for looking at -CURRENT-specific
build failures, but why not patch the CDE source code instead?  malloc()
allocates uninitialized memory, it's generally unsafe to assume that it's
zero-filled in the first place.  Also, MAKE_ENV hack is not upstreamable,
I'm afraid. :-)

./danfe