From nobody Sun Feb 13 05:50:12 2022
X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 3BE0A19B12FC;
	Sun, 13 Feb 2022 05:50:12 +0000 (UTC)
	(envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
	 client-signature RSA-PSS (4096 bits) client-digest SHA256)
	(Client CN "freefall.freebsd.org", Issuer "R3" (verified OK))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4JxGfD1Cy3z3hlV;
	Sun, 13 Feb 2022 05:50:12 +0000 (UTC)
	(envelope-from danfe@freebsd.org)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim;
	t=1644731412;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=oshZA43gBqgMM99ZmgjSzp0iDxpg5Z4zj82lWeR/0pw=;
	b=a5R1qKDqDIImYhjebMLwDrS0PPDYYP11GK1N+qHM34Uf3lBNFYeEYx3Yn0LpjIE6+ARXw4
	j2OCVgPKxwEZq8ev/vX6GdCGHD73KXM8KpbH3T60GXyzlCqSfj//FIkQw2K13ia/8OfoB0
	zYNkdhQ/xG1qucIhVZt/7eU67DNIVuxocXOKp8OgxqNfbPZyt70vE9CJVTRmM7zdixsdib
	ypI2iZZajWpaBhX1qqeSAj65Sst0l0fvA6tbAGA43O2WFD5PryWSGR4zC5NibEJsGxUe94
	e1MvVlibgOtIyzFS8TpuUlrVePd2tAbt2Tk9I+Pl6jkCsqo5MfiL2FcDmSKbGQ==
Received: by freefall.freebsd.org (Postfix, from userid 1033)
	id 0C710C99C; Sun, 13 Feb 2022 05:50:12 +0000 (UTC)
Date: Sun, 13 Feb 2022 05:50:12 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Cy Schubert <cy@freebsd.org>
Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org,
	dev-commits-ports-main@freebsd.org
Subject: Re: git: 50324bba317c - main - x11/cde: Fix build under 14-CURRENT
Message-ID: <YgicFDckACibXNUY@FreeBSD.org>
References: <202202130115.21D1FPPu025146@gitrepo.freebsd.org>
List-Id: Commits to the main branch of the FreeBSD ports repository <dev-commits-ports-main.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main
List-Help: <mailto:dev-commits-ports-main+help@freebsd.org>
List-Post: <mailto:dev-commits-ports-main@freebsd.org>
List-Subscribe: <mailto:dev-commits-ports-main+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-ports-main+unsubscribe@freebsd.org>
Sender: owner-dev-commits-ports-main@freebsd.org
X-BeenThere: dev-commits-ports-main@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202202130115.21D1FPPu025146@gitrepo.freebsd.org>
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org;
	s=dkim; t=1644731412;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=oshZA43gBqgMM99ZmgjSzp0iDxpg5Z4zj82lWeR/0pw=;
	b=Fvj0tsms1Va1W1JObv2GGFGAExElINxumyZsb6VM9qsSOx2vjdDq8x6Y9hzW964YEt923u
	Mq30DcAFucnWmj9MYzJLGkrVXUQVLtT7kD/gyF0R+XDhKFUc79iWCtZAiKIoPM4wB82V7A
	cjjxLePSTI5Z7zCpkNZ/Phaxs8ehc4xmNZwE+KAJuBjAWkvEnurvsbW6CvZBgSrWcSgvGF
	H07GxPsRJKgMSDzN9VJryEVtOlH2euGy7AlYvctyfXA5TY2vsnjulu5apZrjUWVrsi0vd2
	4Ajw0bJiF8vgTMPgSvMFonHJCviiZWE/HVcEnpbSl952LSBXM5xi8MsDIUlFlQ==
ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1644731412; a=rsa-sha256; cv=none;
	b=gXRM59kJoel7RvqHtQ/24BFK0Xe63cFJlK6x/0xxmhd94L3U5XfODVig7+PeRZN3nC73jO
	eey1EG1p8x/4oVguaadskaL6fS9gdT08Bcb3wOvNwDILnwIHGsezVrKbmiUXjquGjG6lsj
	5T/eNa4OFIHAptUMEd0ilN3DRncbeVzoLtPrETafuzpDzn3PZOEpL7U6PXkoAKlHBmQHqW
	cT/c1kc5hThSNa2BX+yZ7wI4m4SrLT9BVrbn9HYsnGVBuRZj7nBU2KdIIueXqgGgRlv4md
	FFAMbWQ4wM7U/waQxAUJtVTGXuETctouyDMV4UeedG+oWpDtp+nExp/iITs7LA==
ARC-Authentication-Results: i=1;
	mx1.freebsd.org;
	none
X-ThisMailContainsUnwantedMimeParts: N

On Sun, Feb 13, 2022 at 01:15:25AM +0000, Cy Schubert wrote:
> commit 50324bba317cf1f58e8c434e0e2ed129cded3887
> 
>  x11/cde: Fix build under 14-CURRENT
>  
>  Under 14-CURRENT MALLOC_PRODUCTION is not set which puts malloc() into
>  debug mode. In debug mode malloc() enables opt.junk to write junk to
>  newly malloc()ed heap in order to help developers discover memory
>  allocation bugs. Unfortunately CDE's dtinfogen assumes newly malloc()ed
>  memory is zero filled (i.e. not filled with junk), resulting in
>  "flex scanner jammed".

Neat investigation, it gives a new angle for looking at -CURRENT-specific
build failures, but why not patch the CDE source code instead?  malloc()
allocates uninitialized memory, it's generally unsafe to assume that it's
zero-filled in the first place.  Also, MAKE_ENV hack is not upstreamable,
I'm afraid. :-)

./danfe