Re: git: 5d38de488ba0 - main - devel/gindent: fix build

On Thu, Aug 11, 2022 at 09:02:37AM -0700, Neel Chauhan wrote:
> Hi,
> 
> Sorry for the delay.
> 
> On 2022-08-09 13:49, Fernando Apesteguía wrote:
> > The issue is an unused variable. Wouldn't it be better to fix that
> > instead of removing -Werror? Also sending that upstream would be nice.
> 
> This patch technically came from an outside contributor. I can submit a
> patch to fix this and sent it upstream.

The fact that we are committers mean that we review patchs from outside
contributors and fix/change them to actually fix the problems we have.
If we were simply applying patches without any thought, we could be
replaced by a program called patch, and we would not be needed at all.

-- 
Mathieu Arnold