From nobody Fri Aug 12 08:50:56 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M3y7m3TmLz4ZD2Q; Fri, 12 Aug 2022 08:51:00 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4M3y7m2yYHz3xP8; Fri, 12 Aug 2022 08:51:00 +0000 (UTC) (envelope-from mat@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660294260; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mlqrhD6H7sO35RRn1mzS/H4QOB61t02Ihsc4otlaS1o=; b=ba7YyQWue4LI/u029RygOvJs1VWKkZ7mhQ4MopL8e+Fxsm5Al7UO/vfHxrlohIwD3/+41G tZKrbfje6wuNObkK7uzb+PC5lmzcwlPZxUZvC0p54pyAN+klwa88c0gad4H0Csu4qP4wmy +PiR2+mFknNOttSRkgQ9wKQXN34mJw+OQ3Ikikg7tonD4rLB50e7qS+F1sXblND+SAmpzh XT9lCguH4E/sqzJaYfWqhFEC3JswbYE7Y7dEI7kOoRF2u6u/ne+r2/UvrxA0sXP50PwBtO z5DjWFAwAcV6MWVjGxVYafb8N4btJyAISd2J8PFN/IQ5pu/AxWNN1/aI5wiPgw== Received: from mail.j.mat.cc (owncloud.cube.mat.cc [IPv6:2a01:678:4:1::228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail.mat.cc", Issuer "R3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4M3y7m1RTVz1DrK; Fri, 12 Aug 2022 08:51:00 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:e0a:836:f670:1e39:6b12:5f77:a6a9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id CEB11942D81; Fri, 12 Aug 2022 08:50:57 +0000 (UTC) Date: Fri, 12 Aug 2022 10:50:56 +0200 From: Mathieu Arnold To: Neel Chauhan Cc: Fernando =?utf-8?Q?Apestegu=C3=ADa?= , "ports-committers@FreeBSD.org" , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 5d38de488ba0 - main - devel/gindent: fix build Message-ID: <20220812085056.cdj6chb5bnowemoc@aching.in.mat.cc> References: <202208092050.279Ko76l093213@gitrepo.freebsd.org> <7f81101cb04541949f4c7c54505c2349@FreeBSD.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dzac3qen2mcxeuyb" Content-Disposition: inline In-Reply-To: <7f81101cb04541949f4c7c54505c2349@FreeBSD.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660294260; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mlqrhD6H7sO35RRn1mzS/H4QOB61t02Ihsc4otlaS1o=; b=AgKSG+wMQg+LrNvOMNOvVvujAWrLtOjR2ce7pQzonfEOPbe3TX3+2VHWgCPtezOjTSPcQY 8Z3uMfFAViGJsNr2plqT4j7ixTj/ZXuE5g0frEhzsAKjt2QSCjR5Le6OOIbehd0+K2RBd6 agPznmZV3ytgCLNigjTgw325Uay7+E0JdjAIyBTZnj0ea4YrBwYlxKVJ/Ke75xMHzFmNUA St85qv2oiWN1VTVUSQnajn9Gpw1wOIYHiuultCO81ssWMl99ujgdbWo4OzX9S1KTt5LyVW nr0a+o7vh6mRXWC52qi4O63kqMd8jivQuutz6F4QhI9lv64RQLqP6M9U/YpajA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1660294260; a=rsa-sha256; cv=none; b=gckti0mNWzAMdJuNNGaspJjCWOlLEHnk8gPSPz4ZntyOuaixoAiHURE4lzsNAvObsObktq L4o6ZVhd/IREL9L56Tfak8Rz30LKZ3a1Nsl11VlLlNuCuq0PSNazKxnucsUDxWr5ShLR5H 2o3aDRlgcfDeaLW8p4BOdVrU8N9Vt/ZvogVHMimVr+R2QWYaHcGBZYxEnFR+vxzhOtS0M8 3odrG8qg7On79eJmf57iomeuJSSMjbSRHXJmJWncm9wytRtEi0OGujlVgt6Qjo+sycl1t+ dIDQANpjfZRGU9Yl3fEhyE+EE2kKl89c+mjDlhjfwI2HaGKyle5MXbjykc0Gsg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N --dzac3qen2mcxeuyb Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 11, 2022 at 09:02:37AM -0700, Neel Chauhan wrote: > Hi, >=20 > Sorry for the delay. >=20 > On 2022-08-09 13:49, Fernando Apestegu=EDa wrote: > > The issue is an unused variable. Wouldn't it be better to fix that > > instead of removing -Werror? Also sending that upstream would be nice. >=20 > This patch technically came from an outside contributor. I can submit a > patch to fix this and sent it upstream. The fact that we are committers mean that we review patchs from outside contributors and fix/change them to actually fix the problems we have. If we were simply applying patches without any thought, we could be replaced by a program called patch, and we would not be needed at all. --=20 Mathieu Arnold --dzac3qen2mcxeuyb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAABCgB9FiEEFD4jMKwz5Ud8Ywu3ecmT/A9inX0FAmL2FGRfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDE0 M0UyMzMwQUMzM0U1NDc3QzYzMEJCNzc5Qzk5M0ZDMEY2MjlEN0QACgkQecmT/A9i nX3c7gf/Q8HUjgWiaq5OofPDRQN701t8PvjFGpkHccXiNPmk+4sykLGa3e1/KhsK p3eHureUDMLQIWCXWPVKDGEw5bqFaAmaMlIsVojEhLT6r5/g+cv3q0qgffPz1AX9 dS2fTLQ7EMtFaEhff7lEvdAkq1mhpKdm40+z9UzYaMTGR/OwU1zyj1iqwIWVYzUg yE+5d5QPFJrpfnOfeudYCQh9MI94Sp//zAxwMCSLUbKR92wFMTrG9r4xKGYfAJXm 6QxN0ASz0JQRzaEHgafdTHAPNaHHNYVIMw6b422IzfrP8J0mabpCn7r6d4yeEUgB d0aMiqx/81mG3R3POuT33/f7dgchOg== =U976 -----END PGP SIGNATURE----- --dzac3qen2mcxeuyb--