Re: git: 5d38de488ba0 - main - devel/gindent: fix build

On Tue, Aug 9, 2022 at 10:50 PM Neel Chauhan <nc@freebsd.org> wrote:
>
> The branch main has been updated by nc:
>
> URL: https://cgit.FreeBSD.org/ports/commit/?id=5d38de488ba0413c33ba55cf368c6dc4575c8cf3
>
> commit 5d38de488ba0413c33ba55cf368c6dc4575c8cf3
> Author:     Robert Clausecker <fuz@fuz.su>
> AuthorDate: 2022-07-30 03:44:27 +0000
> Commit:     Neel Chauhan <nc@FreeBSD.org>
> CommitDate: 2022-08-09 20:48:50 +0000
>
>     devel/gindent: fix build
>
>     Remove -Werror as per policy.
>
>     PR:             265510
>     Approved by:    Robert Clausecker <moritz AT schmi DOT tt> (maintainer)
>     MFH:            2022Q3 (build fix blanket)
> ---
>  devel/gindent/files/patch-src_Makefile.in | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/devel/gindent/files/patch-src_Makefile.in b/devel/gindent/files/patch-src_Makefile.in
> new file mode 100644
> index 000000000000..c424b1fc4d6c
> --- /dev/null
> +++ b/devel/gindent/files/patch-src_Makefile.in
> @@ -0,0 +1,11 @@
> +--- src/Makefile.in.orig       2022-07-30 03:38:42 UTC
> ++++ src/Makefile.in
> +@@ -352,7 +352,7 @@ EXTRA_DIST = @PACKAGE@.gperf @PACKAGE@-cc.gperf wildex
> + BUILT_SOURCES = gperf.c gperf-cc.c
> + AM_CPPFLAGS = -I. -I$(srcdir) -I$(top_srcdir)/intl
> + MAINTAINERCLEANFILES = Makefile.in libgettext.h
> +-AM_CFLAGS = -Wall -W -Werror -Wredundant-decls -Wshadow \
> ++AM_CFLAGS = -Wall -W -Wredundant-decls -Wshadow \

The issue is an unused variable. Wouldn't it be better to fix that
instead of removing -Werror? Also sending that upstream would be nice.

> +       -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs \
> +       -Wmissing-declarations -Wcomment -Wbad-function-cast \
> +       -Wcast-align $(am__append_1)