From nobody Tue Aug 09 20:49:20 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M2QHb0hsbz4Y44Y; Tue, 9 Aug 2022 20:52:27 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4M2QHZ0S9Zz3ss8; Tue, 9 Aug 2022 20:52:26 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: by mail-ej1-x629.google.com with SMTP id gk3so24277551ejb.8; Tue, 09 Aug 2022 13:52:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=GiKnr8HAtT4QMjtXLEs5eOHvf4YxXoq37ipCSsUAc0k=; b=RN8rSbEZ1q7B4DdmhO7nEscnN1lvZksXXite11cWXEt2Ls68LQVFCp0oqL6KLjPbxp xzA8rLf6LyQn8AhcglhVolYIDeRNFmFHv5wIATBsTbg6vDG3nkxEic2bbrPKDZLffiva ZZndiD7x0noftUbJ41gn9PeOJlVU5kD0tv6aKa8AUVr1fHFXS6gkBITS3tAD3OIhVXzm R1PAncR3IYGKgVHpUgi1kZmblf02GL1E9H/7v78Ff0WF+8QEu7NK4k4IyYSowahiCCAk YMevQmsm5bbdgWhHA4yYd2Y3WlC2ttycooX6zfg4hlMhUeLjFxU6vV+ov3MUsQTYlMXx Gugg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=GiKnr8HAtT4QMjtXLEs5eOHvf4YxXoq37ipCSsUAc0k=; b=6x/rmIH5cZLxh7yjEAsv/IUHSx6ZIlGYHU8Qua5S71GAq2T/w95qduiLv92BhFmxoK DbJlTvTTw1BFxPHRQQ16zhCfOUugtC57uUOn/yrJGHOpINs6nLHo3U3luKSwZbA9WmFJ bcfQdNtk/sVHAsBpCDdPyHYYqwZsQ5Gz8wesE3Gb6rvcUjLyDTi9+VPvxUA0wDni/ha9 7LTi+XcqNIki28azPT/d7Vsex0hnfDFLjWSgwgeJTIvoDd13yllqyLKqs2wo8FCAHyPB IHXJJXe/KGxy0A4FG0ZVHIVBBGXRpRIwA6npxrMLBIT+cSL0v5LdDF8Z0Qcr4RMq0TFY bshA== X-Gm-Message-State: ACgBeo3MGUjrldvukYRwbFUO/V127ZGRjWf5ZQIGrGiPGB05IXnYleiy 1qElPLovo7YSiQWAw5MitrcVaPYfSAulEW7Bv5TxkdwbbsM= X-Google-Smtp-Source: AA6agR6/EXPq+nCb4ketoUQMGd1c0c5IGfkwPtDNT3602+HRfcSOjebcO+gKfZZNSz0Q8MokZe0JWhaZyomvSCpRvjE= X-Received: by 2002:a17:906:974d:b0:732:e3d8:ec6c with SMTP id o13-20020a170906974d00b00732e3d8ec6cmr3260240ejy.602.1660078343928; Tue, 09 Aug 2022 13:52:23 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202208092050.279Ko76l093213@gitrepo.freebsd.org> In-Reply-To: <202208092050.279Ko76l093213@gitrepo.freebsd.org> From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Date: Tue, 9 Aug 2022 22:49:20 +0200 Message-ID: Subject: Re: git: 5d38de488ba0 - main - devel/gindent: fix build To: Neel Chauhan Cc: "ports-committers@FreeBSD.org" , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4M2QHZ0S9Zz3ss8 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=RN8rSbEZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of fernando.apesteguia@gmail.com designates 2a00:1450:4864:20::629 as permitted sender) smtp.mailfrom=fernando.apesteguia@gmail.com X-Spamd-Result: default: False [-3.76 / 15.00]; NEURAL_HAM_LONG(-1.00)[-0.997]; NEURAL_HAM_SHORT(-0.97)[-0.971]; NEURAL_HAM_MEDIUM(-0.79)[-0.794]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::629:from]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; MLMMJ_DEST(0.00)[dev-commits-ports-all@freebsd.org,dev-commits-ports-main@freebsd.org]; MID_RHS_MATCH_FROMTLD(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; TAGGED_FROM(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_TLS_LAST(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2] X-ThisMailContainsUnwantedMimeParts: N On Tue, Aug 9, 2022 at 10:50 PM Neel Chauhan wrote: > > The branch main has been updated by nc: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=5d38de488ba0413c33ba55cf368c6dc4575c8cf3 > > commit 5d38de488ba0413c33ba55cf368c6dc4575c8cf3 > Author: Robert Clausecker > AuthorDate: 2022-07-30 03:44:27 +0000 > Commit: Neel Chauhan > CommitDate: 2022-08-09 20:48:50 +0000 > > devel/gindent: fix build > > Remove -Werror as per policy. > > PR: 265510 > Approved by: Robert Clausecker (maintainer) > MFH: 2022Q3 (build fix blanket) > --- > devel/gindent/files/patch-src_Makefile.in | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/devel/gindent/files/patch-src_Makefile.in b/devel/gindent/files/patch-src_Makefile.in > new file mode 100644 > index 000000000000..c424b1fc4d6c > --- /dev/null > +++ b/devel/gindent/files/patch-src_Makefile.in > @@ -0,0 +1,11 @@ > +--- src/Makefile.in.orig 2022-07-30 03:38:42 UTC > ++++ src/Makefile.in > +@@ -352,7 +352,7 @@ EXTRA_DIST = @PACKAGE@.gperf @PACKAGE@-cc.gperf wildex > + BUILT_SOURCES = gperf.c gperf-cc.c > + AM_CPPFLAGS = -I. -I$(srcdir) -I$(top_srcdir)/intl > + MAINTAINERCLEANFILES = Makefile.in libgettext.h > +-AM_CFLAGS = -Wall -W -Werror -Wredundant-decls -Wshadow \ > ++AM_CFLAGS = -Wall -W -Wredundant-decls -Wshadow \ The issue is an unused variable. Wouldn't it be better to fix that instead of removing -Werror? Also sending that upstream would be nice. > + -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs \ > + -Wmissing-declarations -Wcomment -Wbad-function-cast \ > + -Wcast-align $(am__append_1)