Re: git: 2bc3e6229feb - main - net-im/telegram-desktop: Update to 3.1.9
Date: Thu, 14 Oct 2021 01:00:56 UTC
On Wed, Oct 13, 2021 at 2:19 PM Po-Chuan Hsieh <sunpoet@freebsd.org> wrote: > On Thu, Oct 14, 2021 at 1:31 AM Dima Panov <fluffy@freebsd.org> wrote: > > > Moin! > > > > Have tested the almost same patch. > > Small suggestions: > > > > GTK_USE= GNOME=cairo gtk30 > > > > Do you mean "GTK_USE= GNOME=cairo,gtk30" (use comma instead of space)? > Why do we need to add cairo? > > GTK_DESC= WebKit-gtk integration > > > > -- > > Dima. (desktop, kde, x11, office, ports-secteam)@FreeBSD team > > (fluffy@FreeBSD.org, https://t.me/dima_panov) > > > > On Wednesday, Oct 13, 2021 at 8:15 PM, Sergey A. Osokin <osa@freebsd.org > > > > wrote: > > Well, I'm not totally sure is my approach is corrent, but here's the > > patch returning back GTK staff. Please be aware: it wasn't tested yet. > > > Thanks for your patch! May I suggest naming the new option "WEBKITGTK", because the main point of the option is to use webkit-gtk? > -- > > Sergey Osokin > > > > On Tue, Oct 12, 2021 at 02:31:35PM +0000, Alexey Dokuchaev wrote: > > > > On Tue, Oct 12, 2021 at 01:57:39PM +0000, Li-Wen Hsu wrote: > > > > commit 2bc3e6229febd07dd7f2980cb7065573d689a0f5 > > > > net-im/telegram-desktop: Update to 3.1.9 > > > > > > Thanks for updating the port, however... > > > > ... > > @@ -40,6 +39,7 @@ LIB_DEPENDS= libavformat.so:multimedia/ffmpeg \ > > libpipewire-0.3.so:multimedia/pipewire \ > > libqrcodegencpp.so:graphics/qr-code-generator \ > > libusrsctp.so:net/libusrsctp \ > > + libwebkit2gtk-4.0.so:www/webkit2-gtk3 \ > > > > > > Commit log does not explain why would light-weight chat program would now > > unconditionally depend on this admittedly quite heavy component. Well, the older option (GTK) depended on a CMake option DISABLE_GTK_INTEGRATION. That option has been deleted, so I removed it. I noticed later that now there's a new option (DISABLE_WEBKITGTK) to disable the usage of webkit-gtk, and a new option can be added for it. Still, we may still want to enable it by default. telegram-desktop uses webkit-gtk by default. Currently it is only used for payments, but maybe for other functionalities in the future. I think users would expect the default build to have all available functionalities. > > > @@ -52,9 +52,10 @@ USE_GITHUB= nodefault > > GH_ACCOUNT= telegramdesktop > > GH_PROJECT= tdesktop > > USE_GL= gl > > -USE_GNOME= glib20 glibmm > > +USE_GNOME= glib20 glibmm gtk30 > > > > > > Nor does it explain why Qt-based program now unconditionally requires > GTK. > Well this is brought in by the same webkit-gtk dependency. Disabling webkit-gtk would disable this. > > > +INSTALLS_ICONS= yes > > > > > > Please also see the latest CHANGES entry. > > > > ./danfe > > > > > -- Cheers, Henry