From nobody Thu Oct 14 01:00:56 2021 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 0336217F5782; Thu, 14 Oct 2021 01:01:51 +0000 (UTC) (envelope-from henry.hu.sh@gmail.com) Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HVB1p6HqDz3DLb; Thu, 14 Oct 2021 01:01:50 +0000 (UTC) (envelope-from henry.hu.sh@gmail.com) Received: by mail-lf1-x12e.google.com with SMTP id x27so19733737lfu.5; Wed, 13 Oct 2021 18:01:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pkz0RZ7/zZKOgaifg9w1D7Lo8X1Rd/VlrMhphLML4CA=; b=qGGQnPwWFLYS+3ZuLPSEVn1Y9w1QZ6zf3zrn1CHKohRiDuhLGK2aJhOveFGRmACuj1 kTDd0DqcL19H7QqM6tX6B3VC+bKuajnbSNdrWu5cNaBlvCpzvLOV43sDCvbK++7FD02s 7q9AUxyozaDYrhl3aAm+2y36n6OCev78vP4joamrPI2AA2u0Rf6WDTanZRJvZaRu3WmU D6mtPQOeqRvwQ7R5slRmgi3vdb1RiSxNBhimIAnSEWHCeWKkSxBm2RjBCu2r+2sGJrUQ ddtaD+odtlV5OeuD/F8hvocu/hoBwoGZvNjxFxIjfZ2cU9m5m9VWJUdVb/qdutVdpmgi e+Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pkz0RZ7/zZKOgaifg9w1D7Lo8X1Rd/VlrMhphLML4CA=; b=rCvBm89kEFZkhYcVL2YCJkPT8JcE0lgDVa9r6R6E7dObcHkNOmIrwNQNnqLUhNQZvl qVgS4+RC53RCIm0I35wey/WoA8OaXGTiMXcW1v+R8beyLQOU+//H0XiyVwFyBMagiI90 96CBm3i89umxknJ66osJEZHeJOmWOrB4GhLpFxmn7ollbgYou/VVc04bECOBcjEl+qST FVW4QT7aZJAoFtjx9UyCi/SlmxGfr8C+ANFfMniAEqsdzp3RjInAo53uVJ6pgxRb+0me pdi7wT8+dd84xIluOcPNtoAuSFUSZE1K41rH7xdqxQrZBenRBDqcBqDwU1x+fka3g3Sl m9/g== X-Gm-Message-State: AOAM532vNRuN3eC992Pfq6gPlOEFtoJjYvSeSGAMWsI8WrnLhLoN5sD+ IAtJSCDYdqkC3tPcrRg99RWp6MZji9vxcY3rYsJzjUdy3Tc= X-Google-Smtp-Source: ABdhPJziK7mCx1jnWsUB35xWBKiRjpSUX29+PpJ4meqYtKuv6tiehp51UYQ8qtvUM8gtCHPGzypqCtLqjQSAH0A4GU4= X-Received: by 2002:a05:6512:1116:: with SMTP id l22mr2250894lfg.454.1634173308302; Wed, 13 Oct 2021 18:01:48 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202110121357.19CDvdWN002446@gitrepo.freebsd.org> <09c5ed72-fded-4282-b49f-6d494dff88b8@Canary> In-Reply-To: From: Henry Hu Date: Wed, 13 Oct 2021 21:00:56 -0400 Message-ID: Subject: Re: git: 2bc3e6229feb - main - net-im/telegram-desktop: Update to 3.1.9 To: Po-Chuan Hsieh Cc: Dima Panov , Alexey Dokuchaev , Li-Wen Hsu , "Sergey A. Osokin" , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, ports-committers@freebsd.org Content-Type: multipart/alternative; boundary="0000000000008afaa905ce459f38" X-Rspamd-Queue-Id: 4HVB1p6HqDz3DLb X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-Spam: Yes X-ThisMailContainsUnwantedMimeParts: N --0000000000008afaa905ce459f38 Content-Type: text/plain; charset="UTF-8" On Wed, Oct 13, 2021 at 2:19 PM Po-Chuan Hsieh wrote: > On Thu, Oct 14, 2021 at 1:31 AM Dima Panov wrote: > > > Moin! > > > > Have tested the almost same patch. > > Small suggestions: > > > > GTK_USE= GNOME=cairo gtk30 > > > > Do you mean "GTK_USE= GNOME=cairo,gtk30" (use comma instead of space)? > Why do we need to add cairo? > > GTK_DESC= WebKit-gtk integration > > > > -- > > Dima. (desktop, kde, x11, office, ports-secteam)@FreeBSD team > > (fluffy@FreeBSD.org, https://t.me/dima_panov) > > > > On Wednesday, Oct 13, 2021 at 8:15 PM, Sergey A. Osokin > > > wrote: > > Well, I'm not totally sure is my approach is corrent, but here's the > > patch returning back GTK staff. Please be aware: it wasn't tested yet. > > > Thanks for your patch! May I suggest naming the new option "WEBKITGTK", because the main point of the option is to use webkit-gtk? > -- > > Sergey Osokin > > > > On Tue, Oct 12, 2021 at 02:31:35PM +0000, Alexey Dokuchaev wrote: > > > > On Tue, Oct 12, 2021 at 01:57:39PM +0000, Li-Wen Hsu wrote: > > > > commit 2bc3e6229febd07dd7f2980cb7065573d689a0f5 > > > > net-im/telegram-desktop: Update to 3.1.9 > > > > > > Thanks for updating the port, however... > > > > ... > > @@ -40,6 +39,7 @@ LIB_DEPENDS= libavformat.so:multimedia/ffmpeg \ > > libpipewire-0.3.so:multimedia/pipewire \ > > libqrcodegencpp.so:graphics/qr-code-generator \ > > libusrsctp.so:net/libusrsctp \ > > + libwebkit2gtk-4.0.so:www/webkit2-gtk3 \ > > > > > > Commit log does not explain why would light-weight chat program would now > > unconditionally depend on this admittedly quite heavy component. Well, the older option (GTK) depended on a CMake option DISABLE_GTK_INTEGRATION. That option has been deleted, so I removed it. I noticed later that now there's a new option (DISABLE_WEBKITGTK) to disable the usage of webkit-gtk, and a new option can be added for it. Still, we may still want to enable it by default. telegram-desktop uses webkit-gtk by default. Currently it is only used for payments, but maybe for other functionalities in the future. I think users would expect the default build to have all available functionalities. > > > @@ -52,9 +52,10 @@ USE_GITHUB= nodefault > > GH_ACCOUNT= telegramdesktop > > GH_PROJECT= tdesktop > > USE_GL= gl > > -USE_GNOME= glib20 glibmm > > +USE_GNOME= glib20 glibmm gtk30 > > > > > > Nor does it explain why Qt-based program now unconditionally requires > GTK. > Well this is brought in by the same webkit-gtk dependency. Disabling webkit-gtk would disable this. > > > +INSTALLS_ICONS= yes > > > > > > Please also see the latest CHANGES entry. > > > > ./danfe > > > > > -- Cheers, Henry --0000000000008afaa905ce459f38--