Re: git: cc1054f95110 - main - sysutils/oc: Update to use personal fork of oc

From: Jan Beich <jbeich_at_FreeBSD.org>
Date: Wed, 15 Dec 2021 05:44:26 UTC
John Hixson <jhixson@freebsd.org> writes:

> On Wed, Dec 15, 2021 at 02:19:38AM +0000, Alexey Dokuchaev wrote:
>
>> On Wed, Dec 15, 2021 at 01:29:44AM +0000, John Hixson wrote:
>> > commit cc1054f951104c0404446bc0787de6e3399c4a66
>> > 
>> >     sysutils/oc: Update to use personal fork of oc
>> 
>> Why?  Please don't just translate the diff into English, you have to
>> explain the changes, esp. dubious ones like this.
>
> My apologies. I will write better commit messages. Fetching keeps
> breaking because the downloadable tarball keeps changing. I beleive it's
> from forced pushes and commits changing. I can track it with my own fork
> so that it doesn't keep changing and breaking. Is this practice frowned
> upon ? I'm happy to do this another way.

AFAIK, updating tags doesn't require a forced push. Maybe you have bugs:
- GIT_COMMIT isn't actually used
- release-4.9 is not a tag but a branch (moving target)
- no tags were made from release-4.9 branch, see https://github.com/openshift/oc/tags

$ git describe --tags --always origin/release-4.9
openshift-clients-4.6.0-202006250705.p0-539-g96e95cef8

diff --git a/sysutils/oc/Makefile b/sysutils/oc/Makefile
index 4ad31ac9a925..277d5b7f1e20 100644
--- a/sysutils/oc/Makefile
+++ b/sysutils/oc/Makefile
@@ -1,8 +1,8 @@
 # Created by: John Hixson <jhixson@freebsd.org>
 
 PORTNAME=	oc
-PORTVERSION=	4.9
-DISTVERSIONPREFIX=	release-
+DISTVERSIONPREFIX=	openshift-clients-
+DISTVERSION=	4.9.0-20210901
 CATEGORIES=	sysutils
 
 MAINTAINER=	jhixson@freebsd.org
@@ -24,8 +24,7 @@ PLIST_FILES=	bin/oc
 USE_GITHUB=	yes
 GH_ACCOUNT=	openshift
 GH_SUBDIR=	src/github.com/openshift/oc
-
-GIT_COMMIT=	ddd7170fca667fef6397f5f27f7a5a41d7769b75
+GH_TAGNAME=	96e95cef877ba04872b88e4e2597eabb0174d182
 
 GH_TUPLE=	\
 		AaronO:go-git-http:1d9485b3a98f:aarono_go_git_http/vendor/github.com/AaronO/go-git-http \
diff --git a/sysutils/oc/distinfo b/sysutils/oc/distinfo
index 0a34ca0d8312..9526305fd808 100644
--- a/sysutils/oc/distinfo
+++ b/sysutils/oc/distinfo
@@ -1,6 +1,6 @@
 TIMESTAMP = 1639442474
-SHA256 (openshift-oc-release-4.9_GH0.tar.gz) = 10edd4b2973cdc5540f97c2fb901413e2c64cc000b195b79c34c41faa24e900b
-SIZE (openshift-oc-release-4.9_GH0.tar.gz) = 12050543
+SHA256 (openshift-oc-openshift-clients-4.9.0-20210901-96e95cef877ba04872b88e4e2597eabb0174d182_GH0.tar.gz) = 78da3fa76cf289c850e3aa9bb67e8800649894d1ae6964f57f87b259416ee4bc
+SIZE (openshift-oc-openshift-clients-4.9.0-20210901-96e95cef877ba04872b88e4e2597eabb0174d182_GH0.tar.gz) = 12050783
 SHA256 (AaronO-go-git-http-1d9485b3a98f_GH0.tar.gz) = b2ead4fbef06da604c0ec6e2a73bf9cf1ef2048f716c536277b32e473853e735
 SIZE (AaronO-go-git-http-1d9485b3a98f_GH0.tar.gz) = 24051
 SHA256 (Azure-go-ansiterm-d185dfc1b5a1_GH0.tar.gz) = 1a061bad3379d8f955a3c2bd34c2927f2e561e7a11418dda2927eb222e3cbbc5