From nobody Wed Dec 15 05:44:26 2021 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4432D18F0332; Wed, 15 Dec 2021 05:44:31 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JDPMM1RG9z3PvH; Wed, 15 Dec 2021 05:44:31 +0000 (UTC) (envelope-from jbeich@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1639547071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vg1IIJabTSInZfZjF8mOCQ0UDD50TzduwtyBSVhmfu8=; b=ENUKDkozpIj8FvJVeacXJgtm2W25JPWAEACdgTePIjo0iRLV39Q0dqpI2ZS0/EX7J40Wqs o2mz7Ga5r0rYSEfNtQYYwZS/EpYrs9zZeyQcpCs0cxk9gt3rUteajwM6MgzYxbMigKZq0V N0YgHGdub81X7UUzUci8PCwhGun4bxcEmxuVmEbRBWpMYquTXebw8qN00rJVuCpUiDvD9L Yy41+ShbO63mySfZWUal7RVuBgsehL8giWL6h7EwY5/Bfhgd/rIBtV9KOQFFpeiwIaZ+cb hSwhLXAGXg3UnWlyizxt9EJlEwK2hb5cvDO5RtBcqEO4UCFoXEz4gc9CKWdUcw== Received: by freefall.freebsd.org (Postfix, from userid 1354) id 107653E4B; Wed, 15 Dec 2021 05:44:31 +0000 (UTC) From: Jan Beich To: John Hixson Cc: Alexey Dokuchaev , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: cc1054f95110 - main - sysutils/oc: Update to use personal fork of oc References: <202112150129.1BF1TiVb091373@gitrepo.freebsd.org> Date: Wed, 15 Dec 2021 06:44:26 +0100 In-Reply-To: (John Hixson's message of "Tue, 14 Dec 2021 20:06:04 -0800") Message-ID: List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1639547071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vg1IIJabTSInZfZjF8mOCQ0UDD50TzduwtyBSVhmfu8=; b=el08b68OKqCascr3q+8QPeW/t65k0wy0mITHYBKxAEX1xzha2XGCEH8c59R8iPYvwQXXxx PVskbrXwiDaVuBD2iEwFUJMSwBuWO7v/EVFLDZApwYl1LOimBR4UumDAJX4TrV26baykjQ lMV8e052DjBJFFkrzctCEQWwCRG0usjgnxqvp96w5NBp40A7g6MH2LjpqygZ7Xu4ZFIizx yoiyYEKCLhoOHS/pNKfLpYULbhT76h64GDSMqC0fp8ppcUPDVOULDwtNumZa4y2vI8+kLI OE4+yYWwN8glyVqU/OqhlHs82YwFXF3eAbceV1Lfu9aJ2oY/fY+ZSHnaI3mmkg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1639547071; a=rsa-sha256; cv=none; b=Zn7ArqeHgHxMkqmmZFvtli2EGJRr9+HJZRchuBE1sDQHkzBVH2Qpr/1sQ41TSgu2tnvXAb GA47tZr1ztnr39l2PJko+sZAE5+52RzIs6H4OjBHgetMhMHz7wFaeDUe4DpyRLMZrfXpqQ qgDCGnDxoXlbH4E/3dOtmTG6uZsDmLU39B8ITwno/3hNWlcigcvgW8U8XUG16FkUvJx+RD 7hbPrRuhPBaHZsVRA2dAA+SW/OuArDTaOv/13sHpCt2Nk2/ro0xGmL1BcyrOwEILnt43ZL t36jjyG20y5Obd3YtXDp+diQFch4pDGTkdE/YKR4SikCB5/z7PGFLUYisLY0bw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N John Hixson writes: > On Wed, Dec 15, 2021 at 02:19:38AM +0000, Alexey Dokuchaev wrote: > >> On Wed, Dec 15, 2021 at 01:29:44AM +0000, John Hixson wrote: >> > commit cc1054f951104c0404446bc0787de6e3399c4a66 >> > >> > sysutils/oc: Update to use personal fork of oc >> >> Why? Please don't just translate the diff into English, you have to >> explain the changes, esp. dubious ones like this. > > My apologies. I will write better commit messages. Fetching keeps > breaking because the downloadable tarball keeps changing. I beleive it's > from forced pushes and commits changing. I can track it with my own fork > so that it doesn't keep changing and breaking. Is this practice frowned > upon ? I'm happy to do this another way. AFAIK, updating tags doesn't require a forced push. Maybe you have bugs: - GIT_COMMIT isn't actually used - release-4.9 is not a tag but a branch (moving target) - no tags were made from release-4.9 branch, see https://github.com/openshift/oc/tags $ git describe --tags --always origin/release-4.9 openshift-clients-4.6.0-202006250705.p0-539-g96e95cef8 diff --git a/sysutils/oc/Makefile b/sysutils/oc/Makefile index 4ad31ac9a925..277d5b7f1e20 100644 --- a/sysutils/oc/Makefile +++ b/sysutils/oc/Makefile @@ -1,8 +1,8 @@ # Created by: John Hixson PORTNAME= oc -PORTVERSION= 4.9 -DISTVERSIONPREFIX= release- +DISTVERSIONPREFIX= openshift-clients- +DISTVERSION= 4.9.0-20210901 CATEGORIES= sysutils MAINTAINER= jhixson@freebsd.org @@ -24,8 +24,7 @@ PLIST_FILES= bin/oc USE_GITHUB= yes GH_ACCOUNT= openshift GH_SUBDIR= src/github.com/openshift/oc - -GIT_COMMIT= ddd7170fca667fef6397f5f27f7a5a41d7769b75 +GH_TAGNAME= 96e95cef877ba04872b88e4e2597eabb0174d182 GH_TUPLE= \ AaronO:go-git-http:1d9485b3a98f:aarono_go_git_http/vendor/github.com/AaronO/go-git-http \ diff --git a/sysutils/oc/distinfo b/sysutils/oc/distinfo index 0a34ca0d8312..9526305fd808 100644 --- a/sysutils/oc/distinfo +++ b/sysutils/oc/distinfo @@ -1,6 +1,6 @@ TIMESTAMP = 1639442474 -SHA256 (openshift-oc-release-4.9_GH0.tar.gz) = 10edd4b2973cdc5540f97c2fb901413e2c64cc000b195b79c34c41faa24e900b -SIZE (openshift-oc-release-4.9_GH0.tar.gz) = 12050543 +SHA256 (openshift-oc-openshift-clients-4.9.0-20210901-96e95cef877ba04872b88e4e2597eabb0174d182_GH0.tar.gz) = 78da3fa76cf289c850e3aa9bb67e8800649894d1ae6964f57f87b259416ee4bc +SIZE (openshift-oc-openshift-clients-4.9.0-20210901-96e95cef877ba04872b88e4e2597eabb0174d182_GH0.tar.gz) = 12050783 SHA256 (AaronO-go-git-http-1d9485b3a98f_GH0.tar.gz) = b2ead4fbef06da604c0ec6e2a73bf9cf1ef2048f716c536277b32e473853e735 SIZE (AaronO-go-git-http-1d9485b3a98f_GH0.tar.gz) = 24051 SHA256 (Azure-go-ansiterm-d185dfc1b5a1_GH0.tar.gz) = 1a061bad3379d8f955a3c2bd34c2927f2e561e7a11418dda2927eb222e3cbbc5