Re: git: 6c458c3785df - main - lang/quickjs-ng: add a new port quickjs-ng
- In reply to: Sergey A. Osokin: "Re: git: 6c458c3785df - main - lang/quickjs-ng: add a new port quickjs-ng"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 28 Jan 2025 22:30:42 UTC
On 2025-01-28T23:14:36.000+01:00, Sergey A. Osokin <osa@freebsd.org> wrote: > Hi Daniel, > > thanks for the report. > > On Tue, Jan 28, 2025 at 10:29:44PM +0100, Daniel Engberg wrote: >> On 2025-01-28T22:03:36.000+01:00, Sergey A. Osokin >> <osa@FreeBSD.org> >> >> wrote: >> >>> The branch main has been updated by osa: > > [new port has been added, skipped] > >> Please review the USE_GITHUB section in Porters Handbook and >> follow >> >> the examples (use of variables and ordering) >> >> USES contains multiple entries of cmake >> >> USES contains tar:xz (incorrect) >> >> Please sort USES alphabetically > > I've create the following patch, based on your and the Porters > > Handbook recommendations. Could you please review the changes, > > thanks. > >> Fails to build when CPUTYPE is set to znver3 , znver4, haswell to >> >> menton a few > > I do not have access to such platforms to test a build. Feel > > free to update the port with the list of supported or failed > > platform. > > Thank you once again. > > -- > > Sergey A. Osokin Hi, USES looks ok, https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github DISTVERSION and DISTVERSIONPREFIX should be used (example 16) GH_PROJECT isn't neeed (see Table 5) It fails on any platform that enables AVX2 ( __AVX2__) If you comment L31 and L32 it at least compiles https://github.com/quickjs-ng/quickjs/blob/v0.8.0/CMakeLists.txt#L31 https://github.com/quickjs-ng/quickjs/blob/v0.8.0/CMakeLists.txt#L32 make test seems to be broken(?) as test262 is empty? /usr/local/bin/cmake -E cmake_progress_start /usr/ports/lang/quickjs-ng/work/.build/CMakeFiles 0 Doesn't seem like expected output? Best regards, Daniel