From nobody Tue Jan 28 22:30:42 2025 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YjKkL719rz5mGQj for ; Tue, 28 Jan 2025 22:30:50 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Received: from smtp-8fa9.mail.infomaniak.ch (smtp-8fa9.mail.infomaniak.ch [IPv6:2001:1600:7:10::8fa9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "relay.mail.infomaniak.ch", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YjKkL1KYJz3H1p for ; Tue, 28 Jan 2025 22:30:50 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Authentication-Results: mx1.freebsd.org; none Received: from smtp-4-0001.mail.infomaniak.ch (unknown [IPv6:2001:1600:7:10:40ca:feff:fe05:1]) by smtp-4-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4YjKkC0Frrz1Z0; Tue, 28 Jan 2025 23:30:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pyret.net; s=20231006; t=1738103442; bh=45rwpOk9BxD8Zm5XCvmUW1FTovBMndrB50kY23qh0zM=; h=Date:Subject:From:Reply-To:To:Cc:References:In-Reply-To:From; b=nfsj0n8nzEMr0qLE5ekJJHJ3v2QYEiBr70eKnWddCogPpg0m4jnvpdyxqhw4u+BMw +rmh51jqacMBGPltqe7d8QO6Gl+i2I/AD+KpwMzxH47yQdIowgYqemZd0wYDvEkL1G H+Tiv4FW7PtJ4sdbR13XpcxL8gzFyGOkgFBNraPbYQN9EUQm6ZqCw59SJi6bhT3ytE IEDaCTQM6q9q7bBmQttGFR4nNecLn/zm4h88tSdVig+MLXXdyeyUGHh/hNNqf4163X ofgu1yLp9nJVWf9pBmCrN0G+sNd1b/wkMKBs/AUMDm1MWxvQU9qbCE+x8T1/z7ocO9 MKMKkHMWuj6ow== Received: from unknown by smtp-4-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4YjKkB4YvTzMxr; Tue, 28 Jan 2025 23:30:42 +0100 (CET) Message-ID: Date: Tue, 28 Jan 2025 23:30:42 +0100 Subject: Re: git: 6c458c3785df - main - lang/quickjs-ng: add a new port quickjs-ng From: Daniel Engberg Reply-To: Daniel Engberg To: "Sergey A. Osokin" Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="_=_swift_1738103442_378a710b6a5814f1ac7f268fa5649f94_=_" X-WS-User-Origin: eyJpdiI6ImVVQlRDSFc0QlVXVC81ZUxmazJxQlE9PSIsInZhbHVlIjoiMWVCOEZKL3hDaG9jYTF2dWxOWUdjdz09IiwibWFjIjoiNGQ2YTI1MjE3ZmJhMTI1NmMyYzJhNDFiYTY1YzgyMmM0NzZjODliMTEyNjA2NjIyMTYxMmNhZTVlYTQyNDYwYiIsInRhZyI6IiJ9 X-WS-User-Mbox: eyJpdiI6IlRES2RDU0RvRHJWdlkzVlBkWXBYdmc9PSIsInZhbHVlIjoiSlpYL0wrWTVKd1BVeUlnb3ZTNXBrdz09IiwibWFjIjoiZTNhNzNhNDBlMDcyNGZhOWI2ZTlmZjUyYjk0ODM5MDVjYzQ1ZWIzMWQxNTg5YTA5NmRkM2VjMzk2ZjFjNmZhYiIsInRhZyI6IiJ9 X-WS-Location: eJxzKUpMKykGAAfpAmU- X-Mailer: Infomaniak Workspace (1.3.834) References: <202501282103.50SL3WRQ014195@gitrepo.freebsd.org> In-Reply-To: X-Infomaniak-Routing: alpha X-Rspamd-Queue-Id: 4YjKkL1KYJz3H1p X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:29222, ipnet:2001:1600::/32, country:CH] --_=_swift_1738103442_378a710b6a5814f1ac7f268fa5649f94_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2025-01-28T23:14:36.000+01:00, Sergey A. Osokin wrot= e: >=C2=A0Hi=C2=A0Daniel, >=C2=A0 >=C2=A0thanks=C2=A0for=C2=A0the= =C2=A0report. >=C2=A0 >=C2=A0On=C2=A0Tue,=C2=A0Jan=C2=A028,=C2=A02025= =C2=A0at=C2=A010:29:44PM=C2=A0+0100,=C2=A0Daniel=C2=A0Engberg=C2=A0wrote:= >>=C2=A0=C2=A0On=C2=A02025-01-28T22:03:36.000+01:00,=C2=A0Sergey=C2= =A0A.=C2=A0Osokin >>=C2=A0=C2=A0 >>=C2=A0=C2=A0 >>= =C2=A0=C2=A0=C2=A0wrote: >>=C2=A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0The=C2= =A0branch=C2=A0main=C2=A0has=C2=A0been=C2=A0updated=C2=A0by=C2=A0osa: >= =C2=A0 >=C2=A0[new=C2=A0port=C2=A0has=C2=A0been=C2=A0added,=C2=A0skipped]= >=C2=A0 >>=C2=A0=C2=A0Please=C2=A0review=C2=A0the=C2=A0USE_GITHUB= =C2=A0section=C2=A0in=C2=A0Porters=C2=A0Handbook=C2=A0and >>=C2=A0=C2= =A0follow >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0the=C2=A0examples=C2=A0(us= e=C2=A0of=C2=A0variables=C2=A0and=C2=A0ordering) >>=C2=A0=C2=A0 >>= =C2=A0=C2=A0=C2=A0USES=C2=A0contains=C2=A0multiple=C2=A0entries=C2=A0of= =C2=A0cmake >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0USES=C2=A0contains=C2= =A0tar:xz=C2=A0(incorrect) >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0Please= =C2=A0sort=C2=A0USES=C2=A0alphabetically >=C2=A0 >=C2=A0I've=C2=A0creat= e=C2=A0the=C2=A0following=C2=A0patch,=C2=A0based=C2=A0on=C2=A0your=C2=A0and= =C2=A0the=C2=A0Porters >=C2=A0 >=C2=A0Handbook=C2=A0recommendations.= =C2=A0Could=C2=A0you=C2=A0please=C2=A0review=C2=A0the=C2=A0changes, >= =C2=A0 >=C2=A0thanks. >=C2=A0 >>=C2=A0=C2=A0Fails=C2=A0to=C2=A0build= =C2=A0when=C2=A0CPUTYPE=C2=A0is=C2=A0set=C2=A0to=C2=A0znver3=C2=A0,=C2= =A0znver4,=C2=A0haswell=C2=A0to >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0ment= on=C2=A0a=C2=A0few >=C2=A0 >=C2=A0I=C2=A0do=C2=A0not=C2=A0have=C2=A0acc= ess=C2=A0to=C2=A0such=C2=A0platforms=C2=A0to=C2=A0test=C2=A0a=C2=A0build.= =C2=A0Feel >=C2=A0 >=C2=A0free=C2=A0to=C2=A0update=C2=A0the=C2=A0port= =C2=A0with=C2=A0the=C2=A0list=C2=A0of=C2=A0supported=C2=A0or=C2=A0failed = >=C2=A0 >=C2=A0platform. >=C2=A0 >=C2=A0Thank=C2=A0you=C2=A0once= =C2=A0again. >=C2=A0 >=C2=A0--=C2=A0 >=C2=A0 >=C2=A0Sergey=C2=A0A.= =C2=A0Osokin Hi, USES looks ok, https://docs.freebsd.org/en/= books/porters-handbook/book/#makefile-master_sites-github DISTVERSION= =C2=A0and=C2=A0DISTVERSIONPREFIX=C2=A0should=C2=A0be=C2=A0used=C2=A0(exampl= e=C2=A016) GH_PROJECT=C2=A0isn't=C2=A0neeed=C2=A0(see=C2=A0Table=C2=A05)= It fails on any platform that enables AVX2=C2=A0 ( __AVX2__) If = you comment L31 and L32 it at least compiles https://github.com/quickj= s-ng/quickjs/blob/v0.8.0/CMakeLists.txt#L31 https://github.com/quickjs= -ng/quickjs/blob/v0.8.0/CMakeLists.txt#L32 make test seems to be broke= n(?) as=C2=A0 test262 is empty? /usr/local/bin/cmake -E cmake_progress= _start /usr/ports/lang/quickjs-ng/work/.build/CMakeFiles 0 =C2=A0 = Doesn't seem like expected output? Best regards, Daniel --_=_swift_1738103442_378a710b6a5814f1ac7f268fa5649f94_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
On 2025-01-28T23:14:36.000+01:00, Sergey A. Os= okin <osa@freebsd.org> wrote:
Hi Daniel,

thanks for the =
report.

On Tue, Jan 28, 2025 at 10:29:44PM +01=
00, Daniel Engberg wrote:
 =
 On 2025-01-28T22:03:36.000+01:00, Sergey A. Osokin <osa@FreeBSD.org>
=

 wrote:
 
   =
The branch main has been updated by osa:
=
 
[new port has been added, skipped]

=


  Please review the U=
SE_GITHUB section in Porters Handbook and follow
 the example=
s (use of variables and ordering)
 USES contains multiple ent=
ries of cmake
 USES contains tar:xz (incorrect)
 Please sort USES alphabetically

I've create the following patch, based on your and the Porters
<= div>Handbook recommendations. Could you please review the changes,
thanks.

Fails to build when CPUTYPE is set to znver3 , znver4, haswell to
<= /div>
menton a few

I do not= have access to such platforms to test a build. Feel
free to= update the port with the list of supported or failed
platfor= m.

Thank you once again.

--
Sergey A. Osokin
Hi,

USES looks ok,

DISTVERSION and DISTVERSIONPR=
EFIX should be used (example 16)
GH_PROJECT isn't neeed (see Table 5)
It fails on any platform that enables AVX2  ( __AVX2__)

If you comment L31 and L32 it at le= ast compiles


make test seems to be broken(?) as  test262 is empty?
=
/usr/local/bin/cmake -E cmake_progress_start /usr/ports/la= ng/quickjs-ng/work/.build/CMakeFiles 0
 
=
Doesn't seem like expected output?

Best regards,
Daniel


--_=_swift_1738103442_378a710b6a5814f1ac7f268fa5649f94_=_--