Re: git: 4a72fdf13706 - main - misc/pytorch: fix build on arm64
- In reply to: Alexey Dokuchaev : "Re: git: 4a72fdf13706 - main - misc/pytorch: fix build on arm64"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 09 Jul 2024 19:52:59 UTC
No, I just wanted to check whether my pkg-plist patch (which fixes check-plist on powerpc64le) also helps on aarch64 and it turned out aarch64 needed another fix. I don't really use pytorch and recently got too much to work on other things to start upstreaming patches... On 24-07-09 10:35:23, Alexey Dokuchaev wrote: >On Tue, Jul 09, 2024 at 10:04:52AM +0000, Piotr Kubaj wrote: >> commit 4a72fdf137062c477b25bf1602d57745b569a352 >> >> misc/pytorch: fix build on arm64 >> ... >> + # Enable conditional FP16 arithmetic intrinsics >> +-if(CPU_AARCH64 AND LINUX) >> ++if(CPU_AARCH64 AND CMAKE_SYSTEM_NAME MATCHES "FreeBSD") > >Looks like in its current form the patch isn't quite upstreamable. >Did you try to raise this issue with developers to come up with >more generic solution? Ad-hoc patches might fix some problem in >the moment but often become extra burden for ports' maintainers >with future updates. > >./danfe