From nobody Tue Jul 09 19:52:59 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WJWqZ34kNz5Qywh; Tue, 09 Jul 2024 19:52:42 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from mail.anongoth.pl (mail.anongoth.pl [46.248.190.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X448 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "anongoth.pl", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WJWqY3DpPz4tKn; Tue, 9 Jul 2024 19:52:41 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Authentication-Results: mx1.freebsd.org; none Received: from anongoth.pl (unknown [192.168.1.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: pkubaj@anongoth.pl) by mail.anongoth.pl (Postfix) with ESMTPSA id A59F656E1A; Tue, 09 Jul 2024 21:52:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=anongoth.pl; s=ANONGOTH; t=1720554749; bh=RfsO5GymoNgQASr9VOfDS0wrcRZetUteQS+9oR/Pi8c=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=uuIYWlVb/yTIwQnj6rTi1THvrtSCsIpengCLppk5XLFyDm0hn+6baMGhc3A3flgrc PCv4+NjCWe9WH8SSkK4v5wVUbt256RBgHg2QG9FsuJ+i+y2tZSv9LKk8asY8jRif1J Kur5tAWmeo7WUA/UwORmo5fbWGjzCKNGIuEcBA1BCkzsIIvX1eNnQGJr2gKGU45RUO 9vRtsi9NHyIezwxolKC+vhPV+GRozFHZc16PUkrh3uM7Z11FPFttKBiAODr+QL18n7 cK8X+7QT9gZkBTmPnpx6MzxNHCNr/wq8WZxmeKuGuCbr+mFfIWepa7luljoH8NmtRk HNrnygyTaR3TA== Date: Tue, 9 Jul 2024 21:52:59 +0200 From: Piotr Kubaj To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 4a72fdf13706 - main - misc/pytorch: fix build on arm64 Message-ID: References: <202407091004.469A4q1M005462@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="p+ct5LQvFYgUnbEG" Content-Disposition: inline In-Reply-To: X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:47544, ipnet:46.248.160.0/19, country:PL] X-Rspamd-Queue-Id: 4WJWqY3DpPz4tKn --p+ct5LQvFYgUnbEG Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline No, I just wanted to check whether my pkg-plist patch (which fixes check-plist on powerpc64le) also helps on aarch64 and it turned out aarch64 needed another fix. I don't really use pytorch and recently got too much to work on other things to start upstreaming patches... On 24-07-09 10:35:23, Alexey Dokuchaev wrote: >On Tue, Jul 09, 2024 at 10:04:52AM +0000, Piotr Kubaj wrote: >> commit 4a72fdf137062c477b25bf1602d57745b569a352 >> >> misc/pytorch: fix build on arm64 >> ... >> + # Enable conditional FP16 arithmetic intrinsics >> +-if(CPU_AARCH64 AND LINUX) >> ++if(CPU_AARCH64 AND CMAKE_SYSTEM_NAME MATCHES "FreeBSD") > >Looks like in its current form the patch isn't quite upstreamable. >Did you try to raise this issue with developers to come up with >more generic solution? Ad-hoc patches might fix some problem in >the moment but often become extra burden for ports' maintainers >with future updates. > >./danfe --p+ct5LQvFYgUnbEG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJkBAABCgBOFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmaNlRswFIAAAAAAFQAS cGthLWFkZHJlc3NAZ251cGcub3JncGt1YmFqQGFub25nb3RoLnBsAAoJEHpZm4Ug g5ydUNcP/0EEFyySjjjW6PSy8Kzbdw6/wN8GbhSurIYcXa1Tob58IxPDUQsYky0R BlT+w5tD7//UJ6M1psxYn5x2sVP1b4OXSBiz4rMtbpXhczOiS15ElDUfNW7o7Fk1 c7XHIvx6AOYq2osI2x8KtPUSkEtCvf+RMqfrQk0+cydjIURhVnAXuwcVzv59b2bm h7PXQkRkEbNI0ZRQPXE4GW3IJiZYU02o4xfNLmq9ucXaU2p2XVwuc6xwT8N1qMom A2d1vFNNHZ5MCUpXdZGV/SrbXhTmfVUNfcM/Ze9PAuF+Uqyhmlhr/MpkndiTzhkd S881WeRtZN+6B0PJgp2zk3h7DFMQD6IeOHRe4Ozx28MobdI/2fcBuLNFuAWbJgHE XgIlWIbvwQEp4exZGKs7fFnJKKzq4UUXajcJj0D/F5KaSkYB3BCJ5DIlTCkdrxma WLgzBSoTC2WZ3ZtdpmpySQ8tYaaPmAldPOSJSoZfd0ijHY8FCq1lPxjGADSl50U1 VOcRmYhWHGAN6G1DWr7ZYaE5yZhS+MqhdLEQXvvVa7sMhXq9hKVknMRK+ndmTx86 pE/92qyWEaEejvNqaNheESPhdL4ducevJpyScISz5xOI90rpIk8M0tVrz83yZ+5E TYjpO+ZjglYwYKwyLaAmLNLa0dnrfj5NcGYmA/d5YaisroZAT8/N =J1Yj -----END PGP SIGNATURE----- --p+ct5LQvFYgUnbEG--