Re: git: b430a140c818 - main - net-im/purple-gowhatsapp: add WhatsApp plugin for libpurple
- Reply: Kurt Jaeger : "Re: git: b430a140c818 - main - net-im/purple-gowhatsapp: add WhatsApp plugin for libpurple"
- Reply: Daniel Engberg : "Re: git: b430a140c818 - main - net-im/purple-gowhatsapp: add WhatsApp plugin for libpurple"
- In reply to: Daniel Engberg : "Re: git: b430a140c818 - main - net-im/purple-gowhatsapp: add WhatsApp plugin for libpurple"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sun, 21 Jan 2024 18:27:04 UTC
21.01.24 06:11, Daniel Engberg: > While neither Porters Handbook or Committers Guide say it's a > requirement it's quite strongly suggested that you do use it. Thank you, Daniel, for confirming, no actual rules were broken by my commit. > Given that all pkg-fallout mails are from Poudriere it's more or less > implied as committer to use it. I don't see the implication at all. I appreciate the fallout e-mails, but I don't see, why that makes it mandatory for me to use the same tool(s) locally. For example, the cluster builds every port on multiple hardware platforms -- for different OS-releases. Does that imply the committers also must have such multitude of different hardware/release combinations locally too? I still don't understand, why you asked me to backout... Mat's attempt at answering amounted to: "Because you broke the rules!" -- which is not a valid reason even if any rules really were broken. Clearly a personal thing... If the 37 seconds it took the cluster to fail the port is really such a drain on the resources, marking the port BROKEN would be a thing to do -- that's a one-line change, that still keeps the code available for sharing. Anyway, I think, I hacked the port into pre-fetching the additional modules using go.mk's facilities, and will be committing that shortly. It still is not perfect, because the port is a mixture of C and Go-code, but it should build fine now. Thank you for the feedback. Yours, -mi