Re: git: ccc21de09381 - main - devel/binutils: Add devel/elfutils dependency options

On Wed, Aug 28, 2024 at 11:04:39AM GMT, Cy Schubert wrote:
> In message <CALH631nFVYyks4DB+T8+C8r5Y6GHT4Su8mzhDaJ8BQ1=PMVZPA@mail.gmail.c
> om>
> , Gleb Popov writes:
> > On Wed, Aug 28, 2024 at 7:03=E2=80=AFPM Cy Schubert <cy@freebsd.org> wrote:
> > >
> > > +# In case devel/elfutils has been previously installed.
> > > +.if ${PORT_OPTIONS:MELFU_AUTO} && exists(${LOCALBASE}/lib/libdebuginfod.=
> > so)
> > > +LIB_DEPENDS+=3D  libdebuginfod.so:devel/elfutils
> > > +.endif
> >
> > Hmm, this looks strange to me. LIB_DEPENDS is used to pull in
> > libraries that are missing, but then the "exists" condition will
> > always be false.
> 
> Correct. The condition will always be false when building with poudriere 
> but for those building the port by hand, and have manually installed 
> devel/elfutils prior to building and installing manually the condition will 
> then be true.
> 
> Much committers' dismay some users don't use binary packages, you and I as 
> committers prefer people use binary packages. But unfortunately this is not 
> always the case. The PR was submitted by a person who builds his ports by 
> hand.

It would be better to disable the finding of libdebuginfod in LOCALBASE,
so that everyone has the same binutils, and nobody gets a possibly
different behavior.

-- 
Mathieu Arnold