From nobody Thu Aug 29 05:44:33 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvVbS3hSnz52VM0; Thu, 29 Aug 2024 05:44:36 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvVbS36hlz4qMl; Thu, 29 Aug 2024 05:44:36 +0000 (UTC) (envelope-from mat@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724910276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Vs4dGS2lDGxizGdDkacb/m4yoizFIdjhuXp9y9hHznM=; b=odAUXJYDwz5/f18zCxH6dDyaUSNnJIRvSpBZ8wQA8z6/fVpOO3ai/96G4TGChUcgF9Hzd7 91tbmK31V8csuj7LbrBDjXVPLUqMVlmr8Ue6Oft3rwWHB8k+SRjVmdTIN/iIZLcPpLlRlH pLjKPcYRnhsd8BdDG1WH+J0ABk4ldMu1kaAat1ZrMS1vtZEeI49AWrZ/evncqarsiH/+BI oicT93qIXgSHYnnKMjN2mOjP8y+qNeQogC7z5ksQk2TYdVbyBb2nUYUpB5Q/xRQW4ICB9E Uz58radO5YDEbyIse+8IDSL54/Q2GSY980t52m6IRTKHU9SUcbhGN9WmBemf8w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724910276; a=rsa-sha256; cv=none; b=u3vACt/9x7F5J9LfDZ9ET3fDSUMzrST9wYjDIXViz4zWPR/fvhuXhFV8U7BnK0D0teNeCM /ceyUkHoefm+X4Hd3gGFc7dvfVC7laCOc6wjBFUWH09uAfUncH1+uI22HpT9zm+2kMUARt LMP+RotUIXNj8pzatG0qyL6oQvzpQbwIfmWU5rKk6tCX6AVld5BBL8pL1NsinxO/n9WMD0 WKwa9IXmE0VqVyrx6/yCMo2CiCE0qv7IWQABlzPPxT23eCPkyCHLU6xPVqODLhItIfQwId bXmxipgQOCEQs00s1u0187nWQJzCzq8sK8RN3oPZU0Mw+9kuKSek4aqkRvAdOQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724910276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Vs4dGS2lDGxizGdDkacb/m4yoizFIdjhuXp9y9hHznM=; b=xHW2QD9U5Lpff5r/bs207mHb0ulP9rtTsuKb0hdPJAFN6kCvDLHjN9sS+VNbEg9MctFFmg P7WDDkH059li8Ws0p41ICyeYWw7mzRCHmRGXDM/YsCgR4MPSXoxQD6ybUuGSxDNy+SDe9b Aj/M0gkU5b5FT5PM/f4WZNM3CZET/X3qW6Tr4HpIO4tkPVfptRRTxwoKoZEg6LfBrrcLPT CzTxlg75uWyygdWzThxyJ8omGtRiazYqphLQYlt8WM87JlkHo70z2d380UeuiSQfyH4O85 1F4hCTyHwdhWJ/8vUyXllkGgRWtpuft7U5e0rcTrIAJUnxp5hhdVlrw8vOazrg== Received: from relay.mat.cc (cow.mat.cc [79.143.244.49]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "cow.mat.cc", Issuer "R10" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4WvVbS1wFZz1R4d; Thu, 29 Aug 2024 05:44:36 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:e0a:836:f670:6cab:10d9:7aac:9234]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by relay.mat.cc (Postfix) with ESMTPSA id 3DE2C1FD1F; Thu, 29 Aug 2024 07:44:34 +0200 (CEST) Date: Thu, 29 Aug 2024 07:44:33 +0200 From: Mathieu Arnold To: Cy Schubert Cc: Gleb Popov , Cy Schubert , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: ccc21de09381 - main - devel/binutils: Add devel/elfutils dependency options Message-ID: <2ypgfpzxn7m4jzzbacyvrlw7htj5iyg7zwdb7mjcbknfjr3ee4@ipqdfyay3s4m> References: <202408281603.47SG35Q9035605@gitrepo.freebsd.org> <20240828180439.22B0730E@slippy.cwsent.com> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="t2cwj7kshsfy5exo" Content-Disposition: inline In-Reply-To: <20240828180439.22B0730E@slippy.cwsent.com> --t2cwj7kshsfy5exo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 28, 2024 at 11:04:39AM GMT, Cy Schubert wrote: > In message om> > , Gleb Popov writes: > > On Wed, Aug 28, 2024 at 7:03=3DE2=3D80=3DAFPM Cy Schubert wrote: > > > > > > +# In case devel/elfutils has been previously installed. > > > +.if ${PORT_OPTIONS:MELFU_AUTO} && exists(${LOCALBASE}/lib/libdebugin= fod.=3D > > so) > > > +LIB_DEPENDS+=3D3D libdebuginfod.so:devel/elfutils > > > +.endif > > > > Hmm, this looks strange to me. LIB_DEPENDS is used to pull in > > libraries that are missing, but then the "exists" condition will > > always be false. >=20 > Correct. The condition will always be false when building with poudriere= =20 > but for those building the port by hand, and have manually installed=20 > devel/elfutils prior to building and installing manually the condition wi= ll=20 > then be true. >=20 > Much committers' dismay some users don't use binary packages, you and I a= s=20 > committers prefer people use binary packages. But unfortunately this is n= ot=20 > always the case. The PR was submitted by a person who builds his ports by= =20 > hand. It would be better to disable the finding of libdebuginfod in LOCALBASE, so that everyone has the same binutils, and nobody gets a possibly different behavior. --=20 Mathieu Arnold --t2cwj7kshsfy5exo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmbQCr9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb610Qv/eH3c0+UHjOQ1CC9dLhwiwbM9aRNX1Qj7E+uI1rzBjVqKAyGDFWqkUR0+ sLlvyIPBhR/coI0DZ6x+HbxfT4ob2cFzm7yMhY4tQ2RMrgq1dutoPDvMYE5sP9KS 1Lj93mFTFJGUeFrCdaCUltFNKr+J3cjHMGwauUak+Y3KpjA0PEGqDM9qjZahUFxN FaGrwwsCxQufId3Xu50WRezAbwl25ymlMWcA3Az0lv63uni2OJrZAXffD4FRnrwV w3eOM71IH60Rf9/ZmlHx6uO0Xl9ohTRdmEoQECdWURmy8dCy960Fp7J1uVraYQ8Y A0wbxq8KYAJ4e+OdcLFYD5ARXGtTtMPdp+xfEMrJP3leGMkq5BQMr68d4K0ole4r seqgo824ksJwuTQo0iLCxCpbNvDM6oD8lKOIk+Q3kRqWir0beOdr1EcOnchplG8E uoE9ZP8e+oF7ntiIbNRZSlP4s26hGaN/Ah9sSpvQ2dhwj+yAGcDgsVQzUoARWRaa JTSnICE+ =WpFR -----END PGP SIGNATURE----- --t2cwj7kshsfy5exo--