Re: git: 779e8ab2600f - main - lang/gcc12-devel: Fix enable init_array patch

On Sun, May 21, 2023 at 07:29:37AM +0000, Lorenzo Salvadore wrote:
> ------- Original Message -------
> On Saturday, May 20th, 2023 at 6:01 PM, Rene Ladan <rene@freebsd.org> wrote:
> 
> 
> >
> >
> > On Sat, May 20, 2023 at 02:18:08PM +0000, Lorenzo Salvadore wrote:
> >
> > > The branch main has been updated by salvadore:
> > >
> > > URL: https://cgit.FreeBSD.org/ports/commit/?id=779e8ab2600fba5f045d80a1420f9f2278daad62
> > >
> > > commit 779e8ab2600fba5f045d80a1420f9f2278daad62
> > > Author: Lorenzo Salvadore salvadore@FreeBSD.org
> > > AuthorDate: 2023-05-20 00:38:33 +0000
> > > Commit: Lorenzo Salvadore salvadore@FreeBSD.org
> > > CommitDate: 2023-05-20 14:17:36 +0000
> > >
> > > lang/gcc12-devel: Fix enable init_array patch
> > >
> > > Add an error line that was missing in case _FreeBSD_version < 1000010.
> > >
> > > Reported by: gnikl@users.sourceforge.net
> > > Fixes: 8c2a479977f0 lang/gcc12-devel: Enable support for .init_array and .fini_array
> >
> >
> > A bit late, but why check for FreeBSD versions that are end-of-life for at
> > least five years instead of just unconditionally enabling them?
> 
> For consistency with upstream. Upstream does such kind of checks for glibc and
> Solaris, so I have added a similar check for FreeBSD to increase the chances to
> have the patch merged upstream.
> 
Ah, that makes sense, thanks for explaining.

> I should probably have written it in the original commit message, I am sorry
> I have forgotten it. Anyway, if I manage to get the patch upstreamed, then the
> corresponding files in the ports tree will not be needed any more, so it should
> not be a big deal hopefully.
> 
> Cheers,
> 
> Lorenzo Salvadore

René