From nobody Sun May 21 07:57:58 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QPCcR1p3Vz4CCCh; Sun, 21 May 2023 07:57:59 +0000 (UTC) (envelope-from rene@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QPCcQ6wG1z3scg; Sun, 21 May 2023 07:57:58 +0000 (UTC) (envelope-from rene@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684655879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j9Tab5qnu7LWMl2q8shbndCm4j9wWrMzRHsB9JJdMIc=; b=HGrGuFWlGm0wqMpMBCcZk2e/+4jphtHGGOAO5v96Asw4dYnrsKTcMeDQGJZZKwNkn1z0u8 /TGFvCKPrO0II8KArkhNcJfo3nhgwjWboVnJfu5qxZ9AdTrW8XqTvfIPTnlj76ujwc/Lt1 GR5ucZHtL/cw3boDCJk0N4W74YLvMfj+FTIoNgtCZ9WKmxEMRg6UAKbYodDPt3Ml/WpIPC DxKkO9/aXM4T9pCxBUyeRlyOIN4sCp5Y9f+BkTalcnNvaUqCjU87gPjB22XZ3rW/tw2dFe SCSFv1wrXiENRKX7MSuchKXKQkUmYu5yeR6om3RAkSK1rTlknrqlclor1F5Gag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684655879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j9Tab5qnu7LWMl2q8shbndCm4j9wWrMzRHsB9JJdMIc=; b=PkYOv8//B2NHuXXcPgLbd+kSeZ7v4Ji9A6OGsw8bKSncbvAYcOqz/SCjxFIueoDyQn5nh5 wS8fO0Tc4mLp2Ea6GtwTg9ZVtAhfTY7XwuFEm3vTTY8K3s49sAoKkX6eWZI1JdjbOz6ufc vWhS4Fq0ZpDy41qH6VtEl0dVDzbIgCjUH01FRI0slPa7inMNbRw19Vqp0rouZ9arWYaQcm 2ox5uFzYogBpWi5gDc0AjsLkYxE+humu9ULnm51OOQkXfnmjwtAJ+FppOjbd7woLufzdsO rFg7iQR04JgndfR82P+JKPSiMuMIqHDUDnU+8ikZQGBhv+N8++kcVYQxMkzYLg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1684655879; a=rsa-sha256; cv=none; b=FWFOoTjWvQRGsgE8MlPiX3m1WQitf3wqBOyJUL2qV0rkUuNXKY0M7YRFdgGb/GxnMN0eAm 6YDRxg7Z+h2LOa+mGsAzDV9ZtQwryOnnKsJdKpIvdguC6QVCWQ+OFNQX7lDaRc+rHmeeoS 4a285b89nucSE7dxTd5ub558D9KtZ2gE6JYLKk12zlijkc+q9KLJI0Ca6akTsbvBnVKqlR KNcOF9JofIdAGm3VrPmlnZhgpXx2KAd/1qJovDuEchI69ScMen9uHkE6e5IGCE7E2x6woU ajyqqEf5SEwTZRZHYcSjt8jLj3TmZVl0Y1X3w93DRd9BkCoX6i2Uq5E9r6dqGg== Received: by freefall.freebsd.org (Postfix, from userid 1185) id D77515847; Sun, 21 May 2023 07:57:58 +0000 (UTC) Date: Sun, 21 May 2023 07:57:58 +0000 From: Rene Ladan To: Lorenzo Salvadore Cc: Lorenzo Salvadore , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 779e8ab2600f - main - lang/gcc12-devel: Fix enable init_array patch Message-ID: References: <202305201418.34KEI8Ii081953@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ThisMailContainsUnwantedMimeParts: N On Sun, May 21, 2023 at 07:29:37AM +0000, Lorenzo Salvadore wrote: > ------- Original Message ------- > On Saturday, May 20th, 2023 at 6:01 PM, Rene Ladan wrote: > > > > > > > > On Sat, May 20, 2023 at 02:18:08PM +0000, Lorenzo Salvadore wrote: > > > > > The branch main has been updated by salvadore: > > > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=779e8ab2600fba5f045d80a1420f9f2278daad62 > > > > > > commit 779e8ab2600fba5f045d80a1420f9f2278daad62 > > > Author: Lorenzo Salvadore salvadore@FreeBSD.org > > > AuthorDate: 2023-05-20 00:38:33 +0000 > > > Commit: Lorenzo Salvadore salvadore@FreeBSD.org > > > CommitDate: 2023-05-20 14:17:36 +0000 > > > > > > lang/gcc12-devel: Fix enable init_array patch > > > > > > Add an error line that was missing in case _FreeBSD_version < 1000010. > > > > > > Reported by: gnikl@users.sourceforge.net > > > Fixes: 8c2a479977f0 lang/gcc12-devel: Enable support for .init_array and .fini_array > > > > > > A bit late, but why check for FreeBSD versions that are end-of-life for at > > least five years instead of just unconditionally enabling them? > > For consistency with upstream. Upstream does such kind of checks for glibc and > Solaris, so I have added a similar check for FreeBSD to increase the chances to > have the patch merged upstream. > Ah, that makes sense, thanks for explaining. > I should probably have written it in the original commit message, I am sorry > I have forgotten it. Anyway, if I manage to get the patch upstreamed, then the > corresponding files in the ports tree will not be needed any more, so it should > not be a big deal hopefully. > > Cheers, > > Lorenzo Salvadore René