Re: git: b56d0bc41af7 - main - devel/libcutl: Explain why USE_CXXSTD=c++11 is used

Hello Raphael,

Really nice and explaining comment on std c++11 fixes. I will use same
comment on ports needed it to work in clang 16, e.g., net-p2p/amule that
needs it.

Just a question, should a PORTREVISION bump reccomended when we set
USE_CXXSTD=c++11?

Thanks,

Raphael Kubo da Costa <rakuco@freebsd.org> escreveu no dia quarta,
5/07/2023 à(s) 09:50:

> The branch main has been updated by rakuco:
>
> URL:
> https://cgit.FreeBSD.org/ports/commit/?id=b56d0bc41af79bf3a51f89249e96ec02b7fc464e
>
> commit b56d0bc41af79bf3a51f89249e96ec02b7fc464e
> Author:     Raphael Kubo da Costa <rakuco@FreeBSD.org>
> AuthorDate: 2023-07-05 08:49:09 +0000
> Commit:     Raphael Kubo da Costa <rakuco@FreeBSD.org>
> CommitDate: 2023-07-05 08:49:09 +0000
>
>     devel/libcutl: Explain why USE_CXXSTD=c++11 is used
>
>     While here, also add a note to its only consumer, devel/xsd, to mention
>     why it also needs USE_CXXSTD and when it can be removed.
> ---
>  devel/libcutl/Makefile | 2 ++
>  devel/xsd/Makefile     | 3 +++
>  2 files changed, 5 insertions(+)
>
> diff --git a/devel/libcutl/Makefile b/devel/libcutl/Makefile
> index 323b2b44feee..bbaad70028c2 100644
> --- a/devel/libcutl/Makefile
> +++ b/devel/libcutl/Makefile
> @@ -17,6 +17,8 @@ LIB_DEPENDS=  libboost_system.so:devel/boost-libs \
>                 libexpat.so:textproc/expat2
>
>  USES=          compiler:c++11-lib libtool
> +# libcutl 1.10.0 is not compatible with C++17, which is the default since
> clang
> +# 16. This means ports depending on it also need to use at most C++14.
>  USE_CXXSTD=    c++11
>  GNU_CONFIGURE= yes
>  INSTALL_TARGET=        install-strip
> diff --git a/devel/xsd/Makefile b/devel/xsd/Makefile
> index 06e02ce6f72c..010b73e6e9e4 100644
> --- a/devel/xsd/Makefile
> +++ b/devel/xsd/Makefile
> @@ -23,6 +23,9 @@ LIB_DEPENDS=  libcutl.so:devel/libcutl \
>                 libxerces-c.so:textproc/xerces-c3
>
>  USES=          compiler:c++11-lang ghostscript:build gmake
> localbase:ldflags tar:bzip2
> +# devel/libcutl 1.10.0 does not work with C++17 which is the default since
> +# clang 16. This can be removed once that port starts working with C++17
> and
> +# has its own USE_CXXSTD removed.
>  USE_CXXSTD=    c++11
>
>  MAKEFILE=      makefile
>


-- 
Nuno Teixeira
FreeBSD Committer (ports)