From nobody Wed Jul 05 09:13:45 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qwv9K4tFKz4l8m5; Wed, 5 Jul 2023 09:13:57 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Qwv9K4QwHz4MQ0; Wed, 5 Jul 2023 09:13:57 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1688548437; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6KEbdv78iyw0HBdL0r0Ju4YzGVlcPtSANgVLy7uI4ZU=; b=fGL8pS0Wv8KW3o51x8XzXHNKf8+P+4hjsPR5vaPJn2E8tToWxaVLi3di9S9b+01U9tF4Sj a3TmkkJNFA6u3qcOGZm+5KaeM9OantNlTy2RoRF8Fw1dlEQBFMLPkFu/9jBfP1GjBPp+EC vBmz7YR/YcZ9p1bd247tlcjj1lmnbjbPNXyx4NqokWJpWbc+FRN3Ufhg+zJcqjfozfiJLm SL0jS1QDgIO2S2h+5XQlrh3Yumxwso79WNm9A7wbSRorhfyAW26lZvj3xuEBbPaCGVvWrv DiwEFuSnA3iJfldtuDJNeTyZ3iU5mLO2172jz8FqPVndFjeaXEP6Un3z6Foazw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1688548437; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6KEbdv78iyw0HBdL0r0Ju4YzGVlcPtSANgVLy7uI4ZU=; b=bvyE9EDuEQCfxd11agxTJMGnHcS7I/7XY6zp3mbWuP/o7o/gqIYupnN5qZeatvCO/QybaM LnNuT228mCdF8FlzarDQ4c83enwY5DOnDTTnh1BIdxS8kOlxkmx/tfy8uXzHJV3W/BVs3g k946NW43NHV2ZzyJODp8/NaTSoqob2hUIwXIMHNMTyy0Zui5qqD7S01JyAPoETv0jB5TIO 2I9ZBCnw0H78BLQForfs5JQu4NlbxVBdeqjwSvgAkFjdmlC67P6SQNRvJqns5kGU0qKjzt 6ZgJn9h5gG/1YG2LLZ65Ghvqe+93JyESbP0Z2jpTCyba3foxp4Q3BESMPjLkVw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1688548437; a=rsa-sha256; cv=none; b=F9A5m35D+79dDu+WoEpXr+packWgLOBwY07p2VbwMTTZdmZp0/+H2ozy9+/T7TtV9lLGkw spHbG80DoQT1zLrIz8evj8Q+pJoMVEq+PG/orHOVStEB1ZQunsVwTDKUYKWrbaYhXmtWJi P38ZzRu80DcziLeRda69TODFzsdx5aLfPErGP4Q2r2Xat2gzUNDw74WrxSwO/4Gnnkb7Ui Ia1l9gn2ql1DYGAmGURSP59CxViRgUPZwzuYVd9jclPcreyOigwSAJfiWhG11+8GdsslLR o9Fr72y6idcRnrmmuV0LBWXOTPDV3+eZHdsjazLtUyrVX4svcLf+RDp0I/N8rg== Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Qwv9K3WTPzfS0; Wed, 5 Jul 2023 09:13:57 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-401e0ceb4e6so51635841cf.1; Wed, 05 Jul 2023 02:13:57 -0700 (PDT) X-Gm-Message-State: AC+VfDzjgSAffNpT0ww2Kc9DdHnOBf8/Id8TMdww/twq2hggAJc92VQG pzsN5Jboy7m5N23GVy+DpVQNQHXEl9OUDbte3sc= X-Google-Smtp-Source: ACHHUZ6YC+7WqdWsR2xXT6yvTnDbUqxvc+Z21JF7EehiD1XzHruxxk/rpdhKA1Vl6QRDmIzTfLqS9cPghHcnoaD/2VQ= X-Received: by 2002:a05:622a:110:b0:400:aa4d:7a5d with SMTP id u16-20020a05622a011000b00400aa4d7a5dmr18987163qtw.24.1688548437183; Wed, 05 Jul 2023 02:13:57 -0700 (PDT) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 References: <202307050850.3658oPOA049562@gitrepo.freebsd.org> In-Reply-To: <202307050850.3658oPOA049562@gitrepo.freebsd.org> From: Nuno Teixeira Date: Wed, 5 Jul 2023 10:13:45 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: b56d0bc41af7 - main - devel/libcutl: Explain why USE_CXXSTD=c++11 is used To: Raphael Kubo da Costa Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000c8d2cd05ffb9d1df" X-ThisMailContainsUnwantedMimeParts: N --000000000000c8d2cd05ffb9d1df Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Raphael, Really nice and explaining comment on std c++11 fixes. I will use same comment on ports needed it to work in clang 16, e.g., net-p2p/amule that needs it. Just a question, should a PORTREVISION bump reccomended when we set USE_CXXSTD=3Dc++11? Thanks, Raphael Kubo da Costa escreveu no dia quarta, 5/07/2023 =C3=A0(s) 09:50: > The branch main has been updated by rakuco: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=3Db56d0bc41af79bf3a51f89249e96e= c02b7fc464e > > commit b56d0bc41af79bf3a51f89249e96ec02b7fc464e > Author: Raphael Kubo da Costa > AuthorDate: 2023-07-05 08:49:09 +0000 > Commit: Raphael Kubo da Costa > CommitDate: 2023-07-05 08:49:09 +0000 > > devel/libcutl: Explain why USE_CXXSTD=3Dc++11 is used > > While here, also add a note to its only consumer, devel/xsd, to menti= on > why it also needs USE_CXXSTD and when it can be removed. > --- > devel/libcutl/Makefile | 2 ++ > devel/xsd/Makefile | 3 +++ > 2 files changed, 5 insertions(+) > > diff --git a/devel/libcutl/Makefile b/devel/libcutl/Makefile > index 323b2b44feee..bbaad70028c2 100644 > --- a/devel/libcutl/Makefile > +++ b/devel/libcutl/Makefile > @@ -17,6 +17,8 @@ LIB_DEPENDS=3D libboost_system.so:devel/boost-libs \ > libexpat.so:textproc/expat2 > > USES=3D compiler:c++11-lib libtool > +# libcutl 1.10.0 is not compatible with C++17, which is the default sinc= e > clang > +# 16. This means ports depending on it also need to use at most C++14. > USE_CXXSTD=3D c++11 > GNU_CONFIGURE=3D yes > INSTALL_TARGET=3D install-strip > diff --git a/devel/xsd/Makefile b/devel/xsd/Makefile > index 06e02ce6f72c..010b73e6e9e4 100644 > --- a/devel/xsd/Makefile > +++ b/devel/xsd/Makefile > @@ -23,6 +23,9 @@ LIB_DEPENDS=3D libcutl.so:devel/libcutl \ > libxerces-c.so:textproc/xerces-c3 > > USES=3D compiler:c++11-lang ghostscript:build gmake > localbase:ldflags tar:bzip2 > +# devel/libcutl 1.10.0 does not work with C++17 which is the default sin= ce > +# clang 16. This can be removed once that port starts working with C++17 > and > +# has its own USE_CXXSTD removed. > USE_CXXSTD=3D c++11 > > MAKEFILE=3D makefile > --=20 Nuno Teixeira FreeBSD Committer (ports) --000000000000c8d2cd05ffb9d1df Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Raphael,

Really nice a= nd explaining comment on std c++11 fixes. I will use same comment on ports = needed it to work in clang 16, e.g., net-p2p/amule that needs it.

Just a question, should a PORTREVISION bump reccomended when we se= t USE_CXXSTD=3Dc++11?

Thanks,

<= div class=3D"gmail_quote">
Raphael Kub= o da Costa <rakuco@freebsd.org= > escreveu no dia quarta, 5/07/2023 =C3=A0(s) 09:50:
The branch main has been updated by= rakuco:

URL: https://cgi= t.FreeBSD.org/ports/commit/?id=3Db56d0bc41af79bf3a51f89249e96ec02b7fc464e

commit b56d0bc41af79bf3a51f89249e96ec02b7fc464e
Author:=C2=A0 =C2=A0 =C2=A0Raphael Kubo da Costa <rakuco@FreeBSD.org>=
AuthorDate: 2023-07-05 08:49:09 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Raphael Kubo da Costa <rakuco@FreeBSD.org>=
CommitDate: 2023-07-05 08:49:09 +0000

=C2=A0 =C2=A0 devel/libcutl: Explain why USE_CXXSTD=3Dc++11 is used

=C2=A0 =C2=A0 While here, also add a note to its only consumer, devel/xsd, = to mention
=C2=A0 =C2=A0 why it also needs USE_CXXSTD and when it can be removed.
---
=C2=A0devel/libcutl/Makefile | 2 ++
=C2=A0devel/xsd/Makefile=C2=A0 =C2=A0 =C2=A0| 3 +++
=C2=A02 files changed, 5 insertions(+)

diff --git a/devel/libcutl/Makefile b/devel/libcutl/Makefile
index 323b2b44feee..bbaad70028c2 100644
--- a/devel/libcutl/Makefile
+++ b/devel/libcutl/Makefile
@@ -17,6 +17,8 @@ LIB_DEPENDS=3D=C2=A0 libboost_system.so:devel/boost-libs = \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 libexpat.so:textpro= c/expat2

=C2=A0USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 compiler:c++11-lib libtool<= br> +# libcutl 1.10.0 is not compatible with C++17, which is the default since = clang
+# 16. This means ports depending on it also need to use at most C++14.
=C2=A0USE_CXXSTD=3D=C2=A0 =C2=A0 c++11
=C2=A0GNU_CONFIGURE=3D yes
=C2=A0INSTALL_TARGET=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 install-strip
diff --git a/devel/xsd/Makefile b/devel/xsd/Makefile
index 06e02ce6f72c..010b73e6e9e4 100644
--- a/devel/xsd/Makefile
+++ b/devel/xsd/Makefile
@@ -23,6 +23,9 @@ LIB_DEPENDS=3D=C2=A0 libcutl.so:devel/libcutl \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 libxerces-c.so:text= proc/xerces-c3

=C2=A0USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 compiler:c++11-lang ghostsc= ript:build gmake localbase:ldflags tar:bzip2
+# devel/libcutl 1.10.0 does not work with C++17 which is the default since=
+# clang 16. This can be removed once that port starts working with C++17 a= nd
+# has its own USE_CXXSTD removed.
=C2=A0USE_CXXSTD=3D=C2=A0 =C2=A0 c++11

=C2=A0MAKEFILE=3D=C2=A0 =C2=A0 =C2=A0 makefile


--
Nuno Teixeira
FreeBSD Committ= er (ports)
--000000000000c8d2cd05ffb9d1df--