Re: git: 72ad532057c9 - main - archivers/zstd: Add CMake config files and adjust Makefile

On Wed, Apr 05, 2023 at 02:20:21PM +0200, Guido Falsi wrote:
> On 05/04/23 08:15, Daniel Engberg wrote:
> > commit 72ad532057c9f9fb6fa370c80f663c005e9dd021
> > 
> >      archivers/zstd: Add CMake config files and adjust Makefile
> >      
> >      - Use upstream's short test for "make test"
> >      - Use verbose output by default during build
> >      * Tweak Makefile to follow Porters Handbook more closely
> >      * Install CMake files (taken from CMake build framework)
> >      
> >      PR:             267652
> >      Reported by:    fluffy
> >      Approved by:    portmgr (maintainer timeout, 1+ month)
> 
> Looks like this, un[luckily], causes a failure with devel/qt6-base
> (abridged error, full log if needed):
> 
> ld: error: relocation R_X86_64_32 cannot be used against local symbol;
> recompile with -fPIC
>  >>> defined in /usr/local/lib/libzstd.a(zstd_common.o)
>  >>> referenced by zstd_common.c
>  >>>               zstd_common.o:(ZSTD_versionString) in archive

Yeah, I'm seeing this as well.  Admittedly, the whole commit looks
dubious to me, with all these out-of-blue new files and gratuitous
changes.  I guess sunpoet@ should revert it and merge only needed
parts thereof properly.

./danfe